New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 614683 link

Starred by 1 user
Status: Fixed
Owner:
█ kozyatinskiy@chromium.org
Last visit > 30 days ago
Closed: May 2016
Cc:
nyerramilli@chromium.org
█ ashej...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unnecessary 'Replace' button is enabled in 'Source' section of dev tools.

Reported by rk...@etouch.net, May 25 2016 
Chrome Version: 51.0.2704.63 Revision 2989ec7055a268f05554172b2207a34c0c842b8d-refs/branch-heads/2704@{#656}(32/64 bit)
OS: Windows (7, 8, 10), Mac (10.10.5)(10.11.4),Linux (ubuntu 14.04 LTS)

What steps will reproduce the problem?
(1) Launch chrome, open dev tools window and open any source file.
(2) Press ctrl+f(Find box will appear), check on Replace option and observe

Unnecessary 'Replace' button is enabled without enter any word in find box.

'Replace' button should be disabled when nothing in find box.

This is a regression issue, broken in 'M-49', below is bisect info:

Good Build: 49.0.2574.0
Bad Build: 49.0.2575.0

Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+log/2ff76a86882308a81d17ac8bbeb57a95c3578a3e..98a0970e6672c6a0638f3d7c72ac4b5edf3aefe2?pretty=fuller&n=100

Suspecting: r361543
Actual_Devtools.mp4
1013 KB Download
Expected_Devtools.mp4
809 KB Download
Project Member

Comment 1 by bugdroid1@chromium.org, May 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58ba9cdfec511787f1b00dc2e9e3036a9a854248

commit 58ba9cdfec511787f1b00dc2e9e3036a9a854248
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Thu May 26 23:40:46 2016

[DevTools] Add white-space:nowrap for "Replace All" search button

Without "nowrap" when text editor has not enough space then All will go to next line.

BUG= 614683 
R=lushnikov@chromium.org

Review-Url: https://codereview.chromium.org/2010223002
Cr-Commit-Position: refs/heads/master@{#396319}

[modify] https://crrev.com/58ba9cdfec511787f1b00dc2e9e3036a9a854248/third_party/WebKit/Source/devtools/front_end/ui/searchableView.css

Comment 2 by kozyatinskiy@chromium.org, May 26 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment