New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 614680 link

Starred by 2 users
Status: Fixed
Owner:
anthonyvd@chromium.org
Closed: Jun 2016
Cc:
nyerramilli@chromium.org
█ ashej...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Chrome browser crashes after closing the 'Person 1' window.

Reported by yfulgaon...@etouch.net, May 25 2016 
Chrome version : 51.0.2704.63 (Official Build) 2989ec7055a268f05554172b2207a34c0c842b8d-refs/branch-heads/2704@{#656} 32/64 bit
OS :  Windows (7, 8, 10), Mac(10.10.5, 10.11.4), Linux(14.04 LTS)

Pre-condition : Please enable 'new gaia password-separated sign in flow' flag from chrome://flags.

What steps will reproduce the problem?
1. Launch chrome and from chrome://settings add a new Person. (Person 2)
2. In Person 2 window, click on Avatar icon and sign in to chrome using valid details. (Sync confirmation bubble is seen)
3. Right click on 'Settings' link and select 'Open link as Person 1'. (Person 1 window is seen)
4. Again right click on  'Settings' link and select 'Open link as Person 2'.
5. Close the current window and observe.

Actual : Chrome browser crashes after closing the 'Person 1' window.
Expected : Browser should not crash after closing the 'Person 1' window.

Crash ID's : 
9852269c00000000 (9d5a5092-7b44-4564-8eec-a5da76f8ef6e)
d3ec469c00000000 (beaa9719-c4d7-4f68-ba84-eec0ca502ac0)

This is a regression issue, broken in 'M-51', below is the Manual Bisect and Change log info:
Good Build : 51.0.2701.0
Bad Build : 51.0.2704.0

Change log info:
https://chromium.googlesource.com/chromium/src/+log/51.0.2701.0..51.0.2704.0?pretty=fuller&n=10000

Suspecting : r385749 ? from Change log

Note : Could not provide the Narrow Bisect as the 'Sign in' feature is not available in chromium builds hence provided the change log info.
Actual_crash.mp4
2.2 MB Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc9e2a6739335b0ad0ed16b8ffd08a68a96e6b2e

commit dc9e2a6739335b0ad0ed16b8ffd08a68a96e6b2e
Author: anthonyvd <anthonyvd@chromium.org>
Date: Mon Jun 27 18:41:01 2016

Disable the Context Menu in the tab-modal signin dialog.

This prevents weird behaviors such as opening links in different profiles and unusable "view source" and "print" buttons.

BUG= 622225 , 614680 , 602594 
TEST=
1. Open the User Menu and click "sign in to Chrome"
2. In the sign in flow and the sync confirmation dialog, right-clicking to display the context menu shouldn't work.

Review-Url: https://codereview.chromium.org/2093563003
Cr-Commit-Position: refs/heads/master@{#402235}

[modify] https://crrev.com/dc9e2a6739335b0ad0ed16b8ffd08a68a96e6b2e/chrome/browser/ui/signin_view_controller_delegate.cc
[modify] https://crrev.com/dc9e2a6739335b0ad0ed16b8ffd08a68a96e6b2e/chrome/browser/ui/signin_view_controller_delegate.h

Comment 2 by anthonyvd@chromium.org, Jun 27 2016

Status: Fixed (was: Assigned)

Comment 3 by nyerramilli@chromium.org, Jun 28 2016

Labels: TE-M53 TE-Verified-53.0.2752.0
Tested this issue on Win7, Mac OS X 10.11.5, Ubuntu 14.04 using Chrome Canary/Dev # 53.0.2782.0 and the context menu was disabled.

adding TE-verified labels and attached screencast for reference.
context menu.mov
9.2 MB Download
►

Sign in to add a comment