New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 614607 link

Starred by 2 users
Status: Fixed
Owner:
est...@chromium.org
Closed: Jun 2016
Cc:
nyerramilli@chromium.org
█ ashej...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Avatar icon is not seen in Guest mode.

Reported by yfulgaon...@etouch.net, May 25 2016 
Chrome version : 53.0.2747.0 (Official Build) 8b52d389acaeef909862630192d11d9fc562e7ec-refs/heads/master@{#395489} 32/64 bit
OS :  Windows (7, 8, 10)
  
What steps will reproduce the problem?
1. Launch chrome, click on Avatar icon and click on 'Switch Person'.
2. Now click on 'Browse as Guest' and observe the top RHS. 

Actual : Guest button is missing in Guest mode.
Expected : Guest button should be visible.

This is a regression issue, broken in 'M-53', and will soon update other info.

Comment 1 by yfulgaon...@etouch.net, May 25 2016

Labels: hasbisect
Owner: est...@chromium.org
Status: Assigned (was: Unconfirmed)
Summary: Regression : Avatar icon is not seen in Guest mode. (was: Regression : Guest button is missing in Guest mode.)
Manual Bisect Info:
Good Build : 53.0.2746.0 
Bad Build : 53.0.2747.0 

Narrow Bisect info:
https://chromium.googlesource.com/chromium/src/+log/e64343aedf66460cdda087639ca5a2a0307d81a1..7c8cb6ceee1f9e67a27b18f6fe58003c65c1d55a?pretty=fuller&n=10000

Suspecting : r395397 from Narrow Bisect

Note : Above issue is not seen on Mac(10.10.5, 10.11.4) and will soon update Linux info
Actu_exp_Guest.png
111 KB View Download

Comment 2 by yfulgaon...@etouch.net, May 25 2016

Labels: OS-Linux
Update:
Above issue is also seen on Linux (14.04 LTS) OS.

Comment 3 by ashej...@chromium.org, May 25 2016

Labels: ReleaseBlock-Beta
Marking the above issue as RB-Beta as this is a very recent regression.

Thank you!
Project Member

Comment 4 by bugdroid1@chromium.org, May 31 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0890a13446558add03f85ec0f50b2d14967b467c

commit 0890a13446558add03f85ec0f50b2d14967b467c
Author: estade <estade@chromium.org>
Date: Tue May 31 23:04:47 2016

Fix display of "new" avatar menu in guest mode.

I would add a test for this, but one already exists, it's just disabled:
BrowserCommandControllerBrowserTest.NewAvatarMenuEnabledInGuestMode

BUG= 471953 , 614607 

Review-Url: https://codereview.chromium.org/2023523002
Cr-Commit-Position: refs/heads/master@{#396964}

[modify] https://crrev.com/0890a13446558add03f85ec0f50b2d14967b467c/chrome/browser/ui/views/frame/avatar_button_manager.cc

Comment 5 by est...@chromium.org, Jun 1 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment