New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 614599 link

Starred by 2 users
Status: Fixed
Owner:
benwells@chromium.org
Closed: Jul 2016
Cc:
dominickn@chromium.org
█ kcaratt...@chromium.org
█ raymes@chromium.org
█ stefanocs@google.com
mlamouri@chromium.org
█ f...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Track metrics for gestures and permission bubbles

Project Member Reported by benwells@chromium.org, May 25 2016 
What we'd like to track is:
- how many permission bubbles are associated with gestures / how many are not
- the accept / deny rates of these
- what are the top sites that use gestures / don't use gestures

To do this we'll need to basically revert a series of changes which removed the gesture plumbing through permission manager.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/891d092c74b16480b11b79723d6b2b98bc748e64

commit 891d092c74b16480b11b79723d6b2b98bc748e64
Author: benwells <benwells@chromium.org>
Date: Tue Jun 14 16:25:47 2016

Add user_gesture bit back to Mojo PermissionService methods.

We want to track metrics of which permission requests are made with
gestures and their acceptance rates. This change starts putting the
plumbing to do so back in place.

This change is essentially a revert of
https://crrev.com/27b97a28935fa4cb2bbb9e087933629ba49d899b

BUG= 614599 

Review-Url: https://codereview.chromium.org/2009773002
Cr-Commit-Position: refs/heads/master@{#399722}

[modify] https://crrev.com/891d092c74b16480b11b79723d6b2b98bc748e64/content/browser/permissions/permission_service_impl.cc
[modify] https://crrev.com/891d092c74b16480b11b79723d6b2b98bc748e64/content/browser/permissions/permission_service_impl.h
[modify] https://crrev.com/891d092c74b16480b11b79723d6b2b98bc748e64/content/child/permissions/permission_dispatcher.cc
[modify] https://crrev.com/891d092c74b16480b11b79723d6b2b98bc748e64/content/renderer/media/media_permission_dispatcher.cc
[modify] https://crrev.com/891d092c74b16480b11b79723d6b2b98bc748e64/content/renderer/media/midi_dispatcher.cc
[modify] https://crrev.com/891d092c74b16480b11b79723d6b2b98bc748e64/content/renderer/notification_permission_dispatcher.cc
[modify] https://crrev.com/891d092c74b16480b11b79723d6b2b98bc748e64/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp
[modify] https://crrev.com/891d092c74b16480b11b79723d6b2b98bc748e64/third_party/WebKit/public/platform/modules/permissions/permission.mojom
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/891d092c74b16480b11b79723d6b2b98bc748e64

commit 891d092c74b16480b11b79723d6b2b98bc748e64
Author: benwells <benwells@chromium.org>
Date: Tue Jun 14 16:25:47 2016

Add user_gesture bit back to Mojo PermissionService methods.

We want to track metrics of which permission requests are made with
gestures and their acceptance rates. This change starts putting the
plumbing to do so back in place.

This change is essentially a revert of
https://crrev.com/27b97a28935fa4cb2bbb9e087933629ba49d899b

BUG= 614599 

Review-Url: https://codereview.chromium.org/2009773002
Cr-Commit-Position: refs/heads/master@{#399722}

[modify] https://crrev.com/891d092c74b16480b11b79723d6b2b98bc748e64/content/browser/permissions/permission_service_impl.cc
[modify] https://crrev.com/891d092c74b16480b11b79723d6b2b98bc748e64/content/browser/permissions/permission_service_impl.h
[modify] https://crrev.com/891d092c74b16480b11b79723d6b2b98bc748e64/content/child/permissions/permission_dispatcher.cc
[modify] https://crrev.com/891d092c74b16480b11b79723d6b2b98bc748e64/content/renderer/media/media_permission_dispatcher.cc
[modify] https://crrev.com/891d092c74b16480b11b79723d6b2b98bc748e64/content/renderer/media/midi_dispatcher.cc
[modify] https://crrev.com/891d092c74b16480b11b79723d6b2b98bc748e64/content/renderer/notification_permission_dispatcher.cc
[modify] https://crrev.com/891d092c74b16480b11b79723d6b2b98bc748e64/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp
[modify] https://crrev.com/891d092c74b16480b11b79723d6b2b98bc748e64/third_party/WebKit/public/platform/modules/permissions/permission.mojom
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd2b155896d33d4f4b8ec28c611836d35bbe541e

commit fd2b155896d33d4f4b8ec28c611836d35bbe541e
Author: benwells <benwells@chromium.org>
Date: Tue Jul 05 04:26:53 2016

Reintroduce plumbing for user gesture into permission system.

This will allow metrics to be gathered about the acceptance / denial
rates of permission prompts with gestures and without.

This effectively reverts:
1. https://crrev.com/acea72be67d92e56665f5357f4441f65c8073c15 and
2. https://crrev.com/a8e32b6fc3a4696ba24c8d6f257ec3fe848cf940

Those patches could not be reverted individually due to refactorings in
the permissions sytem.

TBR=torne@chromium.org
BUG= 614599 

Review-Url: https://codereview.chromium.org/2110343002
Cr-Commit-Position: refs/heads/master@{#403738}

[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/android_webview/browser/aw_permission_manager.cc
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/android_webview/browser/aw_permission_manager.h
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/blimp/engine/app/blimp_permission_manager.cc
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/blimp/engine/app/blimp_permission_manager.h
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/chrome/browser/background_sync/background_sync_permission_context.cc
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/chrome/browser/background_sync/background_sync_permission_context.h
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/chrome/browser/background_sync/background_sync_permission_context_unittest.cc
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/chrome/browser/geolocation/geolocation_permission_context.cc
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/chrome/browser/geolocation/geolocation_permission_context.h
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/chrome/browser/geolocation/geolocation_permission_context_android.cc
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/chrome/browser/geolocation/geolocation_permission_context_android.h
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/chrome/browser/geolocation/geolocation_permission_context_extensions.cc
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/chrome/browser/geolocation/geolocation_permission_context_extensions.h
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/chrome/browser/geolocation/geolocation_permission_context_unittest.cc
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.h
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/chrome/browser/media/media_stream_device_permission_context.cc
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/chrome/browser/media/media_stream_device_permission_context.h
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/chrome/browser/media/midi_permission_context_unittest.cc
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/chrome/browser/media/protected_media_identifier_permission_context.cc
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/chrome/browser/media/protected_media_identifier_permission_context.h
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/chrome/browser/notifications/notification_permission_context.cc
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/chrome/browser/notifications/notification_permission_context.h
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/chrome/browser/notifications/notification_permission_context_unittest.cc
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/chrome/browser/permissions/permission_context_base.cc
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/chrome/browser/permissions/permission_context_base.h
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/chrome/browser/permissions/permission_context_base_unittest.cc
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/chrome/browser/permissions/permission_manager.cc
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/chrome/browser/permissions/permission_manager.h
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/chrome/browser/push_messaging/push_messaging_permission_context.cc
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/chrome/browser/push_messaging/push_messaging_permission_context.h
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/chrome/browser/push_messaging/push_messaging_permission_context_unittest.cc
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/chrome/browser/push_messaging/push_messaging_service_impl.cc
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/chrome/browser/storage/durable_storage_permission_context.cc
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/chrome/browser/storage/durable_storage_permission_context.h
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/chromecast/browser/cast_permission_manager.cc
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/chromecast/browser/cast_permission_manager.h
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/content/browser/permissions/permission_service_impl.cc
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/content/browser/push_messaging/push_messaging_message_filter.cc
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/content/public/browser/permission_manager.h
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/content/shell/browser/layout_test/layout_test_permission_manager.cc
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/content/shell/browser/layout_test/layout_test_permission_manager.h
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/content/shell/browser/shell_permission_manager.cc
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/content/shell/browser/shell_permission_manager.h
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/content/test/mock_permission_manager.cc
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/content/test/mock_permission_manager.h
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/extensions/browser/guest_view/web_view/web_view_permission_helper.cc
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/extensions/browser/guest_view/web_view/web_view_permission_helper.h
[modify] https://crrev.com/fd2b155896d33d4f4b8ec28c611836d35bbe541e/extensions/browser/guest_view/web_view/web_view_permission_helper_delegate.h

Comment 4 by benwells@chromium.org, Jul 5 2016

Labels: ben-triage-needed

Comment 5 by benwells@chromium.org, Jul 6 2016

Labels: -M-53 -ben-triage-needed M-54

Comment 6 by kcaratt...@chromium.org, Jul 13 2016

Cc: stefanocs@google.com

Comment 7 by benwells@chromium.org, Jul 22 2016

Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/471d1f1120f2018e815b3d47989ab1cbadeb5a17

commit 471d1f1120f2018e815b3d47989ab1cbadeb5a17
Author: benwells <benwells@chromium.org>
Date: Mon Jul 25 23:58:04 2016

Record metrics for permission prompt acceptance vs. user gesture.

These metrics will allow us to compare acceptance rates for permission
prompts based on whether the prompt had a user gesture or not.

BUG= 614599 

Review-Url: https://codereview.chromium.org/2124703002
Cr-Commit-Position: refs/heads/master@{#407638}

[modify] https://crrev.com/471d1f1120f2018e815b3d47989ab1cbadeb5a17/chrome/browser/permissions/mock_permission_request.cc
[modify] https://crrev.com/471d1f1120f2018e815b3d47989ab1cbadeb5a17/chrome/browser/permissions/mock_permission_request.h
[modify] https://crrev.com/471d1f1120f2018e815b3d47989ab1cbadeb5a17/chrome/browser/permissions/permission_context_base.cc
[modify] https://crrev.com/471d1f1120f2018e815b3d47989ab1cbadeb5a17/chrome/browser/permissions/permission_request.cc
[modify] https://crrev.com/471d1f1120f2018e815b3d47989ab1cbadeb5a17/chrome/browser/permissions/permission_request.h
[modify] https://crrev.com/471d1f1120f2018e815b3d47989ab1cbadeb5a17/chrome/browser/permissions/permission_request_impl.cc
[modify] https://crrev.com/471d1f1120f2018e815b3d47989ab1cbadeb5a17/chrome/browser/permissions/permission_request_impl.h
[modify] https://crrev.com/471d1f1120f2018e815b3d47989ab1cbadeb5a17/chrome/browser/permissions/permission_request_manager_unittest.cc
[modify] https://crrev.com/471d1f1120f2018e815b3d47989ab1cbadeb5a17/chrome/browser/permissions/permission_uma_util.cc
[modify] https://crrev.com/471d1f1120f2018e815b3d47989ab1cbadeb5a17/chrome/browser/permissions/permission_uma_util.h
[add] https://crrev.com/471d1f1120f2018e815b3d47989ab1cbadeb5a17/chrome/browser/ui/website_settings/permission_bubble_request.cc
[modify] https://crrev.com/471d1f1120f2018e815b3d47989ab1cbadeb5a17/tools/metrics/histograms/histograms.xml

Comment 9 by benwells@chromium.org, Jul 26 2016

Status: Fixed (was: Started)
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83c36cc6179e0b4820586eeac082a71bc3ee094c

commit 83c36cc6179e0b4820586eeac082a71bc3ee094c
Author: dominickn <dominickn@chromium.org>
Date: Thu Nov 10 22:39:07 2016

Record permission prompt gesture metrics on Android.

The permissions infrastructure currently records gesture metrics for
desktop platforms through PermissionRequestManager. This does not record
metrics on Android, and will not do so until in-progress refactoring to
use PermissionRequestManager on that platform is complete.

This CL adds recording of gesture metrics on Android in the Android Java
UI-specific code paths of PermissionQueueController and
PermissionBubbleMediaAccessHandler. This is a temporary measure so that
these stats are recorded; once Android uses PermissionRequestManager to
display permission prompts, the PermissionQueueController call site will
be unnecessary and can be removed. The
PermissionBubbleMediaAccessHandler call site will be obsolete when the
media stream permission handling is consolidated with all other
permissions.

BUG= 614599 

Review-Url: https://codereview.chromium.org/2463393003
Cr-Commit-Position: refs/heads/master@{#431384}

[modify] https://crrev.com/83c36cc6179e0b4820586eeac082a71bc3ee094c/chrome/browser/media/webrtc/media_stream_infobar_delegate_android.cc
[modify] https://crrev.com/83c36cc6179e0b4820586eeac082a71bc3ee094c/chrome/browser/media/webrtc/media_stream_infobar_delegate_android.h
[modify] https://crrev.com/83c36cc6179e0b4820586eeac082a71bc3ee094c/chrome/browser/media/webrtc/permission_bubble_media_access_handler.cc
[modify] https://crrev.com/83c36cc6179e0b4820586eeac082a71bc3ee094c/chrome/browser/permissions/permission_dialog_delegate.cc
[modify] https://crrev.com/83c36cc6179e0b4820586eeac082a71bc3ee094c/chrome/browser/permissions/permission_dialog_delegate.h
[modify] https://crrev.com/83c36cc6179e0b4820586eeac082a71bc3ee094c/chrome/browser/permissions/permission_infobar_delegate.h
[modify] https://crrev.com/83c36cc6179e0b4820586eeac082a71bc3ee094c/chrome/browser/permissions/permission_queue_controller.cc
[modify] https://crrev.com/83c36cc6179e0b4820586eeac082a71bc3ee094c/chrome/browser/permissions/permission_request_impl.cc
[modify] https://crrev.com/83c36cc6179e0b4820586eeac082a71bc3ee094c/chrome/browser/permissions/permission_uma_util.cc
[modify] https://crrev.com/83c36cc6179e0b4820586eeac082a71bc3ee094c/chrome/browser/permissions/permission_uma_util.h
[modify] https://crrev.com/83c36cc6179e0b4820586eeac082a71bc3ee094c/chrome/browser/permissions/permission_util.cc
[modify] https://crrev.com/83c36cc6179e0b4820586eeac082a71bc3ee094c/chrome/browser/permissions/permission_util.h
►

Sign in to add a comment