New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 614595 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 425625
issue 609536



Sign in to add a comment

[Sync tabs] Show message in Synced Tabs page when user is signed out

Project Member Reported by bettes@chromium.org, May 25 2016

Issue description

Cc: tsergeant@chromium.org
Owner: calamity@chromium.org
Thanks!
Blocking: 425625
Blocking: 609536
Owner: lshang@chromium.org
Cc: bettes@chromium.org
 Issue 620028  has been merged into this issue.
Summary: [Sync tabs] Show message in Synced Tabs page when user is signed out (was: [Sync tabs] Empty state spec)
Project Member

Comment 7 by bugdroid1@chromium.org, Jun 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e52a260683db459e9adb524f124c3d8af9d937c

commit 8e52a260683db459e9adb524f124c3d8af9d937c
Author: lshang <lshang@chromium.org>
Date: Wed Jun 22 07:17:14 2016

MD History: add sign in promo in synced tabs when user isn't logged in

Show sign in promo when user is signed out. When user clicks to sign in,
show messages when it's loading synced tabs from backend or there is no
synced device found.

BUG= 614595 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2077473002
Cr-Commit-Position: refs/heads/master@{#401220}

[modify] https://crrev.com/8e52a260683db459e9adb524f124c3d8af9d937c/chrome/app/generated_resources.grd
[modify] https://crrev.com/8e52a260683db459e9adb524f124c3d8af9d937c/chrome/browser/browser_resources.grd
[modify] https://crrev.com/8e52a260683db459e9adb524f124c3d8af9d937c/chrome/browser/resources/md_history/app.js
[modify] https://crrev.com/8e52a260683db459e9adb524f124c3d8af9d937c/chrome/browser/resources/md_history/compiled_resources2.gyp
[modify] https://crrev.com/8e52a260683db459e9adb524f124c3d8af9d937c/chrome/browser/resources/md_history/history.js
[add] https://crrev.com/8e52a260683db459e9adb524f124c3d8af9d937c/chrome/browser/resources/md_history/images/100/sign_in_promo.png
[add] https://crrev.com/8e52a260683db459e9adb524f124c3d8af9d937c/chrome/browser/resources/md_history/images/200/sign_in_promo.png
[modify] https://crrev.com/8e52a260683db459e9adb524f124c3d8af9d937c/chrome/browser/resources/md_history/synced_device_manager.html
[modify] https://crrev.com/8e52a260683db459e9adb524f124c3d8af9d937c/chrome/browser/resources/md_history/synced_device_manager.js
[modify] https://crrev.com/8e52a260683db459e9adb524f124c3d8af9d937c/chrome/browser/ui/webui/md_history_ui.cc
[modify] https://crrev.com/8e52a260683db459e9adb524f124c3d8af9d937c/chrome/test/data/webui/md_history/history_synced_tabs_test.js

Status: Fixed (was: Assigned)

Sign in to add a comment