New issue
Advanced search Search tips

Issue 614583 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 614589



Sign in to add a comment

[People] In the "Manage other people" dialog, supervised users' names are displayed incorrectly

Project Member Reported by tbuck...@chromium.org, May 25 2016

Issue description

In the "Restrict sign-in" section, Supervised users are displayed as "0@locally-managed.localhost" instead of using the actual account name, eg. "John".
 
Labels: Hotlist-MD-DevBlocker
Blocking: 614589
Labels: -Hotlist-MD-DevBlocker

Comment 4 by dbeam@chromium.org, May 26 2016

Cc: dbeam@chromium.org
This will require a few days fix up, since the new Settings User list users the  usersPrivate API that does not return the name. (only the email).

Does this bug block anything? When does this need to be fixed by?
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/978d57269a979053a57da3c1fa799eb4ad541cf0

commit 978d57269a979053a57da3c1fa799eb4ad541cf0
Author: tommycli <tommycli@chromium.org>
Date: Mon Aug 22 23:08:52 2016

Settings People CrOS: Display supervised users' names correctly.

This fixes usernames displayed as: 0@locally-managed.localhost in
the ChromeOS User List section of Settings.

BUG= 614583 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2259943003
Cr-Commit-Position: refs/heads/master@{#413567}

[modify] https://crrev.com/978d57269a979053a57da3c1fa799eb4ad541cf0/chrome/browser/chromeos/extensions/users_private/users_private_api.cc
[modify] https://crrev.com/978d57269a979053a57da3c1fa799eb4ad541cf0/chrome/browser/resources/settings/people_page/user_list.html
[modify] https://crrev.com/978d57269a979053a57da3c1fa799eb4ad541cf0/chrome/browser/resources/settings/people_page/user_list.js
[modify] https://crrev.com/978d57269a979053a57da3c1fa799eb4ad541cf0/chrome/browser/resources/settings/people_page/users_page.js
[modify] https://crrev.com/978d57269a979053a57da3c1fa799eb4ad541cf0/chrome/common/extensions/api/users_private.idl
[modify] https://crrev.com/978d57269a979053a57da3c1fa799eb4ad541cf0/chrome/test/data/extensions/api_test/users_private/test.js
[modify] https://crrev.com/978d57269a979053a57da3c1fa799eb4ad541cf0/third_party/closure_compiler/externs/users_private.js

Status: Fixed (was: Assigned)

Comment 8 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55
Status: Verified (was: Fixed)
Verified on ChromeOS 8872.16.0, 55.0.2883.20

Sign in to add a comment