New issue
Advanced search Search tips

Issue 614559 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug-Regression



Sign in to add a comment

27.6%-93.4% regression in dromaeo.domcorequery at 395559:395579

Project Member Reported by m...@chromium.org, May 25 2016

Issue description

See the link to graphs below.
 
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, May 25 2016

Cc: peria@chromium.org
Owner: peria@chromium.org

=== Auto-CCing suspected CL author peria@chromium.org ===

Hi peria@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Add [OverrideBuiltins] label onto HTMLDocument interface.
Author  : peria
Commit description:
  
This CL also removes special handling of named properties
using V8 script controller, which is no longer needed.

Currently, we have no general routines to work for [Unforgeable]
on [OverrideBuiltins] interface, and "location" in "HTMLDocument"
is the only one which meets the situation.
So now, we handle it as an edge case of named property.

Spec: https://html.spec.whatwg.org/multipage/dom.html#dom-document-namedItem-which

Updated a test expectation; Chrome has been FAILing it, while IE, FF, and Safari PASS it.

BUG=611632

Review-Url: https://codereview.chromium.org/1837823003
Cr-Commit-Position: refs/heads/master@{#395570}
Commit  : 09649cf329fd0644f50624b80f6a2f9c564dcb2d
Date    : Tue May 24 11:41:39 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@395569  930.603  21.6438  5  good
chromium@395570  661.217  7.53549  5  bad    <--
chromium@395571  666.072  9.35149  5  bad
chromium@395572  663.057  11.8318  5  bad

Bisect job ran on: linux_perf_bisect
Bug ID: 614559

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests dromaeo.domcoremodify
Test Metric: dom/dom
Relative Change: 28.75%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/6502
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9011736352085332288


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5795950816133120

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 3 by bugdroid1@chromium.org, May 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17ab3580c8d3081a1c728eb33d6e5f35684fd5a5

commit 17ab3580c8d3081a1c728eb33d6e5f35684fd5a5
Author: peria <peria@chromium.org>
Date: Wed May 25 07:30:04 2016

Revert of [Binding] Add [OverrideBuiltins] label onto HTMLDocument interface (patchset #3 id:460001 of https://codereview.chromium.org/1837823003/ )

Reason for revert:
performance regression
BUG= 614559 

Original issue's description:
> Add [OverrideBuiltins] label onto HTMLDocument interface.
>
> This CL also removes special handling of named properties
> using V8 script controller, which is no longer needed.
>
> Currently, we have no general routines to work for [Unforgeable]
> on [OverrideBuiltins] interface, and "location" in "HTMLDocument"
> is the only one which meets the situation.
> So now, we handle it as an edge case of named property.
>
> Spec: https://html.spec.whatwg.org/multipage/dom.html#dom-document-namedItem-which
>
> Updated a test expectation; Chrome has been FAILing it, while IE, FF, and Safari PASS it.
>
> BUG=611632
>
> Committed: https://crrev.com/09649cf329fd0644f50624b80f6a2f9c564dcb2d
> Cr-Commit-Position: refs/heads/master@{#395570}

TBR=haraken@chromium.org,yukishiino@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=611632

Review-Url: https://codereview.chromium.org/2011553003
Cr-Commit-Position: refs/heads/master@{#395824}

[modify] https://crrev.com/17ab3580c8d3081a1c728eb33d6e5f35684fd5a5/third_party/WebKit/LayoutTests/imported/wpt/html/dom/documents/dom-tree-accessors/nameditem-06-expected.txt
[modify] https://crrev.com/17ab3580c8d3081a1c728eb33d6e5f35684fd5a5/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
[modify] https://crrev.com/17ab3580c8d3081a1c728eb33d6e5f35684fd5a5/third_party/WebKit/Source/bindings/core/v8/ScriptController.h
[modify] https://crrev.com/17ab3580c8d3081a1c728eb33d6e5f35684fd5a5/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp
[modify] https://crrev.com/17ab3580c8d3081a1c728eb33d6e5f35684fd5a5/third_party/WebKit/Source/bindings/core/v8/WindowProxy.h
[delete] https://crrev.com/723e64da51aa205b4f69660be9d3b59c67f37fe4/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLDocumentCustom.cpp
[modify] https://crrev.com/17ab3580c8d3081a1c728eb33d6e5f35684fd5a5/third_party/WebKit/Source/bindings/core/v8/custom/custom.gypi
[modify] https://crrev.com/17ab3580c8d3081a1c728eb33d6e5f35684fd5a5/third_party/WebKit/Source/core/html/HTMLDocument.cpp
[modify] https://crrev.com/17ab3580c8d3081a1c728eb33d6e5f35684fd5a5/third_party/WebKit/Source/core/html/HTMLDocument.idl

Comment 4 by peria@chromium.org, May 25 2016

Cc: haraken@chromium.org yukishiino@chromium.org
Labels: OS-All
Status: Started (was: Assigned)
I reverted the change, and expect these performance get good back soon.

Comment 5 by peria@chromium.org, May 26 2016

Status: Fixed (was: Started)
I also added a few Speedometer regressions which are recovered after the revert.

Sign in to add a comment