DCHECK in embedded_application_runner.cc on application_thread_checker_ |
|||
Issue descriptionVersion: M53 ToT OS: Android Steps To Repro: 1. Play an encrypted content. For example: - https://shaka-player-demo.appspot.com/demo/ - Choose "Tears of Steel (Widevine)", and click Load. 2. Close the tab (NOT the browser). 3. Open a new tab and repeat (1). I hit the DCHECK as follows: 05-24 16:16:33.957 5402 6523 F chromium: [FATAL:embedded_application_runner.cc(66)] Check failed: application_thread_checker_.CalledOnValidThread(). I haven't dig deeper. But it seems to me during new thread creation and shutdown, the |application_thread_checker_| isn't updated accordingly. Does it make sense to just use |application_task_runner_| to check whether we are on the right thread?
,
May 24 2016
Surely this is my fault. I can take a look tomorrow.
,
May 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ff6d1d6cc9d46baa42c0c10fb062ea9af4227f26 commit ff6d1d6cc9d46baa42c0c10fb062ea9af4227f26 Author: rockot <rockot@chromium.org> Date: Wed May 25 20:15:32 2016 Fix invalid DCHECK in EmbeddedApplicationRunner ThreadChecker checks that ShellClient messages are dispatched on the app thread, but we weren't detaching it when spinning up a new thread for the app. So start -> shutdown -> start would incorrectly hit a DCHECK. This fixes that. BUG= 614554 R=xhwang@chromium.org TBR=ben@chromium.org Review-Url: https://codereview.chromium.org/2007383002 Cr-Commit-Position: refs/heads/master@{#395974} [modify] https://crrev.com/ff6d1d6cc9d46baa42c0c10fb062ea9af4227f26/content/common/mojo/embedded_application_runner.cc
,
May 25 2016
,
May 25 2016
,
May 25 2016
FWIW, should the fix be merged to M52?
,
May 25 2016
I don't think so? We don't turn on DCHECKs in releases and the only bug here was an incorrect DCHECK. |
|||
►
Sign in to add a comment |
|||
Comment 1 by xhw...@chromium.org
, May 24 2016