New issue
Advanced search Search tips

Issue 614552 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

"ExtensionPreferenceApiTest.Standard" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, May 24 2016

Issue description

"ExtensionPreferenceApiTest.Standard" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLgsSBUZsYWtlIiNFeHRlbnNpb25QcmVmZXJlbmNlQXBpVGVzdC5TdGFuZGFyZAw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Project Member

Comment 1 by chromium...@appspot.gserviceaccount.com, May 26 2016

Detected 4 new flakes for test/step "ExtensionPreferenceApiTest.Standard". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLgsSBUZsYWtlIiNFeHRlbnNpb25QcmVmZXJlbmNlQXBpVGVzdC5TdGFuZGFyZAw. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).

Comment 2 by suzyh@chromium.org, May 30 2016

Cc: pkasting@chromium.org hcarmona@chromium.org
Labels: OS-Windows
Flaking on win_chromium_x64_rel_ng and occasionally win_chromium_rel_ng.

Logs are showing
[3776:5208:0524/133932:FATAL:autofill_private_event_router.cc(55)] Check failed: personal_data_ && personal_data_->IsDataLoaded().

Adding hcarmona and pkasting who recently touched autofill_private_event_router.cc. Can you help route this to the right place?
Cc: -pkasting@chromium.org
My changes were merely to remove unused variables, not functional changes, and I don't actually know anything about this code.

Comment 4 by guidou@chromium.org, May 31 2016

Cc: -hcarmona@chromium.org
Labels: -Sheriff-Chromium
Owner: hcarmona@chromium.org
Removing from Sheriff queue since this hasn't flaked for the last 4 days.
hcarmona: feel free to close if no further action is necessary.
Project Member

Comment 5 by chromium...@appspot.gserviceaccount.com, Jun 2 2016

Labels: Sheriff-Chromium
Detected 3 new flakes for test/step "ExtensionPreferenceApiTest.Standard". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLgsSBUZsYWtlIiNFeHRlbnNpb25QcmVmZXJlbmNlQXBpVGVzdC5TdGFuZGFyZAw. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Status: Started (was: Untriaged)
This looks related to my change.

Created CL:
https://codereview.chromium.org/2030803002
Labels: -Sheriff-Chromium
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/954b89348444571c3b369fc0e2fe98619b9c64c1

commit 954b89348444571c3b369fc0e2fe98619b9c64c1
Author: hcarmona <hcarmona@chromium.org>
Date: Thu Jun 09 20:26:04 2016

Fix newly introduced flake in ExtensionPreferenceApiTest.Standard

BUG= 614552 

Review-Url: https://codereview.chromium.org/2030803002
Cr-Commit-Position: refs/heads/master@{#398997}

[modify] https://crrev.com/954b89348444571c3b369fc0e2fe98619b9c64c1/chrome/browser/extensions/api/autofill_private/autofill_private_event_router.cc

Status: Fixed (was: Started)
No more flaking since CL landed. Marking as fixed.
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/954b89348444571c3b369fc0e2fe98619b9c64c1

commit 954b89348444571c3b369fc0e2fe98619b9c64c1
Author: hcarmona <hcarmona@chromium.org>
Date: Thu Jun 09 20:26:04 2016

Fix newly introduced flake in ExtensionPreferenceApiTest.Standard

BUG= 614552 

Review-Url: https://codereview.chromium.org/2030803002
Cr-Commit-Position: refs/heads/master@{#398997}

[modify] https://crrev.com/954b89348444571c3b369fc0e2fe98619b9c64c1/chrome/browser/extensions/api/autofill_private/autofill_private_event_router.cc

Sign in to add a comment