Currently, when the TaskManager is displayed, no row is initially selected. Instead, we should select the row corresponding to the most recently active tab.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb57d2cac517c51049f7cc38f24b89164a34e13f commit bb57d2cac517c51049f7cc38f24b89164a34e13f Author: nick <nick@chromium.org> Date: Mon Jul 25 23:08:04 2016 chrome::ShowTaskManager: refine return type to eliminate a downcast. BUG= 614551 Review-Url: https://codereview.chromium.org/2148243004 Cr-Commit-Position: refs/heads/master@{#407626} [modify] https://crrev.com/bb57d2cac517c51049f7cc38f24b89164a34e13f/chrome/browser/task_management/task_manager_tester.cc [modify] https://crrev.com/bb57d2cac517c51049f7cc38f24b89164a34e13f/chrome/browser/ui/browser_dialogs.h [modify] https://crrev.com/bb57d2cac517c51049f7cc38f24b89164a34e13f/chrome/browser/ui/cocoa/task_manager_mac.mm [modify] https://crrev.com/bb57d2cac517c51049f7cc38f24b89164a34e13f/chrome/browser/ui/views/browser_dialogs_views.cc [modify] https://crrev.com/bb57d2cac517c51049f7cc38f24b89164a34e13f/chrome/browser/ui/views/browser_dialogs_views_mac.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1824ae3ede49ac7e6cf6224d03e713fab8070c30 commit 1824ae3ede49ac7e6cf6224d03e713fab8070c30 Author: nick <nick@chromium.org> Date: Mon Aug 01 23:32:13 2016 TaskManager: when shown or activated, select the last active tab. Introduce a method, NewTaskManagerView::SelectTaskOfActiveTab, which allows the selection model to be updated to match the main row of a particular WebContents. Add plumbing from the NewTaskManagerView down to the TaskProviders to support this lookup. Rename NewTaskManagerView::ActivateFocusedTab for consistency and accuracy (it's basically the inverse of the new function). Replace the ScopedVector of TaskProviders with a std::vector of unique_ptrs, since ScopedVector is deprecated. BUG= 614551 TEST=included browser_test Review-Url: https://codereview.chromium.org/2146273002 Cr-Commit-Position: refs/heads/master@{#409087} [modify] https://crrev.com/1824ae3ede49ac7e6cf6224d03e713fab8070c30/chrome/browser/task_management/sampling/task_manager_impl.cc [modify] https://crrev.com/1824ae3ede49ac7e6cf6224d03e713fab8070c30/chrome/browser/task_management/sampling/task_manager_impl.h [modify] https://crrev.com/1824ae3ede49ac7e6cf6224d03e713fab8070c30/chrome/browser/task_management/task_manager_interface.h [modify] https://crrev.com/1824ae3ede49ac7e6cf6224d03e713fab8070c30/chrome/browser/task_management/test_task_manager.cc [modify] https://crrev.com/1824ae3ede49ac7e6cf6224d03e713fab8070c30/chrome/browser/task_management/test_task_manager.h [modify] https://crrev.com/1824ae3ede49ac7e6cf6224d03e713fab8070c30/chrome/browser/ui/task_manager/task_manager_table_model.cc [modify] https://crrev.com/1824ae3ede49ac7e6cf6224d03e713fab8070c30/chrome/browser/ui/task_manager/task_manager_table_model.h [modify] https://crrev.com/1824ae3ede49ac7e6cf6224d03e713fab8070c30/chrome/browser/ui/views/new_task_manager_view.cc [modify] https://crrev.com/1824ae3ede49ac7e6cf6224d03e713fab8070c30/chrome/browser/ui/views/new_task_manager_view.h [modify] https://crrev.com/1824ae3ede49ac7e6cf6224d03e713fab8070c30/chrome/browser/ui/views/new_task_manager_view_browsertest.cc
Comment 1 by bugdroid1@chromium.org
, Jul 25 2016