New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 614547 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
not on Chrome anymore
Closed: Jul 2016
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

KillTimer in MessagePumpForUI is called far more often than SetTimer

Project Member Reported by stanisc@chromium.org, May 24 2016

Issue description

According to my instrumentation of MessagePumpForUI there is a flaw in SetTimer / KillTimer logic that results in KillTimer being called up to 5 times more often than SetTimer.

Basically KillTimer would be called every time when any work was done - either regular or delayed - and there is no more delayed work. A better implementation would be to keep track of SetTimer calls and only call KillTimer if there is an active one.  

Considering about 2-8% of GPU process hangs (depending on build number) are deadlocks with KillTimer call on the top it would be good to fix this.
 
Status: Assigned (was: Untriaged)
This bug is fixed in MessagePumpForGpu version of message pump, but not fixed in MessagePumpForUI version.

The fix idea: add a flag that is set to true when timer is created and KillTimer only when the flag is true.
Status: Fixed (was: Assigned)
Fixed on the GPU side, can't repro in the browser side

Sign in to add a comment