Issue metadata
Sign in to add a comment
|
Bookmarks have (i) icons next to them instead of a document icon |
||||||||||||||||||||
Issue descriptionVersion: After 53.0.2747.0 OS: 10.11 The document icon that normally appears next to bookmarks in the bookmarks bar has been replaced with an "i" in a circle.
,
May 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a0776f8a55b798c81fc142ea531c9d8a762c2c85 commit a0776f8a55b798c81fc142ea531c9d8a762c2c85 Author: shrike <shrike@chromium.org> Date: Wed May 25 22:47:40 2016 [Mac][Material Design] Restore bookmark icons to default favicon. The Material Design bookmark buttons incorrectly used the location_bar_http vector icon to display a document icon for the default favicon. This cl adds default favicon vector icons based on the original version of the location_bar_http vector, and changes the bookmark buttons to use them. R=avi@chromium.org, estade@chromium.org BUG= 614539 Review-Url: https://codereview.chromium.org/2009643003 Cr-Commit-Position: refs/heads/master@{#396020} [modify] https://crrev.com/a0776f8a55b798c81fc142ea531c9d8a762c2c85/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
,
May 31 2016
,
May 31 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
May 31 2016
Please have a the CL merged by EOD today(05/31), so it gets picked up for Beta Promotion scheduled on 06/02.
,
May 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bbf3ad954eca58690a93ac82b3c63af1853e2304 commit bbf3ad954eca58690a93ac82b3c63af1853e2304 Author: Jayson Adams <shrike@chromium.org> Date: Tue May 31 20:47:53 2016 [Mac][Material Design] Restore bookmark icons to default favicon. The Material Design bookmark buttons incorrectly used the location_bar_http vector icon to display a document icon for the default favicon. This cl adds default favicon vector icons based on the original version of the location_bar_http vector, and changes the bookmark buttons to use them. R=avi@chromium.org, estade@chromium.org BUG= 614539 Review-Url: https://codereview.chromium.org/2009643003 Cr-Commit-Position: refs/heads/master@{#396020} (cherry picked from commit a0776f8a55b798c81fc142ea531c9d8a762c2c85) Review URL: https://codereview.chromium.org/2028593003 . Cr-Commit-Position: refs/branch-heads/2743@{#146} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/bbf3ad954eca58690a93ac82b3c63af1853e2304/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm
,
Jun 1 2016
@shrike: Hey, would you mind providing sample screen-shot for the above change? I really appreciate your help. Thank you!
,
Jun 1 2016
Here's what it looks like with the fix.
,
Jun 1 2016
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by shrike@chromium.org
, May 25 2016