TaskManager: Double-clicking on an extension background page should do something |
||
Issue description1. Launch the task manager 2. Install an extension with a background page. 3. Double-click on the row for the background page. WHAT HAPPENS: Nothing; there's no window to focus, and ExtensionHost doesn't override WebContentsDelegate::ActivateContents() WHAT SHOULD HAPPEN: Show the chrome-extensions page, highlighting the extension involved.
,
May 24 2016
Alternately the highlight could move to the line in task manager for the extension itself. It could also be useful to have a column that says, for each site-isolation process, what 'parent' process(es) it is associated with - this could become important when there are multiple extra processes created, since double-clicking can be unwieldy.
,
May 25 2016
,
May 25 2016
Re #2: I have another pending CL locally that groups the subframe processes to (in the common case) be the next row after the parents, and in general imposes logical ordering to the rows when sorting by the 'Tasks' column. It feels much less random, I will cc you when I upload it.
,
May 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e578802016df8e28e20aab78561446f2697fab68 commit e578802016df8e28e20aab78561446f2697fab68 Author: nick <nick@chromium.org> Date: Wed May 25 21:29:42 2016 Task Manager: Make double-clicking on an extension do something useful. Extension background pages, etc, don't implement anything for WebContentsDelegate::ActivateContents; as a result, double-clicking on them does nothing. This change makes it so that we open the chrome-extensions:// page instead, highlighting the details for the particular extension. Make double-clicking on a subframe row have the same behavior as double-clicking on the main row for the tab. BUG= 614529 Review-Url: https://codereview.chromium.org/2006423002 Cr-Commit-Position: refs/heads/master@{#395990} [modify] https://crrev.com/e578802016df8e28e20aab78561446f2697fab68/chrome/browser/task_management/providers/web_contents/extension_task.cc [modify] https://crrev.com/e578802016df8e28e20aab78561446f2697fab68/chrome/browser/task_management/providers/web_contents/extension_task.h [modify] https://crrev.com/e578802016df8e28e20aab78561446f2697fab68/chrome/browser/task_management/providers/web_contents/subframe_task.cc [modify] https://crrev.com/e578802016df8e28e20aab78561446f2697fab68/chrome/browser/task_management/providers/web_contents/subframe_task.h [modify] https://crrev.com/e578802016df8e28e20aab78561446f2697fab68/chrome/browser/task_management/providers/web_contents/web_contents_task_provider.cc
,
May 25 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by nick@chromium.org
, May 24 2016