New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 614505 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

[Offline Pages] Audit prevalence of cache-control headers.

Project Member Reported by dewittj@chromium.org, May 24 2016

Issue description

We need to better understand the effect of blocking resources with cache-control headers from serialization for the offline page cache feature.
 
Cc: dim...@chromium.org
I created an extension that will just block all requests with no-store in the response headers. [see attached]
nostore-blocker.tar.gz
713 bytes Download
Project Member

Comment 2 by bugdroid1@chromium.org, May 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0710ba43dca3d29b5658e8aa221ac7adc6e3cfb5

commit 0710ba43dca3d29b5658e8aa221ac7adc6e3cfb5
Author: dimich <dimich@google.com>
Date: Wed May 25 07:18:10 2016

Adding a command-line flag to set MHTML generation options.

It is a content-level flag (since MHTML generation is a content feature) and initial
set of options is to follow standard cache-control: no-save option to avoid
saving MHTML files with potentially private/transient information.

BUG= 614505 

Review-Url: https://codereview.chromium.org/2013633003
Cr-Commit-Position: refs/heads/master@{#395820}

[modify] https://crrev.com/0710ba43dca3d29b5658e8aa221ac7adc6e3cfb5/chrome/app/generated_resources.grd
[modify] https://crrev.com/0710ba43dca3d29b5658e8aa221ac7adc6e3cfb5/chrome/browser/about_flags.cc
[modify] https://crrev.com/0710ba43dca3d29b5658e8aa221ac7adc6e3cfb5/content/public/common/content_switches.cc
[modify] https://crrev.com/0710ba43dca3d29b5658e8aa221ac7adc6e3cfb5/content/public/common/content_switches.h
[modify] https://crrev.com/0710ba43dca3d29b5658e8aa221ac7adc6e3cfb5/content/public/common/mhtml_generation_params.cc
[modify] https://crrev.com/0710ba43dca3d29b5658e8aa221ac7adc6e3cfb5/tools/metrics/histograms/histograms.xml

To install the extension from #1,

unzip into a folder
chrome://extensions -> check "developer mode" -> click "load unpacked extension"
Choose the folder with the extension.

Uncheck "Enabled" in the chrome://extensions entry if you need to see a page with no-store.
Status: Fixed (was: Untriaged)
THe results are in, marked as fixed.

Sign in to add a comment