New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 614504 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 429053



Sign in to add a comment

Enable the deqp/functional/gles3/integerstatequery.html WebGL2 CTS test.

Project Member Reported by cwallez@chromium.org, May 24 2016

Issue description

This is a tracking bug for the work needed to enable the integer state query deqp GLES3 test in the WebGL CTS.

See also https://github.com/KhronosGroup/WebGL/pull/1688
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc1c9eb2fa2588cbe5003251683f09f0c50226f4

commit dc1c9eb2fa2588cbe5003251683f09f0c50226f4
Author: cwallez <cwallez@google.com>
Date: Thu May 26 03:11:56 2016

command_buffer: Guard on extension and profiles in the decoder

Previously the command buffer generator would only extension and
profile guards for the context state implementation. This caused
HandleHint to incorrectly call glHint with GL_GENERATE_MIPMAP_HINT on
a core profile, resulting in an OpenGL error.

BUG= 614504 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2009073002
Cr-Commit-Position: refs/heads/master@{#396093}

[modify] https://crrev.com/dc1c9eb2fa2588cbe5003251683f09f0c50226f4/gpu/command_buffer/build_gles2_cmd_buffer.py
[modify] https://crrev.com/dc1c9eb2fa2588cbe5003251683f09f0c50226f4/gpu/command_buffer/service/context_state_impl_autogen.h
[modify] https://crrev.com/dc1c9eb2fa2588cbe5003251683f09f0c50226f4/gpu/command_buffer/service/gles2_cmd_decoder_autogen.h
[modify] https://crrev.com/dc1c9eb2fa2588cbe5003251683f09f0c50226f4/gpu/command_buffer/service/gles2_cmd_decoder_unittest_0_autogen.h
[modify] https://crrev.com/dc1c9eb2fa2588cbe5003251683f09f0c50226f4/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc
[modify] https://crrev.com/dc1c9eb2fa2588cbe5003251683f09f0c50226f4/gpu/command_buffer/service/gles2_cmd_decoder_unittest_context_state.cc
[modify] https://crrev.com/dc1c9eb2fa2588cbe5003251683f09f0c50226f4/gpu/command_buffer/service/test_helper.cc

Project Member

Comment 2 by bugdroid1@chromium.org, May 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c026ebf7a44d263bdbc6df3e5ba9b480ff6c6ac9

commit c026ebf7a44d263bdbc6df3e5ba9b480ff6c6ac9
Author: cwallez <cwallez@chromium.org>
Date: Tue May 31 20:34:18 2016

command_buffer: expose SRC_ALPHA_SATURATE when on GLES 3

BUG= 614504 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2025673003
Cr-Commit-Position: refs/heads/master@{#396918}

[modify] https://crrev.com/c026ebf7a44d263bdbc6df3e5ba9b480ff6c6ac9/gpu/command_buffer/build_gles2_cmd_buffer.py
[modify] https://crrev.com/c026ebf7a44d263bdbc6df3e5ba9b480ff6c6ac9/gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h
[modify] https://crrev.com/c026ebf7a44d263bdbc6df3e5ba9b480ff6c6ac9/gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f146e750697e48b4cc8305dd6a692cced1c27ffe

commit f146e750697e48b4cc8305dd6a692cced1c27ffe
Author: cwallez <cwallez@google.com>
Date: Wed Jun 01 00:10:14 2016

WebGL2 expectations: reenable dEQP ES3 integer state query

See https://github.com/KhronosGroup/WebGL/pull/1688

BUG= 614504 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2000813002
Cr-Commit-Position: refs/heads/master@{#396987}

[modify] https://crrev.com/f146e750697e48b4cc8305dd6a692cced1c27ffe/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Status: Fixed (was: Started)
The suppression was removed and the waterfall is happy.

Comment 5 by kbr@chromium.org, Jun 1 2016

Great!

Sign in to add a comment