--type=gpu-process is hidden near the end of the GPU command line |
|||||
Issue descriptionWhen looking at a list of chrome command lines it is easy to identify the types because --type= comes right after the process name. Except for gpu-process. As of crrev.com/1928863002 the type=gpu-process tag comes near the end of the command line. Task Manager only shows 260 characters of the command line, and ETW traces only capture 512 characters so the process type is lost to these programs. This causes problems for ETW trace analysis - for a few weeks now the gpu-process has been identified as a stray browser process due to this. Process explorer can show the entire command line but that points out another problem with this situation - the command line actually ends with: --ignored=" --type=renderer " /prefetch:2 The gpu-process tag is hidden ~3,600 characters from the start of the command line and ~400 characters from the end. Confusing! This isn't a correctness issue, but it is a confusion/convenience issue. Fixing this (by putting --type=gpu-process in its normal place) will also make process identification in ETW traces simpler. I have a trivial fix ready.
,
May 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3089deef0bd591b699841f9b6b7cc9cd6ec88117 commit 3089deef0bd591b699841f9b6b7cc9cd6ec88117 Author: brucedawson <brucedawson@chromium.org> Date: Tue May 24 23:57:46 2016 Avoid hiding --type=gpu-process Move FeaturesAndFieldTrialFlags to the end of the gpu-process command line to avoid breaking the pattern and to make process-type identification easier (and more reliable from ETW traces). BUG= 614502 Review-Url: https://codereview.chromium.org/2013573002 Cr-Commit-Position: refs/heads/master@{#395742} [modify] https://crrev.com/3089deef0bd591b699841f9b6b7cc9cd6ec88117/content/browser/gpu/gpu_process_host.cc
,
May 25 2016
UIforETW now handles this, although I don't know when I'll release a new version, or how often people update. https://github.com/google/UIforETW/commit/de143e98
,
May 27 2016
,
May 27 2016
The fix is working on canary and makes identifying the gpu process much easier. It's not crucial for M52 but would avoid causing minor confusion for six weeks.
,
May 27 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
May 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55e38401985e7961148b4a82cc3c7eafa41fad9a commit 55e38401985e7961148b4a82cc3c7eafa41fad9a Author: Bruce Dawson <brucedawson@chromium.org> Date: Mon May 30 22:19:28 2016 Avoid hiding --type=gpu-process Move FeaturesAndFieldTrialFlags to the end of the gpu-process command line to avoid breaking the pattern and to make process-type identification easier (and more reliable from ETW traces). BUG= 614502 Review-Url: https://codereview.chromium.org/2013573002 Cr-Commit-Position: refs/heads/master@{#395742} (cherry picked from commit 3089deef0bd591b699841f9b6b7cc9cd6ec88117) Review URL: https://codereview.chromium.org/2024703003 . Cr-Commit-Position: refs/branch-heads/2743@{#128} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/55e38401985e7961148b4a82cc3c7eafa41fad9a/content/browser/gpu/gpu_process_host.cc |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by brucedaw...@chromium.org
, May 24 201624.8 KB
24.8 KB View Download