AVDA doesn't free shm handles all the time, causing leaked fds. |
|||||
Issue descriptionAVDA::Reset clears bitstream buffers, but doesn't close any shm file descriptor that it has. same for ::ActualDestroy and ~AVDA. seeking, at least, leaks in ::Reset.
,
May 25 2016
requesting merge to m-52.
,
May 25 2016
Your change meets the bar and is auto-approved for M52 (branch: 2743)
,
May 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb8aa934298c0b9d72da0f5c519b1b4f1cd4e66a commit cb8aa934298c0b9d72da0f5c519b1b4f1cd4e66a Author: liberato <liberato@chromium.org> Date: Wed May 25 21:54:27 2016 [M-52] Close bitstream buffer shared memory handles on Android. AndroidVideoDecodeAccelerator would clear references to pending bitstream buffers in ::Reset and, implicitly, in the destructor. However, each of those may have a file descriptor for shared memory that isn't closed. During a seek, for example, this can cause leaks. This CL wraps the queue of pending bitstream buffers with a new BitstreamRecord type, which has a unique_ptr to the (unmapped) shared memory region, if any. This will automatically close the underlying handle when the unique_ptr is released. Note that no expensive operation is performed in creating the shared memory region. Unless it is later mapped, it just keeps the handle and ::close()s it on destruction. This is a merge of https://codereview.chromium.org/2011653002 . BUG= 614489 TEST=observed /proc/fd/[gpu process] while seeking in a video NOPRESUBMIT=true NOTRY=true TBR=dalecurtis@chromium.org Review-Url: https://codereview.chromium.org/2008373003 Cr-Commit-Position: refs/branch-heads/2743@{#60} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/cb8aa934298c0b9d72da0f5c519b1b4f1cd4e66a/media/gpu/android_video_decode_accelerator.cc [modify] https://crrev.com/cb8aa934298c0b9d72da0f5c519b1b4f1cd4e66a/media/gpu/android_video_decode_accelerator.h
,
May 25 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, May 25 2016