Checkbox rows not using new 44px single-line row height |
||||
Issue descriptionThe checkbox rows are not respecting the new 44px single-line row height. They're still at 40px.
,
May 25 2016
,
May 25 2016
Alan, I noticed that the side nav menu items are also 40px. Would you like those changed to 44px?
,
May 25 2016
The tabs in the certificate manager are another 40px high thing that you may want 44px? WDYT
,
May 25 2016
Here's what it looks like with 44px menu spacing.
,
May 25 2016
(I rather like the 40px spacing on the side nav menu items).
,
May 25 2016
,
May 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3204336053295d134ab7844403393b23cae1f057 commit 3204336053295d134ab7844403393b23cae1f057 Author: dschuyler <dschuyler@chromium.org> Date: Thu May 26 21:26:59 2016 [MD settings] move root css vars; increase checkbox and h2 row-height This CL moves the :root css vars from settings_shared_css.html into a separate file that is imported in settings.html. This more clearly reflects the scope of :root vars. A height var is then used for the checkbox, radio button and h2 style. BUG= 614476 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2009783003 Cr-Commit-Position: refs/heads/master@{#396285} [modify] https://crrev.com/3204336053295d134ab7844403393b23cae1f057/chrome/browser/resources/settings/controls/settings_checkbox.html [modify] https://crrev.com/3204336053295d134ab7844403393b23cae1f057/chrome/browser/resources/settings/settings.html [modify] https://crrev.com/3204336053295d134ab7844403393b23cae1f057/chrome/browser/resources/settings/settings_dialog.html [modify] https://crrev.com/3204336053295d134ab7844403393b23cae1f057/chrome/browser/resources/settings/settings_resources.grd [add] https://crrev.com/3204336053295d134ab7844403393b23cae1f057/chrome/browser/resources/settings/settings_root_css.html [modify] https://crrev.com/3204336053295d134ab7844403393b23cae1f057/chrome/browser/resources/settings/settings_shared_css.html
,
Jun 13 2016
Side nav and tabbing heights should stay the same. Screenshot in #5 LGTM. |
||||
►
Sign in to add a comment |
||||
Comment 1 by bettes@chromium.org
, May 24 201661.1 KB
61.1 KB View Download