New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 614476 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Checkbox rows not using new 44px single-line row height

Project Member Reported by bettes@chromium.org, May 24 2016

Issue description

The checkbox rows are not respecting the new 44px single-line row height. They're still at 40px. 

 

Comment 1 by bettes@chromium.org, May 24 2016

Untitled-1.png
61.1 KB View Download
Labels: Hotlist-MD-Settings-General
Alan, I noticed that the side nav menu items are 
also 40px. Would you like those changed to 44px?


The tabs in the certificate manager are another 40px high
thing that you may want 44px? WDYT
Here's what it looks like with 44px menu spacing.
Screenshot from 2016-05-24 18:35:50.png
63.3 KB View Download
(I rather like the 40px spacing on the side nav menu items).
Cc: dschuyler@chromium.org
Labels: Needs-Feedback
Owner: bettes@chromium.org
Project Member

Comment 8 by bugdroid1@chromium.org, May 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3204336053295d134ab7844403393b23cae1f057

commit 3204336053295d134ab7844403393b23cae1f057
Author: dschuyler <dschuyler@chromium.org>
Date: Thu May 26 21:26:59 2016

[MD settings] move root css vars; increase checkbox and h2 row-height

This CL moves the :root css vars from settings_shared_css.html into a
separate file that is imported in settings.html. This more clearly
reflects the scope of :root vars. A height var is then used for the
checkbox, radio button and h2 style.

BUG= 614476 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2009783003
Cr-Commit-Position: refs/heads/master@{#396285}

[modify] https://crrev.com/3204336053295d134ab7844403393b23cae1f057/chrome/browser/resources/settings/controls/settings_checkbox.html
[modify] https://crrev.com/3204336053295d134ab7844403393b23cae1f057/chrome/browser/resources/settings/settings.html
[modify] https://crrev.com/3204336053295d134ab7844403393b23cae1f057/chrome/browser/resources/settings/settings_dialog.html
[modify] https://crrev.com/3204336053295d134ab7844403393b23cae1f057/chrome/browser/resources/settings/settings_resources.grd
[add] https://crrev.com/3204336053295d134ab7844403393b23cae1f057/chrome/browser/resources/settings/settings_root_css.html
[modify] https://crrev.com/3204336053295d134ab7844403393b23cae1f057/chrome/browser/resources/settings/settings_shared_css.html

Comment 9 by bettes@chromium.org, Jun 13 2016

Status: Fixed (was: Assigned)
Side nav and tabbing heights should stay the same. Screenshot in #5 LGTM.

Sign in to add a comment