New issue
Advanced search Search tips

Issue 614467 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 658904



Sign in to add a comment

Disable navigation on link double-clicks

Project Member Reported by csharrison@chromium.org, May 24 2016

Issue description

If you double click a (slightly) slow loading link, it can issue two navigation requests, where the latter one aborts the former one.

This is a bad user experience, and can delay user-perceived page load times by x, where x is the double click speed.

Additionally, this causes needless aborts coming into the network stack, spoiling metrics like Net.ErrorCodesForMainFrame3. It looks like roughly 10% of the <100ms aborts coming into ResourceDispatcher come from fast clicks.

Could the UI be improved here?
 
Components: -Blink>HTML>Link Blink>HTML>A
Cc: tkent@chromium.org dtapu...@chromium.org
tkent@ does it make sense to check the detail() == 1 (this field on MouseEvent  represents the number of clicks)

Specifically in this line of code:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/core/html/HTMLAnchorElement.cpp&sq=package:chromium&type=cs&l=376&q=isLinkCLick

This would avoid the double invocation.

Comment 3 by tkent@chromium.org, May 24 2016

It sounds a good idea.

Owner: dtapu...@chromium.org
Status: Started (was: Untriaged)
Labels: Hotlist-Input-Dev
Status: Fixed (was: Started)
Thanks for the prompt fix!!
If you can post what metrics you were querying specifically; like how did you determine 100ms timeout were caused by this.
The metrics were not gathered in UMA. ResourceDispatcher::Cancel was instrumented to dump without crashing whenever it asks the ResourceDispatcherHost to cancel a requet that had only lived < 100ms.

The logs were aggregated to find most used code paths in the wild. A lot came from click handlers on anchor elements, which I guessed to be either from these double clicks, or "enter clicks" where you hold enter and click a link. See  crbug.com/607361 .
Blocking: 658904
Labels: M-53

Sign in to add a comment