New issue
Advanced search Search tips

Issue 614454 link

Starred by 1 user
Status: Fixed
Owner:
iclell...@chromium.org
Closed: Aug 2016
Cc:
feature-...@grotations.appspotmail.com
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature

Blocking:
issue 589830



Sign in to add a comment

Implement remote revocation of origin trials experiments

Project Member Reported by iclell...@chromium.org, May 24 2016 
Remotely disabling experiments is a key feature of the origin trial framework. We should have a mechanism to push a list of features which should be disabled to clients.

When disabled, the feature should not be completely unavailable; rather it should simply not be turned on through the origin trials framework. Web developers (and adventurous users) should still be able to enable the feature through about:flags or via the command line.

Comment 1 by iclell...@chromium.org, May 24 2016

Blocking: 589830
Project Member

Comment 2 by sheriffbot@chromium.org, Jun 1 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 23 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79237e966353560115a92eb802aa7da459cdaf9f

commit 79237e966353560115a92eb802aa7da459cdaf9f
Author: iclelland <iclelland@chromium.org>
Date: Thu Jun 23 12:03:51 2016

Add disabled origin trial feature list

Adds both a command line option, "--origin-trial-disabled-features", and a
corresponding component manifest key, to exclude features from origin trials.
Disabling features in this manner will not stop them from being enabled via the
command line, or chrome://flags, but will stop them from being enabled by
remote origins through origin trials.

The manifest data from the component will be persisted in browser local state,
as a list of strings under the key "origin_trials.disabled_features".

BUG= 589830 , 614454 

Review-Url: https://codereview.chromium.org/1741783002
Cr-Commit-Position: refs/heads/master@{#401583}

[modify] https://crrev.com/79237e966353560115a92eb802aa7da459cdaf9f/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/79237e966353560115a92eb802aa7da459cdaf9f/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/79237e966353560115a92eb802aa7da459cdaf9f/chrome/browser/component_updater/origin_trials_component_installer.cc
[modify] https://crrev.com/79237e966353560115a92eb802aa7da459cdaf9f/chrome/browser/prefs/origin_trial_prefs.cc
[modify] https://crrev.com/79237e966353560115a92eb802aa7da459cdaf9f/chrome/common/chrome_switches.cc
[modify] https://crrev.com/79237e966353560115a92eb802aa7da459cdaf9f/chrome/common/chrome_switches.h
[modify] https://crrev.com/79237e966353560115a92eb802aa7da459cdaf9f/chrome/common/origin_trials/chrome_origin_trial_policy.cc
[modify] https://crrev.com/79237e966353560115a92eb802aa7da459cdaf9f/chrome/common/origin_trials/chrome_origin_trial_policy.h
[modify] https://crrev.com/79237e966353560115a92eb802aa7da459cdaf9f/chrome/common/origin_trials/chrome_origin_trial_policy_unittest.cc
[modify] https://crrev.com/79237e966353560115a92eb802aa7da459cdaf9f/chrome/common/pref_names.cc
[modify] https://crrev.com/79237e966353560115a92eb802aa7da459cdaf9f/chrome/common/pref_names.h
[modify] https://crrev.com/79237e966353560115a92eb802aa7da459cdaf9f/content/common/origin_trials/trial_token_validator.cc
[modify] https://crrev.com/79237e966353560115a92eb802aa7da459cdaf9f/content/common/origin_trials/trial_token_validator_unittest.cc
[modify] https://crrev.com/79237e966353560115a92eb802aa7da459cdaf9f/content/public/common/origin_trial_policy.h
[modify] https://crrev.com/79237e966353560115a92eb802aa7da459cdaf9f/content/shell/common/shell_origin_trial_policy.cc
[modify] https://crrev.com/79237e966353560115a92eb802aa7da459cdaf9f/content/shell/common/shell_origin_trial_policy.h
[modify] https://crrev.com/79237e966353560115a92eb802aa7da459cdaf9f/third_party/WebKit/Source/core/origin_trials/OriginTrialContext.cpp
[modify] https://crrev.com/79237e966353560115a92eb802aa7da459cdaf9f/third_party/WebKit/public/platform/WebOriginTrialTokenStatus.h
[modify] https://crrev.com/79237e966353560115a92eb802aa7da459cdaf9f/tools/metrics/histograms/histograms.xml
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 8 2016

Labels: -M-53 -Pri-1 M-54 MovedFrom-53 Pri-2
This issue is Pri-1 but has already been moved once. Lowering the priority and moving to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by cha...@chromium.org, Aug 23 2016

Labels: -M-54 -MovedFrom-53 M-53
Status: Fixed (was: Started)
Summary: Implement remote revocation of origin trials experim (was: Implement remote revocation of origin trials experiments)
This was landed in M53.

Comment 6 by cha...@chromium.org, Aug 30 2016

Summary: Implement remote revocation of origin trials experiments (was: Implement remote revocation of origin trials experim)
Fix the title.
►

Sign in to add a comment