[Search engines] Missing Ok Google settings |
||||||||||||||||||||||
Issue descriptionThese are missing on Samus: * Show Google Now cards in the launcher * Enable "Ok Google" to start a voice search. * Manage Voice & Audio Activity
,
May 25 2016
,
May 25 2016
,
May 26 2016
Re-arranged the information a bit for OK GOOGLE. I think this better aligns with our current conventions. Cog = Manage Voice and Audio Activity Mocks: https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/cards#%2FPREVIEW-Search.png%3Fz=width
,
May 26 2016
Off state for ok google
,
May 26 2016
,
May 26 2016
,
May 27 2016
@dpapad is this something you could add to Search? Please mark as Available if not.
,
Jun 3 2016
I am currently working on the "About" page, and the plan is to work on "search within settings" after that. Marking as available for now.
,
Jul 25 2016
Issue 630078 has been merged into this issue.
,
Oct 14 2016
,
Nov 12 2016
,
Nov 15 2016
bettes@ - Should the icon for the "Voice and Audio Activity" link be the icon-external image (e.g. like for Wallpaper)?
,
Nov 15 2016
+bettes@ Also, please confirm that we want to eliminate the "learn more" link.
,
Nov 15 2016
Also: * There is a "Retrain voice model" link that shows up when OK Google is enabled. * There is an error indicator icon with the following possible error messages. (I do not know how to trigger any of theses): This feature is temporarily unavailable. <Help> <Native Client plugin> needs to be enabled to use this feature. Microphone is currently unavailable. <Manage microphone>
,
Nov 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1855b444e1246227907fdae45be098f2a1543982 commit 1855b444e1246227907fdae45be098f2a1543982 Author: stevenjb <stevenjb@chromium.org> Date: Tue Nov 29 02:08:08 2016 MD Settings: Add Hotword (OK Google) section to search_page The Hotword/OK Google section in the existing UI is... fragile. This is an attempt to simplify and implement the UI without breaking any existing functionality. It would benefit from a re-implementation, ideally ising the existing hotwordingPrivate API (which would may need to be expanded). BUG= 614439 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2507363002 Cr-Commit-Position: refs/heads/master@{#434830} [modify] https://crrev.com/1855b444e1246227907fdae45be098f2a1543982/chrome/app/settings_strings.grdp [modify] https://crrev.com/1855b444e1246227907fdae45be098f2a1543982/chrome/browser/extensions/api/settings_private/prefs_util.cc [modify] https://crrev.com/1855b444e1246227907fdae45be098f2a1543982/chrome/browser/resources/settings/controls/settings_checkbox.html [modify] https://crrev.com/1855b444e1246227907fdae45be098f2a1543982/chrome/browser/resources/settings/search_engines_page/search_engines_browser_proxy.js [modify] https://crrev.com/1855b444e1246227907fdae45be098f2a1543982/chrome/browser/resources/settings/search_page/compiled_resources2.gyp [modify] https://crrev.com/1855b444e1246227907fdae45be098f2a1543982/chrome/browser/resources/settings/search_page/search_page.html [modify] https://crrev.com/1855b444e1246227907fdae45be098f2a1543982/chrome/browser/resources/settings/search_page/search_page.js [modify] https://crrev.com/1855b444e1246227907fdae45be098f2a1543982/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/1855b444e1246227907fdae45be098f2a1543982/chrome/browser/ui/webui/settings/search_engines_handler.cc [modify] https://crrev.com/1855b444e1246227907fdae45be098f2a1543982/chrome/browser/ui/webui/settings/search_engines_handler.h [modify] https://crrev.com/1855b444e1246227907fdae45be098f2a1543982/chrome/test/data/webui/settings/search_page_test.js [modify] https://crrev.com/1855b444e1246227907fdae45be098f2a1543982/chrome/test/data/webui/settings/test_search_engines_browser_proxy.js
,
Nov 30 2016
fukino@ - can you add the "Show Google Now cards in the launcher" section to MD Settings? Thanks! (That is the "google-now-launcher" section in browser_options.html)
,
Dec 1 2016
No longer blocking issue 614589 since "Show Google Now cards in the launcher" is experimental.
,
Dec 1 2016
,
Dec 1 2016
,
Dec 9 2016
,
Dec 9 2016
dbeam@ looked through it, and it seems to be 100% enabled for Chrome OS en-US / en-GB users on all channels (as well as for all Googlers).
,
Dec 10 2016
,
Dec 12 2016
fukino@, any update on this?
,
Dec 13 2016
I'm sorry I didn't realize this is a blocker. I think I can send a CL tomorrow.
,
Dec 13 2016
Hi dbeam@,
How can I enable Google Now launcher in developer build?
I built the latest Chrome and pushed it to chell, but I don't see "Show Google Now cards in the launcher" section in chrome://settings.
Language is en-US, and base::FieldTrialList::FindFullName("GoogleNowExtension") returns empty string.
,
Dec 14 2016
maybe try adding to testing/variations/fieldtrial_testing_config.json?
,
Dec 14 2016
Thank you for the suggestion!
I was able to see the Google Now cards by adding following lines to testing/variations/fieldtrial_testing_config.json and use chromium(not chrome) build.
"GoogleNowExtension": [
{
"platforms": [
"chromeos"
],
"experiments": [
{
"name": "Enable",
"params": {
"id": "mnfadmojomeniojkkikjpgjaegolkbpb"
}
}
]
}
],
,
Dec 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f86db622fdf6c6ff92529e5f1365db5e8acfaecb commit f86db622fdf6c6ff92529e5f1365db5e8acfaecb Author: fukino <fukino@chromium.org> Date: Thu Dec 15 07:41:46 2016 MD Settings: Add "Show Google Now cards in the launcher" row in Search section. "Show Google Now cards" option should populate when it is enabled in field trial and the default search provider is google. BUG= 614439 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2572963004 Cr-Commit-Position: refs/heads/master@{#438776} [modify] https://crrev.com/f86db622fdf6c6ff92529e5f1365db5e8acfaecb/chrome/app/settings_strings.grdp [modify] https://crrev.com/f86db622fdf6c6ff92529e5f1365db5e8acfaecb/chrome/browser/extensions/api/settings_private/prefs_util.cc [modify] https://crrev.com/f86db622fdf6c6ff92529e5f1365db5e8acfaecb/chrome/browser/resources/settings/basic_page/basic_page.html [modify] https://crrev.com/f86db622fdf6c6ff92529e5f1365db5e8acfaecb/chrome/browser/resources/settings/search_engines_page/search_engines_browser_proxy.js [modify] https://crrev.com/f86db622fdf6c6ff92529e5f1365db5e8acfaecb/chrome/browser/resources/settings/search_page/search_page.html [modify] https://crrev.com/f86db622fdf6c6ff92529e5f1365db5e8acfaecb/chrome/browser/resources/settings/search_page/search_page.js [modify] https://crrev.com/f86db622fdf6c6ff92529e5f1365db5e8acfaecb/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/f86db622fdf6c6ff92529e5f1365db5e8acfaecb/chrome/browser/ui/webui/settings/search_engines_handler.cc [modify] https://crrev.com/f86db622fdf6c6ff92529e5f1365db5e8acfaecb/chrome/browser/ui/webui/settings/search_engines_handler.h [modify] https://crrev.com/f86db622fdf6c6ff92529e5f1365db5e8acfaecb/chrome/test/data/webui/settings/search_page_test.js [modify] https://crrev.com/f86db622fdf6c6ff92529e5f1365db5e8acfaecb/chrome/test/data/webui/settings/test_search_engines_browser_proxy.js
,
Dec 15 2016
,
Dec 20 2016
chrome OS version 9103.0.0/570.2955.0
,
Jan 30 2017
Has this change been merged to M57 yet?
,
Jan 30 2017
We should probably merge this. Since both MD Settings and ""Show Google Now cards" are experiments, users that receive both experiment will have a poor experience. The change is MD Settings only and is fairly straightforward.
,
Jan 30 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 31 2017
The fix landed on main branch and was verified before the M57 branch cut date. Removing Merge related labels. ketakid@, if you see problems on this issue, please reopen this. |
||||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||||
Comment 1 by tbuck...@chromium.org
, May 25 2016