New issue
Advanced search Search tips

Issue 614430 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

10%-15.4% regression in blink_perf.css at 395269:395270

Project Member Reported by robert...@chromium.org, May 24 2016

Issue description

See the link to graphs below.
 
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, May 24 2016

Cc: dgozman@chromium.org
Owner: dgozman@chromium.org

=== Auto-CCing suspected CL author dgozman@chromium.org ===

Hi dgozman@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : [DevTools] Dispatch messages to V8InspectorSession directly.
Author  : dgozman
Commit description:
  
This patch adds dispatcher, backend and frontend channel to V8InspectorSessionImpl
and removes agent public interfaces and their blink wrappers.

Drive-by: removed sessionId from inspector_protocol since InspectorSession now
handles it.

Next step would be to separate v8 instrumentation from InspectorSession,
remove latter from worker (depends on console efforts) and merge session
into WebDevToolsAgentImpl.

BUG= 580337 

Review-Url: https://codereview.chromium.org/1967933002
Cr-Commit-Position: refs/heads/master@{#395269}
Commit  : 4698dd61590b2cba8346c5efd83428b9a3c3e970
Date    : Sun May 22 01:54:41 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N   Good?
chromium@395268  970.806  50.4236  12  good
chromium@395269  1016.18  53.018   12  bad    <--

Bisect job ran on: win_perf_bisect
Bug ID: 614430

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests blink_perf.layout
Test Metric: line-layout-line-height/line-layout-line-height
Relative Change: 4.08%
Score: 95.0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/win_perf_bisect/builds/6533
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9011758568290026464


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5908340446593024

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
All graphs spiked and then returned back to previous levels. Let's wait a bit before closing this bug.
Status: Fixed (was: Assigned)
This seems to be recovered.

Sign in to add a comment