New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 614398 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Create informational pfq cheets builders

Project Member Reported by steve...@chromium.org, May 24 2016

Issue description

Now that we have 'cheets' builders as part of the PFQ, we desperately need corresponding informational builders so that we can detect failures sooner and have an easier time bisecting failures.

 
Whoever wants to own this can follow the steps from go/chromeos_config
Owner: steve...@chromium.org
Status: Started (was: Available)
It turns out the cheets builders are configured, but not to run arc-bvt-cq HWTests. I put up a CL to change them to only run those HWTests (+sanity). lmkwyt: https://chromium-review.googlesource.com/#/c/347090/

Project Member

Comment 3 by bugdroid1@chromium.org, May 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/12e4df53c34970915ab12940f7ca8b52d8d9e227

commit 12e4df53c34970915ab12940f7ca8b52d8d9e227
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Tue May 24 16:24:35 2016

Configure cheets informational builders to only run arc-bvt-cq HWTests

BUG= chromium:614398 
TEST=Add some builders to the informational waterfall and ensure
     they succeed and run the correct HWTests.

Change-Id: I0f2bb7904c43e58014a7c5736631b265de0707e5
Reviewed-on: https://chromium-review.googlesource.com/347090
Commit-Ready: Steven Bennetts <stevenjb@chromium.org>
Tested-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>

[modify] https://crrev.com/12e4df53c34970915ab12940f7ca8b52d8d9e227/cbuildbot/config_dump.json
[modify] https://crrev.com/12e4df53c34970915ab12940f7ca8b52d8d9e227/cbuildbot/config_lib.py
[modify] https://crrev.com/12e4df53c34970915ab12940f7ca8b52d8d9e227/cbuildbot/chromeos_config.py

dnj@ :

config_dump.json should now have correctly configured:
* cyan-cheets-tot-chrome-pfq-cheets-informational
* veyron_minnie-cheets-tot-chrome-pfq-cheets-informational

I would like to add these to the internal informational waterfall (https://uberchromegw.corp.google.com/i/chromeos.chrome/waterfall). 

IIRC this is handled specially somehow?

That should be addressed in go/chromeos_config
akeshet@ - I looked there but didn't see any mention of the informational
builders. Looking at _waterfall_config_map, I do not see any mention of the
informational builders there.
That map isn't really complete, and only covers the chromeos waterfall with any reliability. It's still informational only, though we'd like to improve it.
Cc: d...@chromium.org
I read through the doc twice now and I still don't understand how pfq-informational configurations are added to the chromiumos.chromium or chromeos.chrome waterfalls. I added some questions to the doc.

+dnj@ for real this time.

Comment 9 by dnj@google.com, May 27 2016

The "chromeos.chrome" waterfall doesn't load its configuration from Chromite. I only implemented that for the waterfalls that changed more than once a year :)

Let me know:
- The specific config target names that you want to run.
- Whether any of them need to run VMTests.

... and I can add builders to the "chromeos.chrome" waterfall.
Owner: d...@chromium.org
Status: Assigned (was: Started)
* cyan-cheets-tot-chrome-pfq-cheets-informational
* veyron_minnie-cheets-tot-chrome-pfq-cheets-informational

They should be configured as defined in config_dump.json (which should match the -pfq builders, so yes on HWTests but no on VMTests).

Thanks.

Also, FWIW, I think that the -pfq-informational builders should get added when -pfq builders get added. Early detection FTW.

Comment 12 by dnj@google.com, May 27 2016

Owner: dgarr...@chromium.org
dgarrett@: can we allocate two GCE builders for this? Pick any class that you want. I'll go ahead and prepare a CL for the waterfall update part. Re-assign to me once the slaves exist.
Steven, how much computer should the informational builders need? 8, 16, or 32 cores?
Uh... is that a trick question? i.e. as many as possible?

These should be similar to other informational builders. They run BuildPackages so the faster the better. I believe our ebuilds are parallelized.

In the grand scheme of things cycle times here are probably less critical than the PFQ itself, but that said they run more often and sometimes allow us to catch  failures before they are seen in the PFQ (and often allow us to bisect failures faster).

Comment 15 by dnj@google.com, May 27 2016

The other ones that are on GCE are currently running beefy.
Beefy it is.
I created:
  cros-beefy191-c2
  cros-beefy192-c2

https://chromereviews.googleplex.com/437177013/
Owner: d...@chromium.org

Comment 19 by dnj@google.com, May 27 2016

Status: Fixed (was: Assigned)
The waterfall update has landed, and a restart is scheduled. It should be complete in 30 minutes.
Project Member

Comment 20 by bugdroid1@chromium.org, May 27 2016

Project Member

Comment 21 by bugdroid1@chromium.org, May 27 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/infra_internal.git/+/bc998efb723fad38bf8984254b35b72a13bd14cc

commit bc998efb723fad38bf8984254b35b72a13bd14cc
Author: dgarrett <dgarrett@google.com>
Date: Fri May 27 20:22:35 2016

Project Member

Comment 22 by bugdroid1@chromium.org, Jun 17 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/build/+/aa9f6db2be3714142ff29d5ee2faa28a5a409a6f

commit aa9f6db2be3714142ff29d5ee2faa28a5a409a6f
Author: dnj <dnj@google.com>
Date: Fri May 27 20:09:05 2016

Status: Verified (was: Fixed)
Bulk verified

Sign in to add a comment