New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 614394 link

Starred by 0 users

Issue metadata

Status: Duplicate
Merged: issue 599776
Owner:
OOO until 2019-01-24
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 1
Type: Bug

Blocked on:
issue 571456
issue 599776
issue 605739
issue 614526
issue 615178
issue 617833

Blocking:
issue 615548
issue 616629



Sign in to add a comment

"screenshot_sync_tests (with patch)" is flaky on Mac

Project Member Reported by chromium...@appspot.gserviceaccount.com, May 24 2016

Issue description

"screenshot_sync_tests (with patch)" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLQsSBUZsYWtlIiJzY3JlZW5zaG90X3N5bmNfdGVzdHMgKHdpdGggcGF0Y2gpDA.



This flaky test/step was previously tracked in  issue 550016 .
 
Project Member

Comment 1 by chromium...@appspot.gserviceaccount.com, May 25 2016

Detected 3 new flakes for test/step "screenshot_sync_tests (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLQsSBUZsYWtlIiJzY3JlZW5zaG90X3N5bmNfdGVzdHMgKHdpdGggcGF0Y2gpDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Project Member

Comment 2 by chromium...@appspot.gserviceaccount.com, May 26 2016

Detected 3 new flakes for test/step "screenshot_sync_tests (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLQsSBUZsYWtlIiJzY3JlZW5zaG90X3N5bmNfdGVzdHMgKHdpdGggcGF0Y2gpDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).

Comment 3 by suzyh@chromium.org, May 30 2016

Cc: erikc...@chromium.org
Components: Internals>GPU>Testing
Failures are
ScreenshotSync.WithCanvas
ScreenshotSync.WithDivs

The timing of this latest stretch of flakiness lines up with  issue 614393 .

The patchset attached to the first in this stretch is https://codereview.chromium.org/2005853003/ which added debugging. This was reverted in https://codereview.chromium.org/2015983002/ which approximately lines up with the end of the stretch of flakiness, so that may be all it is.

erikchen: can you investigate/confirm?
Project Member

Comment 4 by chromium...@appspot.gserviceaccount.com, May 31 2016

Detected 3 new flakes for test/step "screenshot_sync_tests (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLQsSBUZsYWtlIiJzY3JlZW5zaG90X3N5bmNfdGVzdHMgKHdpdGggcGF0Y2gpDA. This message was posted automatically by the chromium-try-flakes app.
If my debugging CL is causing flakiness in *screenshot_sync_tests*, then something is /very/ broken with screenshot_sync_tests. 

My CLs only affect Windows, and one of the flakes was on Mac? I suggest you try looking at other possible culprits.

Comment 6 by kbr@chromium.org, Jun 1 2016

Blockedon: 571456 615178
Cc: nedngu...@google.com
Components: Tests>Telemetry
Labels: Hotlist-PixelWrangler
The symptom on mac_chromium_rel_ng is that the browser fails to start. This is what breaks ScreenshotSync.WithCanvas. ScreenshotSync.WithDivs then fails because the browser is wedged, and wasn't restarted after the first test timed out. This is similar to  Issue 571456 , which was on slower hardware, and also to  Issue 615178 , which seems to be happening on multiple bots.

Comment 7 by kbr@chromium.org, Jun 1 2016

Blockedon: 614526
Also: the Windows failures are caused by the Swarming pool being overloaded, which is being worked on in Issue 614526.

Labels: -Sheriff-Chromium OS-Linux OS-Mac
Owner: kbr@chromium.org
Summary: "screenshot_sync_tests (with patch)" is flaky on Mac (was: "screenshot_sync_tests (with patch)" is flaky)
The detail in comment 6 and 7 is helpful.  Marking this as specific to Mac, as bug 614526 covers Windows.

As a sheriff it's not clear to me who should own this.  It seems like we've got some similar past/present bugs, but it's not quite clear what's going on or whose responsibility it is.  Ken, I'm pretty sure you're not the right owner here, but given that you have the clearest insight so far, can you triage to an appropriate person to take this on?
Cc: kbr@chromium.org
 Issue 614393  has been merged into this issue.

Comment 10 by kbr@chromium.org, Jun 2 2016

Cc: ericrk@chromium.org
Yes, I can own this. I've had to email chromium-dev to ask if anyone's touched browser startup recently. I have a feeling that something was broken there recently and that these are all legitimate failures that affect the product.

Components: Platform>DevTools
The Screenshot timeout is showing up in several tests including screenshot_sync, pixel_test, and gpu_rasterization_tests.

Example logs attached.
Mac_2010_10_Retina_Release_AMD_screenshot_sync.txt
54.9 KB View Download
Mac_2010_10_Retina_Release_AMD_pixel_test.txt
183 KB View Download
Blocking: 615548
Blocking: 616629
Cc: rogerta@chromium.org
There was a thread about browser crash upon startup on Mac a while ago due to Roger's CL, and we have to revert it. Then the crash disappear mysteriously with his CL so he just went ahead & relanded it.

His CL was: https://codereview.chromium.org/1746993002/

The diagnosis in #6 is that the browser failed to start.  Does this look like the case with the attached logs?  My assumption is that by the time we run the 'tab.Screenshot(5)' code, the browser should already be running.
Project Member

Comment 16 by chromium...@appspot.gserviceaccount.com, Jun 2 2016

Detected 7 new flakes for test/step "screenshot_sync_tests (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLQsSBUZsYWtlIiJzY3JlZW5zaG90X3N5bmNfdGVzdHMgKHdpdGggcGF0Y2gpDA. This message was posted automatically by the chromium-try-flakes app.
FWIW, I remember seeing a startup crash on Mac due to some checks in profile. If I use something like --user-data-dir=/tmp/ajsdalkj the crash disappears.
Project Member

Comment 18 by chromium...@appspot.gserviceaccount.com, Jun 2 2016

Detected 17 new flakes for test/step "gpu_rasterization_tests (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLwsSBUZsYWtlIiRncHVfcmFzdGVyaXphdGlvbl90ZXN0cyAod2l0aCBwYXRjaCkM. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 19 by chromium...@appspot.gserviceaccount.com, Jun 3 2016

Detected 33 new flakes for test/step "gpu_rasterization_tests (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLwsSBUZsYWtlIiRncHVfcmFzdGVyaXphdGlvbl90ZXN0cyAod2l0aCBwYXRjaCkM. This message was posted automatically by the chromium-try-flakes app.

Comment 20 by kbr@chromium.org, Jun 3 2016

Blockedon: 605739

Comment 21 by kbr@chromium.org, Jun 4 2016

Blockedon: 599776
Being investigated actively under  Issue 599776 .

Project Member

Comment 22 by chromium...@appspot.gserviceaccount.com, Jun 4 2016

Detected 8 new flakes for test/step "screenshot_sync_tests (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLQsSBUZsYWtlIiJzY3JlZW5zaG90X3N5bmNfdGVzdHMgKHdpdGggcGF0Y2gpDA. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 23 by chromium...@appspot.gserviceaccount.com, Jun 4 2016

Detected 5 new flakes for test/step "gpu_rasterization_tests (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLwsSBUZsYWtlIiRncHVfcmFzdGVyaXphdGlvbl90ZXN0cyAod2l0aCBwYXRjaCkM. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 24 by chromium...@appspot.gserviceaccount.com, Jun 6 2016

Detected 3 new flakes for test/step "gpu_rasterization_tests (with patch)". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLwsSBUZsYWtlIiRncHVfcmFzdGVyaXphdGlvbl90ZXN0cyAod2l0aCBwYXRjaCkM. This message was posted automatically by the chromium-try-flakes app.

Comment 25 by kbr@chromium.org, Jun 7 2016

Blockedon: 617833

Comment 26 by kbr@chromium.org, Jun 7 2016

Mergedinto: 599776
Status: Duplicate (was: Untriaged)
Duplicating all screenshot-related timeouts on the AMD based Retina MacBook Pros into  Issue 599776 . The root cause is known and a fix / workaround is underway.

Sign in to add a comment