[Languages] Let users re-order language list |
|||||||||||||||
Issue descriptionThe order is sent to websites so that they can pick the best language for the user. Just a way to promote/demote languages is enough, we don't necessarily need a drag-and-drop UI. We should also mention why the order is important somewhere (see existing message).
,
May 25 2016
,
May 25 2016
,
May 25 2016
,
May 25 2016
,
May 25 2016
Assigning back to you Michael. Let me know if there's anything not resolved. - Adding supplementary text to the top of the card - Adding an overflow menu to each enabled language row. From there, users will have the ability to move up or down. Mocks https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/cards#%2FPREVIEW-Language.png%3Fz=width Specs on subpages https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/specs#%2FSPEC-settings_structure-subpage.png%3Fz=width
,
May 25 2016
Would this be better as a 3-dot menu at the top-level (replacing the cog) instead of on the "Manage languages" subpage? I've always thought of "Manage languages" as only for adding/removing languages.
,
May 26 2016
Yeah good point. If Michael doesn't have any objections, let's do that instead.
,
May 26 2016
,
May 31 2016
,
Jun 3 2016
,
Jun 4 2016
No objections but: > I've always thought of "Manage languages" as only for adding/removing > languages. Then why don't we call it that?
,
Jun 7 2016
I'd prefer sticking with "Manage languages" over "Add/remove languages"
,
Jun 14 2016
,
Jun 16 2016
,
Jun 16 2016
Did we decide to keep the 3-dot (aka Kabob) menu in the subpage or bring it to the top-level replacing the cog? If so, a few questions: 1. wouldn't replacing the cog make the "Language" section inconsistent with the "spell check"? Can we perhaps get rid of the cog elsewhere? They seem to be redundant and at the first look it was very confusing to me that the cog took me to the same place when clicked from the languages vs spellcheck sections. 2. would the cog become another entry in the 3-dot menu? e.g., "Edit language"? 3. Would the supplementary text on the top card make the UI too busy?
,
Jun 16 2016
1. The cogwheel is removed from the spell check subsection in issue 599993 (CL here: https://codereview.chromium.org/2052573003/) 2. Tom, WDYT? The "edit language" page only has three things: - the "show Chrome in this language" locale toggle button (CrOS and Windows only) - the Restart button if the locale is changed (CrOS and Widnows only) - the "Enable translate" checkbox (or the text "This language cannot be translated") 3. If you mean the paragraph on the "Manage languages" sub-page, I think that's obsolete since the menu should be on the section's main page instead. IMO the text is unnecessary anyway.
,
Jun 17 2016
2. Our recent goal was to remove the cogs so that clicking on a language row would take the user to the detail page. However, on platforms such as Chrome OS where a language can be selected, clicking the row should activate that language. So let's continue offering a way to get to the subpage with a "Language settings" item in the 3-dot menu. 3. I'd ideally like to keep the help text within the iron-collapse, but I don't know of any pre-existing pattern for that. Let's add a row at the top of the languages list (within the iron-collapse) saying "Order languages based on your preference. [Learn more]" as in the attached mock. It should only appear when 2+ languages are listed :-)
,
Jun 20 2016
#18: the help text is distracting there, it's hard to differentiate it from the language items. Should there be a grey border like the one between "French" and "Manage languages"? BTW, on most platforms we'll have 2 languages anyway: both "English" and "English (United States)" are enabled and listed. Assuming "English (United States)" is your locale, you cannot remove "English". This is by design: crosbug.com/9884 but maybe should not show up in Settings (it's hard, we can talk more online). The code that does that is https://cs.chromium.org/chromium/src/components/translate/core/browser/translate_prefs.cc?sq=package:chromium&dr=CSs&rcl=1466435904&l=51
,
Jun 20 2016
,
Jun 22 2016
Issue 622507 has been merged into this issue.
,
Jun 27 2016
Issue 623304 has been merged into this issue.
,
Jun 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/04d3fdc643cd42e4734e59584b0c75daa4481cb5 commit 04d3fdc643cd42e4734e59584b0c75daa4481cb5 Author: mahmadi <mahmadi@chromium.org> Date: Tue Jun 28 14:43:24 2016 MD Settings: Allow the user to order the list of languages. BUG= 614382 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2077063002 Cr-Commit-Position: refs/heads/master@{#402464} [modify] https://crrev.com/04d3fdc643cd42e4734e59584b0c75daa4481cb5/chrome/app/settings_strings.grdp [modify] https://crrev.com/04d3fdc643cd42e4734e59584b0c75daa4481cb5/chrome/browser/resources/settings/languages_page/languages.js [modify] https://crrev.com/04d3fdc643cd42e4734e59584b0c75daa4481cb5/chrome/browser/resources/settings/languages_page/languages_page.html [modify] https://crrev.com/04d3fdc643cd42e4734e59584b0c75daa4481cb5/chrome/browser/resources/settings/languages_page/languages_page.js [modify] https://crrev.com/04d3fdc643cd42e4734e59584b0c75daa4481cb5/chrome/browser/resources/settings/languages_page/languages_types.js [modify] https://crrev.com/04d3fdc643cd42e4734e59584b0c75daa4481cb5/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc [modify] https://crrev.com/04d3fdc643cd42e4734e59584b0c75daa4481cb5/chrome/test/data/webui/settings/languages_page_browsertest.js [modify] https://crrev.com/04d3fdc643cd42e4734e59584b0c75daa4481cb5/chrome/test/data/webui/settings/languages_page_tests.js
,
Jun 28 2016
,
Jul 12 2016
Issue 627118 has been merged into this issue. |
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by tbuck...@chromium.org
, May 25 2016