Ensure accessibility strings are set for WebApks |
|||||||||
Issue descriptionSam reported that accessibility settings for the activity used for WebApks are incorrect and report the title as "Web App: <website>". We should omit the "web app" prefix
,
Nov 8 2016
,
Jan 4 2017
I think this is fixed, since I only see IDS_WEBAPP_ACTIVITY_TITLE in strings and not anywhere in the code. Xi, can you confirm?
,
Jan 4 2017
I don't think we had special fix for this. I vaguely remember that we have doubted that the accessibility settings uses the real activity name (the WebApkActivity of Chrome), not the app which holds the activity.
,
Jan 18 2017
Just tested this, the name of the activity comes up as "Chrome Dev web app" in recents. I think it'd be preferable to just use the same name that it's shown with.
,
Jan 18 2017
+lpalmaro FYI
,
Jan 20 2017
,
Jan 23 2017
I've been testing how this works, and it seems to work like @hanxi said. The recents view uses the label on the application tag on the manifest followed by the label tag on the activity. Since we're on the Chrome activity and not the Web APK's, it reads 'Chromium web app'. We can remove web app text, since that's just the label of the WebApkActivity, but not the browser app name, since that's common to all activities. I also noticed that when opening the app it used to say 'Web app', since that's the tag on the activity. Calling setTitle when starting up fixes that, but it doesn't do anything about the recents list. With what I mentioned, the only place that Talk Balk would be wrong is the recents UI, where it would just say the name of the browser app (Chrome, Chromium, etc). We could add something extra to differentiate WebAPKs from the actual browser, but I can't think of a way to differentiate between WebAPKs. If anyone has any ideas on how to do it please let me know. @pkotwicz @hanxi
,
Jan 25 2017
Thanks for digging into it Gonzalo! I think leaving in the browser app name is OK. It's more information than we put in the title but if that's the standard structure for talkback labels it makes sense to follow the system convention. Can we setTitle with the name of the app as it's shown in recents? (short_name or name, I'm not sure.) That would differentiate different WebAPKs and line up pretty well with what's visible as well.
,
Jan 25 2017
I tried a few more things today, and it looks like I got to a promising solution. I had tried making the label empty before, but I just removed the label altogether to see what happens and it seems to be working as we want it to. The recents UI reads the Web APK name (without browser name) and when opening the app from the home screen the correct name is read. It's a bit strange, since all other activities do have a label, but I guess Web APKs are a special case. I think Peter talked about asking someone on the Android team to review the CL to make sure we aren't breaking anything with it.
,
Jan 27 2017
Assigning to Sam for feedback Gonzalo and I did quite a bit of investigation (Mostly Gonzalo) We were able to get two different states For an app with app name "Notifications": ____________________________________________________________________________ | |_____________Talkback readout____________________________________| |_________| WebAPK launched from the homescreen | WebAPK focused in recents | |State 1__|_________"Webapp Notifications"______|__"Webapp Notifications"___| |State 2__|_____________"Notifications"_________|__"Chromium Notifications"_| I think that "State 1" is preferable to "State 2". "State 1" is the way that things are right now. Sam what do you think?
,
Jan 27 2017
Sorry -- is "Notifications" the name of the WebAPK in this example, or is that the string for all WebAPKs? If that's the name of the WebAPK I agree that state 1 is better for consistency. If not I think they're all pretty confusing!
,
Jan 31 2017
Yes, "Notifications" is the name of the WebAPK in this example. Marking as WontFix per comment #12 |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by pkotw...@chromium.org
, Nov 2 2016