New issue
Advanced search Search tips

Issue 614352 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature

Blocked on:
issue 584367

Blocking:
issue 585656



Sign in to add a comment

Allow origin trials on static attributes

Project Member Reported by iclell...@chromium.org, May 24 2016

Issue description

Static IDL attributes are installed on the interface object, rather than any instance, or even the prototype.

This isn't supported by the current origin trial bindings generation code, but could be added in order to enable this.
 

Comment 1 by cha...@chromium.org, Jun 24 2016

Blocking: 585656
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 8 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ba930f9c87cf8b2fca5e561a9ba6ec6e0e3c1d2

commit 7ba930f9c87cf8b2fca5e561a9ba6ec6e0e3c1d2
Author: iclelland <iclelland@chromium.org>
Date: Fri Jul 08 16:43:08 2016

[Origin Trials] Allow static attributes to be defined on origin trials

BUG= 614352 

Review-Url: https://codereview.chromium.org/2116533003
Cr-Commit-Position: refs/heads/master@{#404408}

[modify] https://crrev.com/7ba930f9c87cf8b2fca5e561a9ba6ec6e0e3c1d2/third_party/WebKit/LayoutTests/http/tests/origin_trials/resources/origin_trials.js
[modify] https://crrev.com/7ba930f9c87cf8b2fca5e561a9ba6ec6e0e3c1d2/third_party/WebKit/Source/bindings/scripts/v8_attributes.py
[modify] https://crrev.com/7ba930f9c87cf8b2fca5e561a9ba6ec6e0e3c1d2/third_party/WebKit/Source/bindings/templates/interface_base.cpp
[modify] https://crrev.com/7ba930f9c87cf8b2fca5e561a9ba6ec6e0e3c1d2/third_party/WebKit/Source/bindings/tests/idls/modules/TestInterfacePartial4.idl
[modify] https://crrev.com/7ba930f9c87cf8b2fca5e561a9ba6ec6e0e3c1d2/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp
[modify] https://crrev.com/7ba930f9c87cf8b2fca5e561a9ba6ec6e0e3c1d2/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp
[modify] https://crrev.com/7ba930f9c87cf8b2fca5e561a9ba6ec6e0e3c1d2/third_party/WebKit/Source/core/origin_trials/testing/InternalsFrobulate.cpp
[modify] https://crrev.com/7ba930f9c87cf8b2fca5e561a9ba6ec6e0e3c1d2/third_party/WebKit/Source/core/origin_trials/testing/InternalsFrobulate.h
[modify] https://crrev.com/7ba930f9c87cf8b2fca5e561a9ba6ec6e0e3c1d2/third_party/WebKit/Source/core/origin_trials/testing/InternalsFrobulate.idl

Comment 5 by cha...@chromium.org, Aug 19 2016

Owner: iclell...@chromium.org
Status: Fixed (was: Available)
Ian, I think this is done. If not, please re-open with details on what's left.

Sign in to add a comment