New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 614348 link

Starred by 1 user
Status: Duplicate
Merged: issue 613979
Owner:
scottmg@chromium.org
Closed: May 2016
Cc:
wjmaclean@chromium.org
nyerramilli@chromium.org
█ cernekee@chromium.org
█ ashej...@chromium.org
scottmg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: On sign in overlay complete text is not seen after changing page zoom level.

Reported by rk...@etouch.net, May 24 2016 
Chrome Version: 52.0.2743.3 Revision 8be70850ebcd3ec9433ba7606521c44009e96655-refs/branch-heads/2743@{#23}(32/64 bit)
OS: Windows(7,8,10), Linux(Ubuntu 14.04 LTS)

Precondition: Enable 'new gaia password-separated sign in flow' flag from 'chrome://flags'.

What steps will reproduce the problem?
(1) Launch chrome,  navigate to chrome://settings and change page zoom level to(e.g.175%) from 'Web content'
(2) Click on 'Sign in to Chrome' and observe the sign in overlay.

Text on sign in overlay is not seen properly i.e. half text is not seen after changing page zoom level.

Text on sign in overlay should seen properly.

This is a regression issue,broken in 'M-52', below is bisect info:

Good Build: 52.0.2740.0
Bad Build: 52.0.2741.0

Narrow Bisect: 
https://chromium.googlesource.com/chromium/src/+log/93daa3576ba6a63744156f50ebc14a002aab5b36..b3f5671fe9436df46c470f35230bffe0a77fbb0d?pretty=fuller&n=100

Suspecting: r394519

Note: Issue is not seen on Mac OS.
Screenshot.png
77.7 KB View Download

Comment 1 by cernekee@chromium.org, May 24 2016

Cc: cernekee@chromium.org scottmg@chromium.org
Owner: ----
Hmm, that setting doesn't exist on Chrome OS, and I don't think I touched anything that actually runs on Chrome for Linux.  Most of those files are only used for SAML logins anyway.

Here's another commit from the same set which directly affects zoom: https://codereview.chromium.org/1964273002

Comment 2 by scottmg@chromium.org, May 24 2016

Owner: scottmg@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, May 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34ce95dd9c2ca3b90fc87169f1e4ed266e7bb94b

commit 34ce95dd9c2ca3b90fc87169f1e4ed266e7bb94b
Author: scottmg <scottmg@chromium.org>
Date: Wed May 25 01:04:56 2016

Revert of Add FrameHost mojo service (patchset #23 id:490001 of https://codereview.chromium.org/1964273002/ )

Reason for revert:
Async request for zoom level doesn't work in all cases  https://crbug.com/614348   https://crbug.com/613979 .

I thought https://www.chromium.org/developers/design-documents/mojo/chrome-ipc-to-mojo-ipc-cheet-sheet#TOC-Threading-Model implied the ordering would be correct, but it seems that was too hopeful.

Original issue's description:
> Add FrameHost mojo service
>
> Adds new frame-level service with one initial method to handle host zoom
> level.
>
> This moves zoom level supply from async_resource_handler.cc to being a
> request made when render_frame_impl handles a willSendRequest.
>
> The goal of this change is to remove the dependency of
> content/browser/loader on the rest of content/browser in particular
> here, removing the use of c/b/host_zoom_map_impl.h in
> content/browser/loader/async_resource_handler.cc.
>
> BUG=598073, 609607 
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
>
> Committed: https://crrev.com/68c6f2ce16d9807b5cb82679099c82c40f39e911
> Cr-Commit-Position: refs/heads/master@{#394547}

TBR=dcheng@chromium.org,ben@chromium.org,jam@chromium.org,nasko@chromium.org,wjmaclean@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=598073, 609607 , 614348 , 613979 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2007203002
Cr-Commit-Position: refs/heads/master@{#395761}

[modify] https://crrev.com/34ce95dd9c2ca3b90fc87169f1e4ed266e7bb94b/build/android/pylib/gtest/filter/content_browsertests_disabled
[modify] https://crrev.com/34ce95dd9c2ca3b90fc87169f1e4ed266e7bb94b/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/34ce95dd9c2ca3b90fc87169f1e4ed266e7bb94b/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/34ce95dd9c2ca3b90fc87169f1e4ed266e7bb94b/content/browser/host_zoom_map_impl.h
[modify] https://crrev.com/34ce95dd9c2ca3b90fc87169f1e4ed266e7bb94b/content/browser/loader/DEPS
[modify] https://crrev.com/34ce95dd9c2ca3b90fc87169f1e4ed266e7bb94b/content/browser/loader/async_resource_handler.cc
[modify] https://crrev.com/34ce95dd9c2ca3b90fc87169f1e4ed266e7bb94b/content/browser/loader/async_revalidation_manager_unittest.cc
[modify] https://crrev.com/34ce95dd9c2ca3b90fc87169f1e4ed266e7bb94b/content/browser/loader/resource_dispatcher_host_unittest.cc
[modify] https://crrev.com/34ce95dd9c2ca3b90fc87169f1e4ed266e7bb94b/content/browser/loader/resource_message_filter.cc
[modify] https://crrev.com/34ce95dd9c2ca3b90fc87169f1e4ed266e7bb94b/content/browser/loader/resource_message_filter.h
[modify] https://crrev.com/34ce95dd9c2ca3b90fc87169f1e4ed266e7bb94b/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/34ce95dd9c2ca3b90fc87169f1e4ed266e7bb94b/content/common/BUILD.gn
[delete] https://crrev.com/bcd06ba900e67c54ffffb3f421c6b0d1bcd8ef31/content/common/frame_host.mojom
[modify] https://crrev.com/34ce95dd9c2ca3b90fc87169f1e4ed266e7bb94b/content/common/view_messages.h
[modify] https://crrev.com/34ce95dd9c2ca3b90fc87169f1e4ed266e7bb94b/content/content_common_mojo_bindings.gyp
[modify] https://crrev.com/34ce95dd9c2ca3b90fc87169f1e4ed266e7bb94b/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/34ce95dd9c2ca3b90fc87169f1e4ed266e7bb94b/content/renderer/render_frame_impl.h
[modify] https://crrev.com/34ce95dd9c2ca3b90fc87169f1e4ed266e7bb94b/content/renderer/render_frame_impl_browsertest.cc
[modify] https://crrev.com/34ce95dd9c2ca3b90fc87169f1e4ed266e7bb94b/content/renderer/render_view_browsertest.cc
[modify] https://crrev.com/34ce95dd9c2ca3b90fc87169f1e4ed266e7bb94b/content/renderer/render_view_impl.cc
[modify] https://crrev.com/34ce95dd9c2ca3b90fc87169f1e4ed266e7bb94b/content/renderer/render_view_impl.h

Comment 4 by wjmaclean@chromium.org, May 25 2016

Cc: wjmaclean@chromium.org

Comment 5 by scottmg@chromium.org, May 26 2016

Mergedinto: 613979
Status: Duplicate (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, May 27 2016

Labels: merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b43ea3087da4e351f0bf94481c9810738c3ae938

commit b43ea3087da4e351f0bf94481c9810738c3ae938
Author: Scott Graham <scottmg@chromium.org>
Date: Fri May 27 22:40:35 2016

Revert of Add FrameHost mojo service (patchset #23 id:490001 of https://codereview.chromium.org/1964273002/ )

Reason for revert:
Async request for zoom level doesn't work in all cases  https://crbug.com/614348   https://crbug.com/613979 .

I thought https://www.chromium.org/developers/design-documents/mojo/chrome-ipc-to-mojo-ipc-cheet-sheet#TOC-Threading-Model implied the ordering would be correct, but it seems that was too hopeful.

Original issue's description:
> Add FrameHost mojo service
>
> Adds new frame-level service with one initial method to handle host zoom
> level.
>
> This moves zoom level supply from async_resource_handler.cc to being a
> request made when render_frame_impl handles a willSendRequest.
>
> The goal of this change is to remove the dependency of
> content/browser/loader on the rest of content/browser in particular
> here, removing the use of c/b/host_zoom_map_impl.h in
> content/browser/loader/async_resource_handler.cc.
>
> BUG=598073, 609607 
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
>
> Committed: https://crrev.com/68c6f2ce16d9807b5cb82679099c82c40f39e911
> Cr-Commit-Position: refs/heads/master@{#394547}

TBR=dcheng@chromium.org,ben@chromium.org,jam@chromium.org,nasko@chromium.org,wjmaclean@chromium.org
BUG=598073, 609607 , 614348 , 613979 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2007203002
Cr-Commit-Position: refs/heads/master@{#395761}
(cherry picked from commit 34ce95dd9c2ca3b90fc87169f1e4ed266e7bb94b)

Review URL: https://codereview.chromium.org/2020633003 .

Cr-Commit-Position: refs/branch-heads/2743@{#111}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/b43ea3087da4e351f0bf94481c9810738c3ae938/build/android/pylib/gtest/filter/content_browsertests_disabled
[modify] https://crrev.com/b43ea3087da4e351f0bf94481c9810738c3ae938/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/b43ea3087da4e351f0bf94481c9810738c3ae938/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/b43ea3087da4e351f0bf94481c9810738c3ae938/content/browser/host_zoom_map_impl.h
[modify] https://crrev.com/b43ea3087da4e351f0bf94481c9810738c3ae938/content/browser/loader/DEPS
[modify] https://crrev.com/b43ea3087da4e351f0bf94481c9810738c3ae938/content/browser/loader/async_resource_handler.cc
[modify] https://crrev.com/b43ea3087da4e351f0bf94481c9810738c3ae938/content/browser/loader/async_revalidation_manager_unittest.cc
[modify] https://crrev.com/b43ea3087da4e351f0bf94481c9810738c3ae938/content/browser/loader/resource_dispatcher_host_unittest.cc
[modify] https://crrev.com/b43ea3087da4e351f0bf94481c9810738c3ae938/content/browser/loader/resource_message_filter.cc
[modify] https://crrev.com/b43ea3087da4e351f0bf94481c9810738c3ae938/content/browser/loader/resource_message_filter.h
[modify] https://crrev.com/b43ea3087da4e351f0bf94481c9810738c3ae938/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/b43ea3087da4e351f0bf94481c9810738c3ae938/content/common/BUILD.gn
[delete] https://crrev.com/d2634566be6ed8b068e1ff5414525627a8adb7fc/content/common/frame_host.mojom
[modify] https://crrev.com/b43ea3087da4e351f0bf94481c9810738c3ae938/content/common/view_messages.h
[modify] https://crrev.com/b43ea3087da4e351f0bf94481c9810738c3ae938/content/content_common_mojo_bindings.gyp
[modify] https://crrev.com/b43ea3087da4e351f0bf94481c9810738c3ae938/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/b43ea3087da4e351f0bf94481c9810738c3ae938/content/renderer/render_frame_impl.h
[modify] https://crrev.com/b43ea3087da4e351f0bf94481c9810738c3ae938/content/renderer/render_frame_impl_browsertest.cc
[modify] https://crrev.com/b43ea3087da4e351f0bf94481c9810738c3ae938/content/renderer/render_view_browsertest.cc
[modify] https://crrev.com/b43ea3087da4e351f0bf94481c9810738c3ae938/content/renderer/render_view_impl.cc
[modify] https://crrev.com/b43ea3087da4e351f0bf94481c9810738c3ae938/content/renderer/render_view_impl.h
►

Sign in to add a comment