WebappUrlBarTest#testUrlDisplay is very flaky on Marshmallow Tablet Tester |
||
Issue descriptionWebappUrlBarTest#testUrlDisplay is very flaky on Marshmallow Tablet Tester, there were 6 failures in the 10 most recent runs: https://uberchromegw.corp.google.com/i/chromium.android/builders/Marshmallow%20Tablet%20Tester/builds/4005 https://uberchromegw.corp.google.com/i/chromium.android/builders/Marshmallow%20Tablet%20Tester/builds/4007 https://uberchromegw.corp.google.com/i/chromium.android/builders/Marshmallow%20Tablet%20Tester/builds/4009 https://uberchromegw.corp.google.com/i/chromium.android/builders/Marshmallow%20Tablet%20Tester/builds/4011 https://uberchromegw.corp.google.com/i/chromium.android/builders/Marshmallow%20Tablet%20Tester/builds/4012 https://uberchromegw.corp.google.com/i/chromium.android/builders/Marshmallow%20Tablet%20Tester/builds/4013 It's timing out failing to meet criteria: C 1823.201s Main [FAIL] org.chromium.chrome.browser.webapps.WebappUrlBarTest#testUrlDisplay: C 1823.201s Main junit.framework.AssertionFailedError: Criteria not met in allotted time. C 1823.201s Main at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:74) C 1823.201s Main at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:89) C 1823.201s Main at org.chromium.chrome.browser.webapps.WebappActivityTestBase.waitUntilIdle(WebappActivityTestBase.java:136) C 1823.201s Main at org.chromium.chrome.browser.webapps.WebappActivityTestBase.startWebappActivity(WebappActivityTestBase.java:116) C 1823.201s Main at org.chromium.chrome.browser.webapps.WebappActivityTestBase.startWebappActivity(WebappActivityTestBase.java:108) C 1823.201s Main at org.chromium.chrome.browser.webapps.WebappUrlBarTest.setUp(WebappUrlBarTest.java:32) C 1823.201s Main at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161) C 1823.201s Main at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124) C 1823.201s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191) C 1823.201s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176) C 1823.201s Main at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555) C 1823.201s Main at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1879) Initially assigning to Dan for further triage.
,
Jun 28 2016
Do your M testers have the same hardware as your KitKat and Lollipop testers? We've seen the exact same failure on various of our KitKat and Lollipop devices as well - mostly on Debug builds and almost exclusively on less expensive devices. Could the fact that this only failed on M be coincidence based on the performance of those devices?
,
Jun 28 2016
I'm relatively convinced that this is simply a timeout which isn't long enough that's causing the problem. With one of our affected devices and num_retries=0, I can get this to fail 9 out of 10 test runs. Increasing the timeout in WebappActivityTestBase.waitUntilIdle leads to 0 out of 10 test runs failing. I'll experiment some more to see if there's a specific reason on why startup is that slow, but unless I find another root cause I'd propose simply increasing the timeout and re-enabling those tests on M --> I'll update (and most likely post a CL) as soon as I have additional information.
,
Jun 28 2016
I looked into it some more. When I look at the device without an increased timeout, it's clearly visible that it is still loading when it hits the timeout most of the time. I couldn't find anything suspicious that took overly long - it's just going over the three seconds. I'd therefore recommend just increasing the timeout. Proposed fix: https://codereview.chromium.org/2108913002
,
Jun 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6db590fb7126cbf0c9a606b2da0aaf1c9968c687 commit 6db590fb7126cbf0c9a606b2da0aaf1c9968c687 Author: kraush <kraush@amazon.com> Date: Wed Jun 29 02:30:35 2016 Increase timeout in WebappActivityTestBase.waitUntilIdle This change increases the timeout in WebappActivityTestBase.waitUntilIdle and re-enables one test that was failing on M testers due to a too short timeout. BUG= 614338 Review-Url: https://codereview.chromium.org/2108913002 Cr-Commit-Position: refs/heads/master@{#402678} [modify] https://crrev.com/6db590fb7126cbf0c9a606b2da0aaf1c9968c687/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappActivityTestBase.java [modify] https://crrev.com/6db590fb7126cbf0c9a606b2da0aaf1c9968c687/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappUrlBarTest.java
,
Jun 29 2016
Hopefully fixed by kraush's patch. Thanks! Can reopen this if it starts flaking again. |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, May 24 2016