New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 614317 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Unwanted scrollbar is seen in Task Manager

Project Member Reported by sc00335...@techmahindra.com, May 24 2016

Issue description

Version: 52.0.2743.3 dev
OS: Ubuntu 14.04

What steps will reproduce the problem?
(1) Launch chrome >> Make sure you have less number of tasks running >> Open task manager and observe vertical scrollbar 

Expected: No scrollbar should be seen when there are less number of tasks present.
Actual: Instead unwanted scrollbar is seen.

This is a regression issue broken in M52. Issue is not seen in windows.

Manual Bisect:
Good Build: 52.0.2740.0 dev
Bad Build: 52.0.2741.0 dev

Tool Bisect:
CHANGELOG URL:
 https://chromium.googlesource.com/chromium/src/+log/3fe3c9880734a233958d7d68750d785daa439835..6c167254182506e10fe2fa9fa24d233da620b204

Suspecting  https://codereview.chromium.org/1982303003 from changelog

@estade: Please help in re-assigning if it is not related to your change.

 
Expected_taskmanagerscrollbar.ogv
482 KB Download
Actual_scrollbar.png
135 KB View Download
Expected_scrollbar.png
142 KB View Download
Able to reproduce the issue on Ubuntu 14.04 using chrome latest Dev M52-52.0.2743.3. Observed unwanted scrollbar in the task manager when less number of tasks present.

Comment 2 by est...@chromium.org, May 24 2016

Labels: -Pri-1 -M-52 M-53 Pri-2
I can't reproduce. Does this happen for you with a fresh profile?

I'm not sure why this is happening, it might be that the WM is remembering the last size for this window. The process titles are absurdly narrow here. If this is only a problem on Linux, it's lower priority.

Comment 3 by nick@chromium.org, May 31 2016

Cc: afakhry@chromium.org
I think I've seen this on Windows too, in the context of browsertests at least: opening the task manager during a test results in too-small windows, and the "Tasks" column never seems wide enough. I tend to forget about it, since the window size is persisted as a preference, so I don't encounter it on my main profile.
Sorry for the late response to comment #2:

Checked the issue on 53.0.2761.2 dev, Ubuntu 14.04 by creating a fresh profile. Issue is still reproducible. i.e; Unwanted vertical scroll bar is seen even when there are less number of tasks.

Attaching screen shot of same.
Issue_614317.png
133 KB View Download
Labels: M-54
Labels: -M-53
punting
Status: Fixed (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc9948e8ed03ea9230047ced2e8167afb873c7a4

commit cc9948e8ed03ea9230047ced2e8167afb873c7a4
Author: thestig <thestig@chromium.org>
Date: Wed Oct 05 00:40:45 2016

Revert of Fix task manager's default sizing. (patchset #6 id:100001 of https://codereview.chromium.org/2344703002/ )

Reason for revert:
On Linux, the task manager window self expands and gets wider and wiser.

Original issue's description:
> Fix task manager's default sizing.
>
> Set default width based on contents rather than hardcoding a value (which happened to be too small once we adjusted outer padding for the dialog).
>
> BUG= 614317 
>
> Committed: https://crrev.com/6678470d3169979d811eec56e7cdea668ab751c1
> Cr-Commit-Position: refs/heads/master@{#422893}

TBR=sky@chromium.org,estade@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 614317 

Review-Url: https://codereview.chromium.org/2389803006
Cr-Commit-Position: refs/heads/master@{#423023}

[modify] https://crrev.com/cc9948e8ed03ea9230047ced2e8167afb873c7a4/chrome/browser/ui/views/task_manager_view.cc
[modify] https://crrev.com/cc9948e8ed03ea9230047ced2e8167afb873c7a4/chrome/browser/ui/views/task_manager_view.h
[modify] https://crrev.com/cc9948e8ed03ea9230047ced2e8167afb873c7a4/ui/views/controls/scroll_view.cc
[modify] https://crrev.com/cc9948e8ed03ea9230047ced2e8167afb873c7a4/ui/views/controls/table/table_view.cc
[modify] https://crrev.com/cc9948e8ed03ea9230047ced2e8167afb873c7a4/ui/views/controls/table/table_view.h

Sign in to add a comment