[css-grid] Disallow repeat() in grid-template shorthand |
||
Issue descriptionAs discussed on www-style, "repeat()" notation shouldn't be allowed in the ASCII branch of the grid-template shorthand. See: https://lists.w3.org/Archives/Public/www-style/2016May/0193.html Hopefully the syntax would be updated soon and avoid the use of <track-list>: https://drafts.csswg.org/css-grid/#grid-template-ascii For example the following declaration should be invalid: grid-template: "a b" / repeat(2, 100px); BTW, this is related to a TODO we've in Source/core/css/parser/CSSPropertyParser.cpp: // TODO(rob.buis): This needs a bool parameter so we can disallow <auto-track-list> for the grid shorthand.
,
Jun 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9a6a6f02b663a4066fe26d9d57809faeaaa8ee6a commit 9a6a6f02b663a4066fe26d9d57809faeaaa8ee6a Author: rego <rego@igalia.com> Date: Tue Jun 28 09:07:40 2016 [css-grid] Disallow repeat() in grid-template shorthand As discussed on www-style, "repeat()" notation shouldn't be allowed in the ASCII branch of the grid-template shorthand. https://lists.w3.org/Archives/Public/www-style/2016May/0193.html The patch adds a boolean in consumeGridTrackList() to invalidate "repeat()" when parsing grid-template shorthand. BUG= 614314 TEST=fast/css-grid-layout/grid-template-shorthand-get-set.html Review-Url: https://codereview.chromium.org/2002063004 Cr-Commit-Position: refs/heads/master@{#402429} [modify] https://crrev.com/9a6a6f02b663a4066fe26d9d57809faeaaa8ee6a/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-template-shorthand-get-set-expected.txt [modify] https://crrev.com/9a6a6f02b663a4066fe26d9d57809faeaaa8ee6a/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-template-shorthand-get-set.html [modify] https://crrev.com/9a6a6f02b663a4066fe26d9d57809faeaaa8ee6a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp
,
Jun 28 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by r...@igalia.com
, Jun 28 2016