Bisect showed that this CL (https://codereview.chromium.org/1987053002) causes the failures. I will revert the CL.

RenderViewImplTest.NavigationStartOverride (run #1):
[ RUN      ] RenderViewImplTest.NavigationStartOverride
[4815:4815:0523/190516:14711026715:WARNING:resource_bundle.cc(319)] locale_file_path.empty() for locale
/b/build/slave/Linux_Builder__dbg_/build/src/out/Debug/../../build/linux/debian_wheezy_amd64-sysroot/usr/lib/gcc/x86_64-linux-g320:
    error: attempt to subscript container with out-of-bounds index 0, but
    container only holds 0 elements.

Objects involved in the operation:
sequence "this" @ 0x0x1c5029777c88 {
}
Received signal 6
#0 0x7f25b4fb852e base::debug::StackTrace::StackTrace()
#1 0x7f25b4fb806f base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7f25a2cedcb0 <unknown>
#3 0x7f25a29550d5 gsignal
#4 0x7f25a295883b abort
#5 0x7f25a31735ad __gnu_debug::_Error_formatter::_M_error()
#6 0x7f25b12ffecc std::__debug::vector<>::operator[]()
#7 0x7f25b16eb3b4 storage::DataElement::bytes()
#8 0x7f25b16e6da5 content::(anonymous namespace)::WriteHttpBody()
#9 0x7f25b16e688d content::(anonymous namespace)::WriteFrameState()
#10 0x7f25b16e4cbe content::(anonymous namespace)::WritePageState()
#11 0x7f25b16e4be0 content::EncodePageState()
#12 0x7f25b328e516 content::HistoryEntryToPageState()
#13 0x7f25b339a9ed content::RenderFrameImpl::SendDidCommitProvisionalLoad()
#14 0x7f25b3399e86 content::RenderFrameImpl::didCommitProvisionalLoad()
#15 0x7f25ac502a45 blink::FrameLoaderClientImpl::dispatchDidCommitLoad()
#16 0x7f25aa7215e0 blink::FrameLoader::receivedFirstData()
#17 0x7f25aa705c7a blink::DocumentLoader::createWriterFor()
#18 0x7f25aa7059bb blink::DocumentLoader::ensureWriter()
#19 0x7f25aa704524 blink::DocumentLoader::commitData()
#20 0x7f25aa706073 blink::DocumentLoader::processData()
#21 0x7f25aa705f12 blink::DocumentLoader::dataReceived()
#22 0x7f25aa501564 blink::RawResource::appendData()
#23 0x7f25aa52a93f blink::ResourceLoader::didReceiveData()
#24 0x7f25b14a21c4 content::WebURLLoaderImpl::Context::OnReceivedData()
#25 0x7f25b14a2b4d content::WebURLLoaderImpl::Context::HandleDataURL()
#26 0x7f25b14a5a91 content::WebURLLoaderImpl::Context::HandleDataURLTask::run()
#27 0x7f25b7489f0e scheduler::WebTaskRunnerImpl::runTask()
#28 0x7f25b748af6a _ZN4base8internal15RunnableAdapterIPFvSt10unique_ptrIN5blink13WebTaskRunner4TaskESt14default_deleteIS5_EEEE3RunIJS8_EEEvDpOT_
#29 0x7f25b748aed5 _ZN4base8internal12InvokeHelperILb0EvNS0_15RunnableAdapterIPFvSt10unique_ptrIN5blink13WebTaskRunner4TaskESt14default_deleteIS6_EEEEEE8MakeItSoIJS9_EEEvSC_DpOT_
#30 0x7f25b748ae96 _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0EEEENS0_9BindStateINS0_15RunnableAdapterIPFvSt10unique_ptrIN5blink13WebTaskRunner4TaskESt14default_deleteIS9_EEEEESD_JNS0_13PassedWrapperISC_EEEEENS0_12InvokeHelperILb0EvSF_EEFvvEE3RunEPNS0_13BindStateBaseE
#31 0x7f25b4f9896e base::Callback<>::Run()
#32 0x7f25b4fbe00e base::debug::TaskAnnotator::RunTask()
#33 0x7f25b7461fb4 scheduler::TaskQueueManager::ProcessTaskFromWorkQueue()
#34 0x7f25b745fef2 scheduler::TaskQueueManager::DoWork()
#35 0x7f25b7467439 _ZN4base8internal15RunnableAdapterIMN9scheduler16TaskQueueManagerEFvNS_9TimeTicksEbEE3RunIPS3_JRKS4_RKbEEEvOT_DpOT0_
#36 0x7f25b746732a _ZN4base8internal12InvokeHelperILb1EvNS0_15RunnableAdapterIMN9scheduler16TaskQueueManagerEFvNS_9TimeTicksEbEEEE8MakeItSoINS_7WeakPtrIS4_EEJRKS5_RKbEEEvS8_T_DpOT0_
#37 0x7f25b74672a8 _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0ELm1ELm2EEEENS0_9BindStateINS0_15RunnableAdapterIMN9scheduler16TaskQueueManagerEFvNS_9TimeTicksEbEEEFvPS7_S8_bEJNS_7WeakPtrIS7_EERS8_bEEENS0_12InvokeHelperILb1EvSB_EEFvvEE3RunEPNS0_13BindStateBaseE
#38 0x7f25b4f9896e base::Callback<>::Run()
#39 0x7f25b4fbe00e base::debug::TaskAnnotator::RunTask()
#40 0x7f25b5038afc base::MessageLoop::RunTask()
#41 0x7f25b5038d98 base::MessageLoop::DeferOrRunPendingTask()
#42 0x7f25b5038ff2 base::MessageLoop::DoWork()
#43 0x7f25b504fd83 base::MessagePumpDefault::Run()
#44 0x7f25b50384ef base::MessageLoop::RunHandler()
#45 0x7f25b50e11a4 base::RunLoop::Run()
#46 0x7f25b5037564 base::MessageLoop::Run()
#47 0x000000b57f19 content::RenderViewTest::ProcessPendingMessages()
#48 0x000000988bbb content::RenderViewImplTest_NavigationStartOverride_Test::TestBody()
#49 0x000000c261ca _ZN7testing8internal12InvokeHelperIvNSt3tr15tupleIJEEEE12InvokeMethodIN5media26MockVideoDecodeAcceleratorEMS8_FvvEEEvPT_T0_RKS4_
#50 0x000001bcf9ae testing::internal::HandleExceptionsInMethodIfSupported<>()
#51 0x000001bc48d5 testing::Test::Run()
#52 0x000001bc5068 testing::TestInfo::Run()
#53 0x000001bc560a testing::TestCase::Run()
#54 0x000001bca95c testing::internal::UnitTestImpl::RunAllTests()
#55 0x000001be29da testing::internal::HandleSehExceptionsInMethodIfSupported<>()
#56 0x000001bd10ae testing::internal::HandleExceptionsInMethodIfSupported<>()
#57 0x000001bca5ff testing::UnitTest::Run()
#58 0x000000a7b441 RUN_ALL_TESTS()
#59 0x000000a7a478 base::TestSuite::Run()
#60 0x000000a512bc content::ContentTestLauncherDelegate::RunTestSuite()
#61 0x000000b7e312 content::LaunchTests()
  r8: 00007f259bc1a980  r9: 00007ffdb263a7a8 r10: 0000000000000008 r11: 0000000000000206
 r12: 00007ffdb263aad0 r13: 0000000000000002 r14: 0000000000000001 r15: 0000000000000000
  di: 00000000000012cf  si: 00000000000012cf  bp: 0000000000000003  bx: 00007ffdb263aa28
  dx: 0000000000000006  ax: 0000000000000000  cx: ffffffffffffffff  sp: 00007ffdb263a7f8
  ip: 00007f25a29550d5 efl: 0000000000000206 cgf: 0000000000000033 erf: 0000000000000000
 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000
[end of stack trace]

PasswordManagerBrowserTestBase.AutofillSuggestionsForLoginSignupForm (run #1):
[ RUN      ] PasswordManagerBrowserTestBase.AutofillSuggestionsForLoginSignupForm
[1:1:0523/185952:ERROR:memory_mapped_file.cc(52)] Couldn't open /tmp/run3RDCpP/out/Debug/chrome_material_100_percent.pak
[1:1:0523/185952:ERROR:data_pack.cc(80)] Failed to mmap datapack
[1:1:0523/185952:ERROR:resource_bundle.cc(754)] Failed to load /tmp/run3RDCpP/out/Debug/chrome_material_100_percent.pak
Some features may not be available.
[1:1:0523/185952:ERROR:memory_mapped_file.cc(52)] Couldn't open /tmp/run3RDCpP/out/Debug/chrome_material_200_percent.pak
[1:1:0523/185952:ERROR:data_pack.cc(80)] Failed to mmap datapack
Xlib:  extension "RANDR" missing on display ":9".
[4199:4199:0523/185952:ERROR:memory_mapped_file.cc(52)] Couldn't open /tmp/run3RDCpP/out/Debug/chrome_material_100_percent.pak
[4199:4199:0523/185952:ERROR:data_pack.cc(80)] Failed to mmap datapack
[4199:4199:0523/185952:ERROR:resource_bundle.cc(754)] Failed to load /tmp/run3RDCpP/out/Debug/chrome_material_100_percent.pak
Some features may not be available.
[4199:4199:0523/185952:ERROR:memory_mapped_file.cc(52)] Couldn't open /tmp/run3RDCpP/out/Debug/chrome_material_200_percent.pak
[4199:4199:0523/185952:ERROR:data_pack.cc(80)] Failed to mmap datapack
Xlib:  extension "RANDR" missing on display ":9".
[4199:4199:0523/185952:WARNING:audio_manager.cc(297)] Multiple instances of AudioManager detected
[4199:4199:0523/185952:WARNING:audio_manager.cc(271)] Multiple instances of AudioManager detected
[4199:4199:0523/185952:WARNING:password_store_factory.cc(250)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
[4199:4338:0523/185953:WARNING:simple_synchronous_entry.cc(1052)] Could not open platform files for entry.
[4199:4326:0523/185954:WARNING:embedded_test_server.cc(193)] Request not handled. Returning 404: /favicon.ico
/b/build/slave/Linux_Builder__dbg_/build/src/out/Debug/../../build/linux/debian_wheezy_amd64-sysroot/usr/lib/gcc/x86_64-linux-g320:
    error: attempt to subscript container with out-of-bounds index 0, but
    container only holds 0 elements.

Objects involved in the operation:
sequence "this" @ 0x0x117750b0ec8 {
}
Received signal 6
#0 0x7fbdcd9d952e base::debug::StackTrace::StackTrace()
#1 0x7fbdcd9d906f base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7fbdb85e6cb0 <unknown>
#3 0x7fbdb55d10d5 gsignal
#4 0x7fbdb55d483b abort
#5 0x7fbdb5bd25ad __gnu_debug::_Error_formatter::_M_error()
#6 0x7fbdc4e76ecc std::__debug::vector<>::operator[]()
#7 0x7fbdc52623b4 storage::DataElement::bytes()
#8 0x7fbdc525dda5 content::(anonymous namespace)::WriteHttpBody()
#9 0x7fbdc525d88d content::(anonymous namespace)::WriteFrameState()
#10 0x7fbdc525bcbe content::(anonymous namespace)::WritePageState()
#11 0x7fbdc525bbe0 content::EncodePageState()
#12 0x7fbdc6e05516 content::HistoryEntryToPageState()
#13 0x7fbdc6f119ed content::RenderFrameImpl::SendDidCommitProvisionalLoad()
#14 0x7fbdc6f10e86 content::RenderFrameImpl::didCommitProvisionalLoad()
#15 0x7fbdbfe6ea45 blink::FrameLoaderClientImpl::dispatchDidCommitLoad()
#16 0x7fbdbe2d35e0 blink::FrameLoader::receivedFirstData()
#17 0x7fbdbe2b7c7a blink::DocumentLoader::createWriterFor()
#18 0x7fbdbe2b79bb blink::DocumentLoader::ensureWriter()
#19 0x7fbdbe2b6524 blink::DocumentLoader::commitData()
#20 0x7fbdbe2b8073 blink::DocumentLoader::processData()
#21 0x7fbdbe2b7f12 blink::DocumentLoader::dataReceived()
#22 0x7fbdbe0b3564 blink::RawResource::appendData()
#23 0x7fbdbe0dc93f blink::ResourceLoader::didReceiveData()
#24 0x7fbdc50191c4 content::WebURLLoaderImpl::Context::OnReceivedData()
#25 0x7fbdc5019db3 content::WebURLLoaderImpl::RequestPeerImpl::OnReceivedData()
#26 0x7fbdc4fb3741 content::ResourceDispatcher::OnReceivedData()
#27 0x7fbdc4fbd544 _ZN4base20DispatchToMethodImplIPN7content18ResourceDispatcherEMS2_FviiiiEJiiiiEJLm0ELm1ELm2ELm3EEEEvRKT_T0_RKSt5tupleIJDpT1_EENS_13IndexSequenceIJXspT2_EEEE
#28 0x7fbdc4fbd455 _ZN4base16DispatchToMethodIPN7content18ResourceDispatcherEMS2_FviiiiEJiiiiEEEvRKT_T0_RKSt5tupleIJDpT1_EE
#29 0x7fbdc4fbd37f _ZN3IPC16DispatchToMethodIN7content18ResourceDispatcherEMS2_FviiiiEvSt5tupleIJiiiiEEEEvPT_T0_PT1_RKT2_
#30 0x7fbdc4fb861b _ZN3IPC8MessageTI29ResourceMsg_DataReceived_MetaSt5tupleIJiiiiEEvE8DispatchIN7content18ResourceDispatcherES7_vMS7_FviiiiEEEbPKNS_7MessageEPT_PT0_PT1_T2_
#31 0x7fbdc4fb17e1 content::ResourceDispatcher::DispatchMessage()
#32 0x7fbdc4fb0ca9 content::ResourceDispatcher::OnMessageReceived()
#33 0x7fbdc4fbfa35 content::ResourceSchedulingFilter::DispatchMessage()
#34 0x7fbdc4fbfcba content::(anonymous namespace)::DispatchMessageTask::run()
#35 0x7fbdbb845f0e scheduler::WebTaskRunnerImpl::runTask()
#36 0x7fbdbb846f6a _ZN4base8internal15RunnableAdapterIPFvSt10unique_ptrIN5blink13WebTaskRunner4TaskESt14default_deleteIS5_EEEE3RunIJS8_EEEvDpOT_
#37 0x7fbdbb846ed5 _ZN4base8internal12InvokeHelperILb0EvNS0_15RunnableAdapterIPFvSt10unique_ptrIN5blink13WebTaskRunner4TaskESt14default_deleteIS6_EEEEEE8MakeItSoIJS9_EEEvSC_DpOT_
#38 0x7fbdbb846e96 _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0EEEENS0_9BindStateINS0_15RunnableAdapterIPFvSt10unique_ptrIN5blink13WebTaskRunner4TaskESt14default_deleteIS9_EEEEESD_JNS0_13PassedWrapperISC_EEEEENS0_12InvokeHelperILb0EvSF_EEFvvEE3RunEPNS0_13BindStateBaseE
#39 0x7fbdcd9b996e base::Callback<>::Run()
#40 0x7fbdcd9df00e base::debug::TaskAnnotator::RunTask()
#41 0x7fbdbb81dfb4 scheduler::TaskQueueManager::ProcessTaskFromWorkQueue()
#42 0x7fbdbb81bef2 scheduler::TaskQueueManager::DoWork()
#43 0x7fbdbb823439 _ZN4base8internal15RunnableAdapterIMN9scheduler16TaskQueueManagerEFvNS_9TimeTicksEbEE3RunIPS3_JRKS4_RKbEEEvOT_DpOT0_
#44 0x7fbdbb82332a _ZN4base8internal12InvokeHelperILb1EvNS0_15RunnableAdapterIMN9scheduler16TaskQueueManagerEFvNS_9TimeTicksEbEEEE8MakeItSoINS_7WeakPtrIS4_EEJRKS5_RKbEEEvS8_T_DpOT0_
#45 0x7fbdbb8232a8 _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0ELm1ELm2EEEENS0_9BindStateINS0_15RunnableAdapterIMN9scheduler16TaskQueueManagerEFvNS_9TimeTicksEbEEEFvPS7_S8_bEJNS_7WeakPtrIS7_EERS8_bEEENS0_12InvokeHelperILb1EvSB_EEFvvEE3RunEPNS0_13BindStateBaseE
#46 0x7fbdcd9b996e base::Callback<>::Run()
#47 0x7fbdcd9df00e base::debug::TaskAnnotator::RunTask()
#48 0x7fbdcda59afc base::MessageLoop::RunTask()
#49 0x7fbdcda59d98 base::MessageLoop::DeferOrRunPendingTask()
#50 0x7fbdcda59ff2 base::MessageLoop::DoWork()
#51 0x7fbdcda70d83 base::MessagePumpDefault::Run()
#52 0x7fbdcda594ef base::MessageLoop::RunHandler()
#53 0x7fbdcdb021a4 base::RunLoop::Run()
#54 0x7fbdcda58564 base::MessageLoop::Run()
#55 0x7fbdc6fc7183 content::RendererMain()
#56 0x7fbdc73a94ae content::RunZygote()
#57 0x7fbdc73a9af0 content::RunNamedProcessTypeMain()
#58 0x7fbdc73abd42 content::ContentMainRunnerImpl::Run()
#59 0x7fbdc73a8b52 content::ContentMain()
#60 0x00000515105e content::LaunchTests()
#61 0x000001620c89 LaunchChromeTests()
  r8: 00007fbdb044a9c0  r9: 00007ffee0bfaf78 r10: 0000000000000008 r11: 0000000000000202
 r12: 00007ffee0bfb2a0 r13: 0000000000000002 r14: 0000000000000001 r15: 0000000000000000
  di: 0000000000000001  si: 0000000000000001  bp: 0000000000000003  bx: 00007ffee0bfb1f8
  dx: 0000000000000006  ax: 0000000000000000  cx: ffffffffffffffff  sp: 00007ffee0bfafc8
  ip: 00007fbdb55d10d5 efl: 0000000000000202 cgf: 0000000000000033 erf: 0000000000000000
 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000
[end of stack trace]
[4199:4199:0523/190023:ERROR:process_metrics_linux.cc(136)] opendir(/proc/0/task): No such file or directory
BrowserTestBase signal handler received SIGTERM. Backtrace:
#0 0x7f1dac91c52e base::debug::StackTrace::StackTrace()
#1 0x000002688fea content::(anonymous namespace)::DumpStackTraceSignalHandler()
#2 0x7f1d94514150 <unknown>
#3 0x7f1d945c59d3 __poll
#4 0x7f1d99752ff6 <unknown>
#5 0x7f1d99753124 g_main_context_iteration
#6 0x7f1dac9b490f base::MessagePumpGlib::Run()
#7 0x7f1dac99c4ef base::MessageLoop::RunHandler()
#8 0x7f1daca451a4 base::RunLoop::Run()
#9 0x00000515c783 content::RunThisRunLoop()
#10 0x00000515d117 content::MessageLoopRunner::Run()
#11 0x000005d86721 NavigationObserver::Wait()
#12 0x000005d8758b PasswordManagerBrowserTestBase::VerifyPasswordIsSavedAndFilled()
#13 0x000000eeeb95 password_manager::PasswordManagerBrowserTestBase_AutofillSuggestionsForLoginSignupForm_Test::RunTestOnMainThread()
#14 0x00000163d7f5 InProcessBrowserTest::RunTestOnMainThreadLoop()
#15 0x000002688daa content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#16 0x0000009c58cd _ZN4base8internal15RunnableAdapterIM24DevToolsBeforeUnloadTestFvvEE3RunIRK13scoped_refptrI53DevToolsBeforeUnloadTest_TestDockedDevToolsClose_TestEJEEEvOT_DpOT0_
#17 0x000002689fe9 _ZN4base8internal12InvokeHelperILb0EvNS0_15RunnableAdapterIMN7content15BrowserTestBaseEFvvEEEE8MakeItSoIJRK13scoped_refptrIS4_EEEEvS7_DpOT_
#18 0x000002689fb0 _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0EEEENS0_9BindStateINS0_15RunnableAdapterIMN7content15BrowserTestBaseEFvvEEEFvPS7_EJSB_EEENS0_12InvokeHelperILb0EvSA_EEFvvEE3RunEPNS0_13BindStateBaseE
#19 0x00000087b71e base::Callback<>::Run()
#20 0x000001783016 ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#21 0x000001781a88 ChromeBrowserMainParts::PreMainMessageLoopRun()
#22 0x7f1da469e9c4 content::BrowserMainLoop::PreMainMessageLoopRun()
#23 0x7f1da3d931d0 _ZN4base8internal15RunnableAdapterIMN7content17GpuWatchdogThreadEFvvEE3RunIPS3_JEEEvOT_DpOT0_
#24 0x7f1da46a6ae9 _ZN4base8internal12InvokeHelperILb0EiNS0_15RunnableAdapterIMN7content15BrowserMainLoopEFivEEEE8MakeItSoIJPS4_EEEiS7_DpOT_
#25 0x7f1da46a6aad _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0EEEENS0_9BindStateINS0_15RunnableAdapterIMN7content15BrowserMainLoopEFivEEEFiPS7_EJNS0_17UnretainedWrapperIS7_EEEEENS0_12InvokeHelperILb0EiSA_EEFivEE3RunEPNS0_13BindStateBaseE
#26 0x7f1da3de80ee base::Callback<>::Run()
#27 0x7f1da50b28fb content::StartupTaskRunner::RunAllTasksNow()
#28 0x7f1da469cb25 content::BrowserMainLoop::CreateStartupTasks()
#29 0x7f1da46a8acd content::BrowserMainRunnerImpl::Initialize()
#30 0x7f1da4698bbd content::BrowserMain()
#31 0x7f1da62eca96 content::RunNamedProcessTypeMain()
#32 0x7f1da62eed42 content::ContentMainRunnerImpl::Run()
#33 0x7f1da62ebb52 content::ContentMain()
#34 0x000002688af5 content::BrowserTestBase::SetUp()
#35 0x00000163c1e9 InProcessBrowserTest::SetUp()
#36 0x00000100f72a _ZN7testing8internal12InvokeHelperIvNSt3tr15tupleIJEEEE12InvokeMethodI14ServiceProcessMS7_FvvEEEvPT_T0_RKS4_
#37 0x000006030b7e testing::internal::HandleExceptionsInMethodIfSupported<>()
#38 0x000006025ae3 testing::Test::Run()
#39 0x0000060262c8 testing::TestInfo::Run()
#40 0x00000602686a testing::TestCase::Run()
#41 0x00000602bbbc testing::internal::UnitTestImpl::RunAllTests()
#42 0x00000100ed0a _ZN7testing8internal12InvokeHelperIbNSt3tr15tupleIJEEEE12InvokeMethodI20MockServiceIPCServerMS7_FbvEEEbPT_T0_RKS4_
#43 0x0000060321ae testing::internal::HandleExceptionsInMethodIfSupported<>()
#44 0x00000602b85f testing::UnitTest::Run()
#45 0x00000166ec71 RUN_ALL_TESTS()
#46 0x00000166dca8 base::TestSuite::Run()
#47 0x0000016207fc ChromeTestSuiteRunner::RunTestSuite()
#48 0x0000016208f9 ChromeTestLauncherDelegate::RunTestSuite()
#49 0x000005151002 content::LaunchTests()
#50 0x000001620c89 LaunchChromeTests()
#51 0x0000007f7164 main
#52 0x7f1d944ff76d __libc_start_main
#53 0x0000007f6ff5 <unknown>

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0e3066a44a8c30b6bf8df72efaa3dbfa8653518

commit e0e3066a44a8c30b6bf8df72efaa3dbfa8653518
Author: kolos <kolos@chromium.org>
Date: Tue May 24 08:56:04 2016

Revert of Deduplicating code performing WebHTTPBody::Element conversions. (patchset #7 id:120001 of https://codereview.chromium.org/1987053002/ )

Reason for revert:
This CL causes failures in content_browsertests and browser_tests (https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/54314
)

BUG= 614299 

Original issue's description:
> Deduplicating code performing WebHTTPBody::Element conversions.
>
> Before this CL, there were 2 separate structs in //content layer holding
> essentially the same information about parts of http body:
> ResourceRequestBody::Element and ExplodedHttpBodyElement.
>
> To deal with 2 separate structs, recent CLs had to introduce duplicated,
> copy & pasted code that performed conversions between WebHTTPBody::Element
> from the Blink layer and the 2 structs in the //content layer.
> Examples:
>
> 1. https://crrev.com/1956383003:
>    1.a. AddHTTPBodyToRequest in //content/renderer/render_frame_impl.cc
>         duplicated code from //content/renderer/history_serialization.cc
>
> 2. https://crrev.com/1907443006:
>    2.a. Almost exactly the same as above, AddHTTPBodyToRequest in
>         //content/renderer/render_frame_impl.cc duplicated code from
>         //content/renderer/history_serialization.cc
>    2.b. ResourceRequestBody::AppendExplodedHTTPBodyElement in
>         //content/common/resource_request_body.cc was duplicating
>
> The current CL removes the duplicated code by making
> ExplodedHttpBodyElement a type alias for ResourceRequestBody::Element
> and removing code that dealt with the old ExplodedHttpBodyElement
> struct.
>
> BUG= 582211 
>
> Committed: https://crrev.com/2d0c9ae694afcb5c16028222e206b64aaba0cdba
> Cr-Commit-Position: refs/heads/master@{#395461}

TBR=creis@chromium.org,lukasza@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 582211 

Review-Url: https://codereview.chromium.org/2002413002
Cr-Commit-Position: refs/heads/master@{#395548}

[modify] https://crrev.com/e0e3066a44a8c30b6bf8df72efaa3dbfa8653518/content/common/page_state_serialization.cc
[modify] https://crrev.com/e0e3066a44a8c30b6bf8df72efaa3dbfa8653518/content/common/page_state_serialization.h
[modify] https://crrev.com/e0e3066a44a8c30b6bf8df72efaa3dbfa8653518/content/common/page_state_serialization_unittest.cc
[modify] https://crrev.com/e0e3066a44a8c30b6bf8df72efaa3dbfa8653518/content/common/resource_request_body.cc
[modify] https://crrev.com/e0e3066a44a8c30b6bf8df72efaa3dbfa8653518/content/common/resource_request_body.h
[modify] https://crrev.com/e0e3066a44a8c30b6bf8df72efaa3dbfa8653518/content/content_renderer.gypi
[modify] https://crrev.com/e0e3066a44a8c30b6bf8df72efaa3dbfa8653518/content/public/common/page_state.cc
[modify] https://crrev.com/e0e3066a44a8c30b6bf8df72efaa3dbfa8653518/content/renderer/history_serialization.cc
[delete] https://crrev.com/b0423799d4c45060338e6d7ac6db3a284f238aac/content/renderer/http_body_conversions.cc
[delete] https://crrev.com/b0423799d4c45060338e6d7ac6db3a284f238aac/content/renderer/http_body_conversions.h
[modify] https://crrev.com/e0e3066a44a8c30b6bf8df72efaa3dbfa8653518/content/renderer/render_frame_impl.cc

Failures were fixed.

The CL also caused failures of webkit tests (https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/7440)

webkit_tests webkit_tests 
unexpected_failures:
fast/forms/document-write.html
http/tests/security/originHeader/origin-header-for-post.html
fast/loader/form-submission-after-beforeunload-cancel.html
http/tests/history/post-replace-state-reload.html
virtual/trustedeventsdefaultaction/fast/events/popup-allowed-from-gesture-initiated-form-submit.html
http/tests/security/originHeader/origin-header-for-data.html
http/tests/security/originHeader/origin-header-for-empty.html
fast/loader/submit-form-while-parsing-2.html
fast/loader/submit-form-while-parsing-1.xhtml
http/tests/misc/form-target-iframe-inline.html
http/tests/misc/form-action-using-replaceChild.html
http/tests/navigation/dynamic-iframe-dynamic-form-back-entry.html
http/tests/security/cookies/third-party-cookie-blocking-user-action.html
fast/forms/xss-auditor-doesnt-crash-on-post-submit.html
fast/events/popup-allowed-from-gesture-initiated-form-submit.html
fast/history/form-submit-in-frame-via-onclick.html
http/tests/security/cookies/third-party-cookie-blocking-main-frame.html
http/tests/misc/form-target-iframe-location-change.html
fast/loader/form-submit-aborts-parsing.html
fast/loader/form-submission-before-load-post.html
fast/forms/multiple-form-submission-protection-mouse.html
http/tests/security/originHeader/origin-header-for-https.html
fast/history/form-submit-in-frame.html
http/tests/history/replacestate-post-to-get-2.html
http/tests/navigation/location-reload-after-post.php
http/tests/cookies/same-site/popup-same-site-post.html
http/tests/navigation/form-submit-from-opened-window.html
http/tests/misc/char-encoding-without-charset-field.html
fast/forms/button-state-restore.html
virtual/pointerevent/fast/events/popup-allowed-from-gesture-initiated-form-submit.html
http/tests/misc/form-base-target-blank.html
http/tests/security/cookies/third-party-cookie-blocking.html
http/tests/history/replacestate-post-to-get.html
http/tests/navigation/parsed-iframe-dynamic-form-back-entry-user-gesture.html
http/tests/cookies/same-site/popup-cross-site-post.html
http/tests/navigation/parsed-iframe-dynamic-form-back-entry.html

Thanks for catching and fixing this.  This has indeed been caused by my CL - I can repro the crash on a debug Linux build with
$ content_browsertests --gtest_filter=*RenderViewImplTest.NavigationStartOverride*

I guess CQ has passed, because it doesn't have dbg coverage?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28b27bcc839a67e8a44a18536cd587fd0746ee40

commit 28b27bcc839a67e8a44a18536cd587fd0746ee40
Author: lukasza <lukasza@chromium.org>
Date: Wed May 25 23:45:31 2016

Relanding: Deduplicating code performing WebHTTPBody::Element conversions.

Before this CL, there were 2 separate structs in //content layer holding
essentially the same information about parts of http body:
ResourceRequestBody::Element and ExplodedHttpBodyElement.

To deal with 2 separate structs, recent CLs had to introduce duplicated,
copy & pasted code that performed conversions between WebHTTPBody::Element
from the Blink layer and the 2 structs in the //content layer.
Examples:

1. https://crrev.com/1956383003:
   1.a. AddHTTPBodyToRequest in //content/renderer/render_frame_impl.cc
        duplicated code from //content/renderer/history_serialization.cc

2. https://crrev.com/1907443006:
   2.a. Almost exactly the same as above, AddHTTPBodyToRequest in
        //content/renderer/render_frame_impl.cc duplicated code from
        //content/renderer/history_serialization.cc
   2.b. ResourceRequestBody::AppendExplodedHTTPBodyElement in
        //content/common/resource_request_body.cc was duplicating

The current CL removes the duplicated code by making
ExplodedHttpBodyElement a type alias for ResourceRequestBody::Element
and removing code that dealt with the old ExplodedHttpBodyElement
struct.

BUG= 582211 ,  614299 

Review-Url: https://codereview.chromium.org/2006053004
Cr-Commit-Position: refs/heads/master@{#396043}

[modify] https://crrev.com/28b27bcc839a67e8a44a18536cd587fd0746ee40/content/common/page_state_serialization.cc
[modify] https://crrev.com/28b27bcc839a67e8a44a18536cd587fd0746ee40/content/common/page_state_serialization.h
[modify] https://crrev.com/28b27bcc839a67e8a44a18536cd587fd0746ee40/content/common/page_state_serialization_unittest.cc
[modify] https://crrev.com/28b27bcc839a67e8a44a18536cd587fd0746ee40/content/common/resource_request_body.cc
[modify] https://crrev.com/28b27bcc839a67e8a44a18536cd587fd0746ee40/content/common/resource_request_body.h
[modify] https://crrev.com/28b27bcc839a67e8a44a18536cd587fd0746ee40/content/content_renderer.gypi
[modify] https://crrev.com/28b27bcc839a67e8a44a18536cd587fd0746ee40/content/public/common/page_state.cc
[modify] https://crrev.com/28b27bcc839a67e8a44a18536cd587fd0746ee40/content/renderer/history_serialization.cc
[add] https://crrev.com/28b27bcc839a67e8a44a18536cd587fd0746ee40/content/renderer/http_body_conversions.cc
[add] https://crrev.com/28b27bcc839a67e8a44a18536cd587fd0746ee40/content/renderer/http_body_conversions.h
[modify] https://crrev.com/28b27bcc839a67e8a44a18536cd587fd0746ee40/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/28b27bcc839a67e8a44a18536cd587fd0746ee40/storage/common/data_element.h