Issue metadata
Sign in to add a comment
|
Regression:Scrollbar arrows are not seen properly in "msrtconline.in/timetable.aspx"
Reported by
adha...@etouch.net,
May 24 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version:52.0.2743.3 (Official Build) 8be70850ebcd3ec9433ba7606521c44009e96655-refs/branch-heads/2743@{#23}(32/64-bit) OS:Windows (7, 8, 10) URL:http://msrtconline.in/timetable.aspx What steps will reproduce the problem? (1)Launch chrome and navigate to the above url. (2)Observe the vertical scroll bar arrows under the 'Time table' option. Actual:Scroll bar arrows are not seen properly. Expected:Arrow buttons should be seen properly. This is a Regression issue broken in M-52,below is the Narrow bisect info: https://chromium.googlesource.com/chromium/src/+log/1e8f9f8618215d4b27cac8b76465dcee57defe01..b36c784041e2dd9cd8d953b41dcd997d5be51dae?pretty=fuller&n=10000 Suspecting:r394893? Good build:52.0.2742.0 Bad build:52.0.2743.0 Kindly help to re-assign if your change is not the cause for this issue. Note:Above issue is not reproducible on Linux and Mac OS.
,
May 24 2016
Issue 613934 has been merged into this issue.
,
May 25 2016
I'm going on vacation now but I have a CL written and ready to go when I get back. It's a fairly complex change so I don't want to try to force it through today.
,
Jun 3 2016
M52 Stable is approaching soon. Please let us know the ETA.
,
Jun 6 2016
I'm back from vacation. I'll work on this first thing. I expect it'll take at least a few days to get through review.
,
Jun 7 2016
,
Jun 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/91cbc6d7c2f02771ee3640a4b2f3376029b3bab0 commit 91cbc6d7c2f02771ee3640a4b2f3376029b3bab0 Author: bsep <bsep@chromium.org> Date: Tue Jun 14 00:51:51 2016 Draw nicer arrows when the scrollbar buttons are not square. Before they would look squished or messed up, but with this patch their bounding box is always square so we'll get the nice pixel pyramids that we want. This shouldn't change anything visually for the normal square scrollbar buttons. BUG= 614297 Review-Url: https://codereview.chromium.org/2009733002 Cr-Commit-Position: refs/heads/master@{#399626} [modify] https://crrev.com/91cbc6d7c2f02771ee3640a4b2f3376029b3bab0/ui/native_theme/BUILD.gn [modify] https://crrev.com/91cbc6d7c2f02771ee3640a4b2f3376029b3bab0/ui/native_theme/native_theme_aura_unittest.cc [modify] https://crrev.com/91cbc6d7c2f02771ee3640a4b2f3376029b3bab0/ui/native_theme/native_theme_base.cc [modify] https://crrev.com/91cbc6d7c2f02771ee3640a4b2f3376029b3bab0/ui/native_theme/native_theme_base.h
,
Jun 14 2016
,
Jun 14 2016
,
Jun 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/46eb95ac9591f50c07cd234171cb07e26320ac7a commit 46eb95ac9591f50c07cd234171cb07e26320ac7a Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Tue Jun 14 17:09:57 2016 Sheriffing: disable three failing tests fast/forms/select/listbox-appearance-basic.html fast/forms/number/number-appearance-spinbutton-disabled-readonly.html fast/forms/select/menulist-appearance-basic.html BUG= 614297 TBR=bsep,hcarmona Review URL: https://codereview.chromium.org/2059403004 . Cr-Commit-Position: refs/heads/master@{#399732} [modify] https://crrev.com/46eb95ac9591f50c07cd234171cb07e26320ac7a/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/91cbc6d7c2f02771ee3640a4b2f3376029b3bab0 commit 91cbc6d7c2f02771ee3640a4b2f3376029b3bab0 Author: bsep <bsep@chromium.org> Date: Tue Jun 14 00:51:51 2016 Draw nicer arrows when the scrollbar buttons are not square. Before they would look squished or messed up, but with this patch their bounding box is always square so we'll get the nice pixel pyramids that we want. This shouldn't change anything visually for the normal square scrollbar buttons. BUG= 614297 Review-Url: https://codereview.chromium.org/2009733002 Cr-Commit-Position: refs/heads/master@{#399626} [modify] https://crrev.com/91cbc6d7c2f02771ee3640a4b2f3376029b3bab0/ui/native_theme/BUILD.gn [modify] https://crrev.com/91cbc6d7c2f02771ee3640a4b2f3376029b3bab0/ui/native_theme/native_theme_aura_unittest.cc [modify] https://crrev.com/91cbc6d7c2f02771ee3640a4b2f3376029b3bab0/ui/native_theme/native_theme_base.cc [modify] https://crrev.com/91cbc6d7c2f02771ee3640a4b2f3376029b3bab0/ui/native_theme/native_theme_base.h
,
Jun 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/46eb95ac9591f50c07cd234171cb07e26320ac7a commit 46eb95ac9591f50c07cd234171cb07e26320ac7a Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Tue Jun 14 17:09:57 2016 Sheriffing: disable three failing tests fast/forms/select/listbox-appearance-basic.html fast/forms/number/number-appearance-spinbutton-disabled-readonly.html fast/forms/select/menulist-appearance-basic.html BUG= 614297 TBR=bsep,hcarmona Review URL: https://codereview.chromium.org/2059403004 . Cr-Commit-Position: refs/heads/master@{#399732} [modify] https://crrev.com/46eb95ac9591f50c07cd234171cb07e26320ac7a/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 15 2016
Tested the same on win8.1,Linux 14.04 chrome version 53.0.2768.0 as per the steps in Issue 613934 since the URL http://msrtconline.in/timetable.aspx displays an error - Arrows are clear as shown in the screenshot Fix works as expected
,
Jun 15 2016
[Automated comment] There appears to be on-going work (i.e. bugroid changes), needs manual review.
,
Jun 16 2016
Approving merge to M52 branch 2743 based on comment #13. Please merge asap. Thank you.
,
Jun 16 2016
A friendly reminder that M52 Stable is launching soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch by July 12. All changes MUST be merged into the release branch by 5pm on July 15 to make into the desktop Stable final build cut. Thank you!
,
Jun 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cf604e6b3f7b8c67b3c1d0c7dbe83a3c174fd21e commit cf604e6b3f7b8c67b3c1d0c7dbe83a3c174fd21e Author: Bret Sepulveda <bsep@chromium.org> Date: Fri Jun 17 18:46:29 2016 Draw nicer arrows when the scrollbar buttons are not square. Before they would look squished or messed up, but with this patch their bounding box is always square so we'll get the nice pixel pyramids that we want. This shouldn't change anything visually for the normal square scrollbar buttons. BUG= 614297 Review-Url: https://codereview.chromium.org/2009733002 Cr-Commit-Position: refs/heads/master@{#399626} (cherry picked from commit 91cbc6d7c2f02771ee3640a4b2f3376029b3bab0) Review URL: https://codereview.chromium.org/2075213002 . Cr-Commit-Position: refs/branch-heads/2743@{#379} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/cf604e6b3f7b8c67b3c1d0c7dbe83a3c174fd21e/ui/native_theme/BUILD.gn [modify] https://crrev.com/cf604e6b3f7b8c67b3c1d0c7dbe83a3c174fd21e/ui/native_theme/native_theme_aura_unittest.cc [modify] https://crrev.com/cf604e6b3f7b8c67b3c1d0c7dbe83a3c174fd21e/ui/native_theme/native_theme_base.cc [modify] https://crrev.com/cf604e6b3f7b8c67b3c1d0c7dbe83a3c174fd21e/ui/native_theme/native_theme_base.h
,
Jun 17 2016
,
Jun 22 2016
Tested the issue on Win 7, Ubuntu 14.04 using 52.0.2743.49 as per the steps in Issue 613934 , working as intended. adding TE-Verified labels and attached screenshot for reference. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ashej...@chromium.org
, May 24 2016