i'm interesting this issue. i would like refactoring.

please review this commit.

https://codereview.chromium.org/2022123002/

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe5f05044f43fe5f1ef9806fc6b178992df8f615

commit fe5f05044f43fe5f1ef9806fc6b178992df8f615
Author: hs1217.lee <hs1217.lee@gmail.com>
Date: Tue Jun 07 23:17:58 2016

Refactor the naming scheme of Deserialize* functions in form_field_data.cc

This is needed for https://codereview.chromium.org/2022123002/.

BUG= 614280 

Review-Url: https://codereview.chromium.org/2044503002
Cr-Commit-Position: refs/heads/master@{#398409}

[modify] https://crrev.com/fe5f05044f43fe5f1ef9806fc6b178992df8f615/AUTHORS
[modify] https://crrev.com/fe5f05044f43fe5f1ef9806fc6b178992df8f615/components/autofill/core/common/form_field_data.cc

This is being tackled by hs1217.lee@gmail.com.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61b1d174d7dfd788dfe34cad3f8a0b9856894290

commit 61b1d174d7dfd788dfe34cad3f8a0b9856894290
Author: hs1217.lee <hs1217.lee@gmail.com>
Date: Thu Jun 09 21:31:12 2016

Merge autofill::FormFieldData::is_checkable and is_checked

Currently, autofill::FormFieldData contains two Boolean data members:
 * is_checked, and
 * is_checkable.
As expected, the former can only be true when the latter is,
but the code makes this not clear.

We should merge these two Booleans into a single 3-valued enum representing the values:
not checkable, checkable but unchecked, checked.

BUG= 614280 

Review-Url: https://codereview.chromium.org/2022123002
Cr-Commit-Position: refs/heads/master@{#399021}

[modify] https://crrev.com/61b1d174d7dfd788dfe34cad3f8a0b9856894290/chrome/renderer/autofill/form_autofill_browsertest.cc
[modify] https://crrev.com/61b1d174d7dfd788dfe34cad3f8a0b9856894290/components/autofill/content/common/autofill_messages.h
[modify] https://crrev.com/61b1d174d7dfd788dfe34cad3f8a0b9856894290/components/autofill/content/renderer/form_autofill_util.cc
[modify] https://crrev.com/61b1d174d7dfd788dfe34cad3f8a0b9856894290/components/autofill/core/browser/autofill_metrics_unittest.cc
[modify] https://crrev.com/61b1d174d7dfd788dfe34cad3f8a0b9856894290/components/autofill/core/browser/form_field.cc
[modify] https://crrev.com/61b1d174d7dfd788dfe34cad3f8a0b9856894290/components/autofill/core/browser/form_field_unittest.cc
[modify] https://crrev.com/61b1d174d7dfd788dfe34cad3f8a0b9856894290/components/autofill/core/browser/form_structure.cc
[modify] https://crrev.com/61b1d174d7dfd788dfe34cad3f8a0b9856894290/components/autofill/core/browser/form_structure_unittest.cc
[modify] https://crrev.com/61b1d174d7dfd788dfe34cad3f8a0b9856894290/components/autofill/core/common/form_data_unittest.cc
[modify] https://crrev.com/61b1d174d7dfd788dfe34cad3f8a0b9856894290/components/autofill/core/common/form_field_data.cc
[modify] https://crrev.com/61b1d174d7dfd788dfe34cad3f8a0b9856894290/components/autofill/core/common/form_field_data.h
[modify] https://crrev.com/61b1d174d7dfd788dfe34cad3f8a0b9856894290/components/autofill/core/common/form_field_data_unittest.cc

Thank you, hs1217.lee!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61b1d174d7dfd788dfe34cad3f8a0b9856894290

commit 61b1d174d7dfd788dfe34cad3f8a0b9856894290
Author: hs1217.lee <hs1217.lee@gmail.com>
Date: Thu Jun 09 21:31:12 2016

Merge autofill::FormFieldData::is_checkable and is_checked

Currently, autofill::FormFieldData contains two Boolean data members:
 * is_checked, and
 * is_checkable.
As expected, the former can only be true when the latter is,
but the code makes this not clear.

We should merge these two Booleans into a single 3-valued enum representing the values:
not checkable, checkable but unchecked, checked.

BUG= 614280 

Review-Url: https://codereview.chromium.org/2022123002
Cr-Commit-Position: refs/heads/master@{#399021}

[modify] https://crrev.com/61b1d174d7dfd788dfe34cad3f8a0b9856894290/chrome/renderer/autofill/form_autofill_browsertest.cc
[modify] https://crrev.com/61b1d174d7dfd788dfe34cad3f8a0b9856894290/components/autofill/content/common/autofill_messages.h
[modify] https://crrev.com/61b1d174d7dfd788dfe34cad3f8a0b9856894290/components/autofill/content/renderer/form_autofill_util.cc
[modify] https://crrev.com/61b1d174d7dfd788dfe34cad3f8a0b9856894290/components/autofill/core/browser/autofill_metrics_unittest.cc
[modify] https://crrev.com/61b1d174d7dfd788dfe34cad3f8a0b9856894290/components/autofill/core/browser/form_field.cc
[modify] https://crrev.com/61b1d174d7dfd788dfe34cad3f8a0b9856894290/components/autofill/core/browser/form_field_unittest.cc
[modify] https://crrev.com/61b1d174d7dfd788dfe34cad3f8a0b9856894290/components/autofill/core/browser/form_structure.cc
[modify] https://crrev.com/61b1d174d7dfd788dfe34cad3f8a0b9856894290/components/autofill/core/browser/form_structure_unittest.cc
[modify] https://crrev.com/61b1d174d7dfd788dfe34cad3f8a0b9856894290/components/autofill/core/common/form_data_unittest.cc
[modify] https://crrev.com/61b1d174d7dfd788dfe34cad3f8a0b9856894290/components/autofill/core/common/form_field_data.cc
[modify] https://crrev.com/61b1d174d7dfd788dfe34cad3f8a0b9856894290/components/autofill/core/common/form_field_data.h
[modify] https://crrev.com/61b1d174d7dfd788dfe34cad3f8a0b9856894290/components/autofill/core/common/form_field_data_unittest.cc