WebView should not soft keyboard on navigation |
||||||||
Issue descriptionOn Samsung's email client, Pressing 'reply' button does not show soft keyboard starting from M51. Originally filed as b/27547367
,
May 24 2016
requesting merge of the above CL into M51
,
May 24 2016
,
May 25 2016
,
May 25 2016
requesting merge of #1 into M52
,
May 25 2016
,
May 25 2016
Merge approved for M52 branch 2743.
,
May 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b51b4d1b8571092c7e6883e83f6a682521975388 commit b51b4d1b8571092c7e6883e83f6a682521975388 Author: Changwan Ryu <changwan@google.com> Date: Thu May 26 01:37:00 2016 Fix WebView not to hide soft keyboard on navigation We were calling ImeAdapter#reset() (now renamed as resetAndHideKeyboard) whenever navigation occurred. This change was introduced in https://codereview.chromium.org/1278593004 . However, there are cases, e.g. email client using WebView, where we don't want the behavior. (b/27547367) We will still call resetAndHideKeyboard() when renderer process is gone as a safety net for ImeThread feature, and hide keyboard through updateKeyboardVisibility() function. BUG= 601707 Review-Url: https://codereview.chromium.org/2001983002 Cr-Commit-Position: refs/heads/master@{#395535} (cherry picked from commit cbd74f1402d7f3d87b032ea9ee1d4d65f6fcde8c) Review URL: https://codereview.chromium.org/2013983003 . Cr-Commit-Position: refs/branch-heads/2743@{#71} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/b51b4d1b8571092c7e6883e83f6a682521975388/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java [modify] https://crrev.com/b51b4d1b8571092c7e6883e83f6a682521975388/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
,
Jun 7 2016
verified on latest M52 webview on Samsung S6 edge |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by changwan@chromium.org
, May 24 2016