New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 614278 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

WebView should not soft keyboard on navigation

Project Member Reported by changwan@chromium.org, May 24 2016

Issue description

On Samsung's email client,
Pressing 'reply' button does not show soft keyboard starting from M51.

Originally filed as b/27547367

 
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbd74f1402d7f3d87b032ea9ee1d4d65f6fcde8c

commit cbd74f1402d7f3d87b032ea9ee1d4d65f6fcde8c
Author: changwan <changwan@chromium.org>
Date: Tue May 24 06:56:37 2016

Fix WebView not to hide soft keyboard on navigation

We were calling ImeAdapter#reset() (now renamed as resetAndHideKeyboard)
whenever navigation occurred. This change was introduced in
https://codereview.chromium.org/1278593004 .
However, there are cases, e.g. email client using WebView, where we don't
want the behavior. (b/27547367)

We will still call resetAndHideKeyboard() when renderer process is gone
as a safety net for ImeThread feature, and hide keyboard through
updateKeyboardVisibility() function.

BUG= 601707 

Review-Url: https://codereview.chromium.org/2001983002
Cr-Commit-Position: refs/heads/master@{#395535}

[modify] https://crrev.com/cbd74f1402d7f3d87b032ea9ee1d4d65f6fcde8c/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
[modify] https://crrev.com/cbd74f1402d7f3d87b032ea9ee1d4d65f6fcde8c/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java

(I used a wrong BUG number in that CL.)
Labels: Merge-Request-51
requesting merge of the above CL into M51
Labels: ReleaseBlock-Stable
Labels: -Pri-1 -ReleaseBlock-Stable -M-51 -Merge-Request-51 Merge-Request-52 ReleaseBlock-Beta Pri-2
requesting merge of #1 into M52
Labels: M-52
Labels: -Merge-Request-52 Merge-Approved-52
Merge approved for M52 branch 2743.
Labels: -Merge-Approved-52 merge-merged-2743
Status: Fixed (was: Started)
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b51b4d1b8571092c7e6883e83f6a682521975388

commit b51b4d1b8571092c7e6883e83f6a682521975388
Author: Changwan Ryu <changwan@google.com>
Date: Thu May 26 01:37:00 2016

Fix WebView not to hide soft keyboard on navigation

We were calling ImeAdapter#reset() (now renamed as resetAndHideKeyboard)
whenever navigation occurred. This change was introduced in
https://codereview.chromium.org/1278593004 .
However, there are cases, e.g. email client using WebView, where we don't
want the behavior. (b/27547367)

We will still call resetAndHideKeyboard() when renderer process is gone
as a safety net for ImeThread feature, and hide keyboard through
updateKeyboardVisibility() function.

BUG= 601707 

Review-Url: https://codereview.chromium.org/2001983002
Cr-Commit-Position: refs/heads/master@{#395535}
(cherry picked from commit cbd74f1402d7f3d87b032ea9ee1d4d65f6fcde8c)

Review URL: https://codereview.chromium.org/2013983003 .

Cr-Commit-Position: refs/branch-heads/2743@{#71}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/b51b4d1b8571092c7e6883e83f6a682521975388/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
[modify] https://crrev.com/b51b4d1b8571092c7e6883e83f6a682521975388/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java
Status: Verified (was: Fixed)
verified on latest M52 webview on Samsung S6 edge 

Sign in to add a comment