New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 614277 link

Starred by 25 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug


Sign in to add a comment

[Site Settings] Missing site settings

Project Member Reported by tbuck...@chromium.org, May 24 2016

Issue description

A lot of the existing Content Settings on Chrome OS are missing from MD Settings. I captured what's in the existing Settings vs MD Settings here: https://docs.google.com/spreadsheets/d/1bVRBeEcJ3YSJNMKq9U9pm-dGFtVRDryzfojoDeYpirI/edit#gid=0

I can also audit Content Settings on Desktop if that would be useful.

This will block MD Settings from launching to Dev Channel, so marking as a P1.
 
Labels: OS-All
Labels: Hotlist-MD-DevBlocker
Blocking: 614588
Blocking: 614589
Labels: -Hotlist-MD-DevBlocker
Cc: msramek@chromium.org
Components: Privacy
(cc'ing myself to stay in the loop)

For posterity, list of iron-icons needed: 

- Key generation - icons:code
- Automatic Downloads - icons:file-download
- Mouse lock - hardware:mouse
- Un-sandboxed plugin access - icons:extension
- Handlers - icons:open-with
- Plugins - icons:extension
- Background Sync - notification:sync
- Full screen - icons:fullscreen
- Protected content - hardware:security
- Zoom levels - icons:zoom-in
- USB Devices - device:usb

Comment 9 by rolfe@chromium.org, Jun 2 2016

Cc: rolfe@chromium.org emilyschechter@chromium.org
For posterity - doc by emilyschecter@ on changes reviewed by Security/Privacy
https://docs.google.com/spreadsheets/d/1Bil59vAuGTMN53S5j8J5BVAVit0NWSGekMYOZFqCR3w/edit#gid=0

CHANGES
- Camera/Mic: chooser drop down
- Cookies: clear on exit checkbox; Flash Player settings link; clear on exit by site; all cookies and site data management
- Handlers: Handlers with associated sites and ability to set which one is the default/delete it
- Zoom: list with delete options
- USB: device and its related sites, also shown in the single site settings page
- General learn more: blue link appended to site lists
- General exceptions: added site exception link in allow state and modified dialog text (to be handled in this bug: https://bugs.chromium.org/p/chromium/issues/detail?id=442446)
- Incognito support: checkbox in the exception dialog that shows when you've got an incognito window open

NO MOCKS
- Unsandboxed plugin access (ask/block)
- Automatic downloads (ask/block)
- Images (allow/block)
- Plugins (allow important/block - approved by Privacy in Emily's doc)
- Location (ask/block)
- Notifications (ask/block)
- JavaScript (allow/block)
- Pop-ups (allow/block)
- Autoplay (allow/block) [note this is going through UI Review so may change]
- Keygen (allow/block)
- Background sync (allow/block)
- Midi (allow/block)

STRINGS (For desktop-only allow/block options)
- MIDI: Ask before allowing sites to use your MIDI (recommended)
- Handlers: Ask before allowing sites to be become default handlers (recommended)
- Unsandboxed plugin access: Ask first before allowing unsandboxed plugin content to run (recommended)
- Images: Allow sites to show images (recommended)
- Plugins: Allow important plugin content to run (recommended)

Cc: jhawkins@chromium.org abodenha@chromium.org finnur@chromium.org
 Issue 471043  has been merged into this issue.
Project Member

Comment 11 by bugdroid1@chromium.org, Jun 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e1b4e7ae7d21f64f85dad5d35235fd443277cae

commit 8e1b4e7ae7d21f64f85dad5d35235fd443277cae
Author: finnur <finnur@chromium.org>
Date: Fri Jun 03 02:36:25 2016

MD Site Settings: Add icons for a few categories.

BUG= 614277 ,  614277 ,  543635 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2030203002
Cr-Commit-Position: refs/heads/master@{#397588}

[modify] https://crrev.com/8e1b4e7ae7d21f64f85dad5d35235fd443277cae/chrome/browser/resources/settings/icons.html

Project Member

Comment 12 by bugdroid1@chromium.org, Jun 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/155a202f6076fad0cd5d86bfefb5c317d8a3708e

commit 155a202f6076fad0cd5d86bfefb5c317d8a3708e
Author: finnur <finnur@chromium.org>
Date: Fri Jun 03 22:07:28 2016

Add five new top level categories and corresponding entries on the Site Details page.

Automatic downloads
Background sync
Key generation
Plugins
Unsandboxed plugin access

Also changed it so that, in JS land, the Category variable is a string, because the enum value of the ContentSettingsTypes is variable depending on platform, so we don't want to be hardcoding those in JS. This is similar to the Allow/Block values (the PermissionValues enum), which used to be ints, but are now converted int <-> string on the JS/C++ boundary.

TBR=sky
BUG= 614277 ,  543635 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2021343003
Cr-Commit-Position: refs/heads/master@{#397819}

[modify] https://crrev.com/155a202f6076fad0cd5d86bfefb5c317d8a3708e/chrome/app/settings_strings.grdp
[modify] https://crrev.com/155a202f6076fad0cd5d86bfefb5c317d8a3708e/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/155a202f6076fad0cd5d86bfefb5c317d8a3708e/chrome/browser/resources/settings/settings_page/settings_router.js
[modify] https://crrev.com/155a202f6076fad0cd5d86bfefb5c317d8a3708e/chrome/browser/resources/settings/site_settings/add_site_dialog.js
[modify] https://crrev.com/155a202f6076fad0cd5d86bfefb5c317d8a3708e/chrome/browser/resources/settings/site_settings/constants.js
[modify] https://crrev.com/155a202f6076fad0cd5d86bfefb5c317d8a3708e/chrome/browser/resources/settings/site_settings/site_details.html
[modify] https://crrev.com/155a202f6076fad0cd5d86bfefb5c317d8a3708e/chrome/browser/resources/settings/site_settings/site_details_permission.js
[modify] https://crrev.com/155a202f6076fad0cd5d86bfefb5c317d8a3708e/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/155a202f6076fad0cd5d86bfefb5c317d8a3708e/chrome/browser/resources/settings/site_settings/site_list.js
[modify] https://crrev.com/155a202f6076fad0cd5d86bfefb5c317d8a3708e/chrome/browser/resources/settings/site_settings/site_settings_behavior.js
[modify] https://crrev.com/155a202f6076fad0cd5d86bfefb5c317d8a3708e/chrome/browser/resources/settings/site_settings/site_settings_category.js
[modify] https://crrev.com/155a202f6076fad0cd5d86bfefb5c317d8a3708e/chrome/browser/resources/settings/site_settings_page/site_settings_page.html
[modify] https://crrev.com/155a202f6076fad0cd5d86bfefb5c317d8a3708e/chrome/browser/resources/settings/site_settings_page/site_settings_page.js
[modify] https://crrev.com/155a202f6076fad0cd5d86bfefb5c317d8a3708e/chrome/browser/ui/chrome_pages.cc
[modify] https://crrev.com/155a202f6076fad0cd5d86bfefb5c317d8a3708e/chrome/browser/ui/webui/options/content_settings_handler.cc
[modify] https://crrev.com/155a202f6076fad0cd5d86bfefb5c317d8a3708e/chrome/browser/ui/webui/options/content_settings_handler.h
[modify] https://crrev.com/155a202f6076fad0cd5d86bfefb5c317d8a3708e/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/155a202f6076fad0cd5d86bfefb5c317d8a3708e/chrome/browser/ui/webui/settings/site_settings_handler.cc
[modify] https://crrev.com/155a202f6076fad0cd5d86bfefb5c317d8a3708e/chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc
[modify] https://crrev.com/155a202f6076fad0cd5d86bfefb5c317d8a3708e/chrome/browser/ui/webui/site_settings_helper.cc
[modify] https://crrev.com/155a202f6076fad0cd5d86bfefb5c317d8a3708e/chrome/browser/ui/webui/site_settings_helper.h
[modify] https://crrev.com/155a202f6076fad0cd5d86bfefb5c317d8a3708e/chrome/test/data/webui/settings/site_details_permission_tests.js
[modify] https://crrev.com/155a202f6076fad0cd5d86bfefb5c317d8a3708e/chrome/test/data/webui/settings/site_details_tests.js
[modify] https://crrev.com/155a202f6076fad0cd5d86bfefb5c317d8a3708e/chrome/test/data/webui/settings/site_list_tests.js
[modify] https://crrev.com/155a202f6076fad0cd5d86bfefb5c317d8a3708e/chrome/test/data/webui/settings/test_site_settings_prefs_browser_proxy.js

Project Member

Comment 14 by bugdroid1@chromium.org, Jun 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9776098ecbf3efab15ef1f84867aa008af2af9d

commit c9776098ecbf3efab15ef1f84867aa008af2af9d
Author: finnur <finnur@chromium.org>
Date: Wed Jun 08 22:35:43 2016

Site Settings Desktop: Implement media picker for camera/mic categories.

BUG= 614277 ,  543635 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2039833004
Cr-Commit-Position: refs/heads/master@{#398708}

[modify] https://crrev.com/c9776098ecbf3efab15ef1f84867aa008af2af9d/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/c9776098ecbf3efab15ef1f84867aa008af2af9d/chrome/browser/resources/settings/settings_resources.grd
[add] https://crrev.com/c9776098ecbf3efab15ef1f84867aa008af2af9d/chrome/browser/resources/settings/site_settings/media_picker.html
[add] https://crrev.com/c9776098ecbf3efab15ef1f84867aa008af2af9d/chrome/browser/resources/settings/site_settings/media_picker.js
[modify] https://crrev.com/c9776098ecbf3efab15ef1f84867aa008af2af9d/chrome/browser/resources/settings/site_settings/site_settings_category.html
[modify] https://crrev.com/c9776098ecbf3efab15ef1f84867aa008af2af9d/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js
[modify] https://crrev.com/c9776098ecbf3efab15ef1f84867aa008af2af9d/chrome/browser/ui/webui/settings/md_settings_ui.cc
[add] https://crrev.com/c9776098ecbf3efab15ef1f84867aa008af2af9d/chrome/browser/ui/webui/settings/settings_media_devices_selection_handler.cc
[add] https://crrev.com/c9776098ecbf3efab15ef1f84867aa008af2af9d/chrome/browser/ui/webui/settings/settings_media_devices_selection_handler.h
[modify] https://crrev.com/c9776098ecbf3efab15ef1f84867aa008af2af9d/chrome/chrome_browser_ui.gypi

Project Member

Comment 15 by bugdroid1@chromium.org, Jun 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e77d721e353b457b741a3a2781b7181e32fbcb63

commit e77d721e353b457b741a3a2781b7181e32fbcb63
Author: finnur <finnur@chromium.org>
Date: Fri Jun 10 10:12:40 2016

Site Settings Desktop: Change how adding site exceptions work.

Instead of the whitelist model, move to one that allows adding either
Block/Allow entries. This requires the category heading to be always
shown, because otherwise there's no context. This CL also adds support
for Enter (to submit) in the dialog.

BUG= 614277 ,  543635 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2044963003
Cr-Commit-Position: refs/heads/master@{#399145}

[modify] https://crrev.com/e77d721e353b457b741a3a2781b7181e32fbcb63/chrome/app/generated_resources.grd
[modify] https://crrev.com/e77d721e353b457b741a3a2781b7181e32fbcb63/chrome/browser/resources/settings/site_settings/add_site_dialog.html
[modify] https://crrev.com/e77d721e353b457b741a3a2781b7181e32fbcb63/chrome/browser/resources/settings/site_settings/add_site_dialog.js
[modify] https://crrev.com/e77d721e353b457b741a3a2781b7181e32fbcb63/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/e77d721e353b457b741a3a2781b7181e32fbcb63/chrome/browser/resources/settings/site_settings/site_list.js
[modify] https://crrev.com/e77d721e353b457b741a3a2781b7181e32fbcb63/chrome/browser/resources/settings/site_settings/site_settings_category.html
[modify] https://crrev.com/e77d721e353b457b741a3a2781b7181e32fbcb63/chrome/browser/resources/settings/site_settings/site_settings_category.js
[modify] https://crrev.com/e77d721e353b457b741a3a2781b7181e32fbcb63/chrome/test/data/webui/settings/site_list_tests.js

Project Member

Comment 16 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e77d721e353b457b741a3a2781b7181e32fbcb63

commit e77d721e353b457b741a3a2781b7181e32fbcb63
Author: finnur <finnur@chromium.org>
Date: Fri Jun 10 10:12:40 2016

Site Settings Desktop: Change how adding site exceptions work.

Instead of the whitelist model, move to one that allows adding either
Block/Allow entries. This requires the category heading to be always
shown, because otherwise there's no context. This CL also adds support
for Enter (to submit) in the dialog.

BUG= 614277 ,  543635 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2044963003
Cr-Commit-Position: refs/heads/master@{#399145}

[modify] https://crrev.com/e77d721e353b457b741a3a2781b7181e32fbcb63/chrome/app/generated_resources.grd
[modify] https://crrev.com/e77d721e353b457b741a3a2781b7181e32fbcb63/chrome/browser/resources/settings/site_settings/add_site_dialog.html
[modify] https://crrev.com/e77d721e353b457b741a3a2781b7181e32fbcb63/chrome/browser/resources/settings/site_settings/add_site_dialog.js
[modify] https://crrev.com/e77d721e353b457b741a3a2781b7181e32fbcb63/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/e77d721e353b457b741a3a2781b7181e32fbcb63/chrome/browser/resources/settings/site_settings/site_list.js
[modify] https://crrev.com/e77d721e353b457b741a3a2781b7181e32fbcb63/chrome/browser/resources/settings/site_settings/site_settings_category.html
[modify] https://crrev.com/e77d721e353b457b741a3a2781b7181e32fbcb63/chrome/browser/resources/settings/site_settings/site_settings_category.js
[modify] https://crrev.com/e77d721e353b457b741a3a2781b7181e32fbcb63/chrome/test/data/webui/settings/site_list_tests.js

Project Member

Comment 17 by bugdroid1@chromium.org, Jun 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67798eab1c7003952ba4176f2e2809df6425395f

commit 67798eab1c7003952ba4176f2e2809df6425395f
Author: finnur <finnur@chromium.org>
Date: Thu Jun 16 14:55:24 2016

Site Settings Desktop: Implement the 'Clear on exit' menu for Cookies.

BUG= 614277 ,  543635 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2055823003
Cr-Commit-Position: refs/heads/master@{#400154}

[modify] https://crrev.com/67798eab1c7003952ba4176f2e2809df6425395f/chrome/app/settings_strings.grdp
[modify] https://crrev.com/67798eab1c7003952ba4176f2e2809df6425395f/chrome/browser/resources/settings/site_settings/constants.js
[modify] https://crrev.com/67798eab1c7003952ba4176f2e2809df6425395f/chrome/browser/resources/settings/site_settings/site_details_permission.js
[modify] https://crrev.com/67798eab1c7003952ba4176f2e2809df6425395f/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/67798eab1c7003952ba4176f2e2809df6425395f/chrome/browser/resources/settings/site_settings/site_list.js
[modify] https://crrev.com/67798eab1c7003952ba4176f2e2809df6425395f/chrome/browser/resources/settings/site_settings/site_settings_behavior.js
[modify] https://crrev.com/67798eab1c7003952ba4176f2e2809df6425395f/chrome/browser/resources/settings/site_settings/site_settings_category.html
[modify] https://crrev.com/67798eab1c7003952ba4176f2e2809df6425395f/chrome/browser/resources/settings/site_settings/site_settings_category.js
[modify] https://crrev.com/67798eab1c7003952ba4176f2e2809df6425395f/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/67798eab1c7003952ba4176f2e2809df6425395f/chrome/test/data/webui/settings/site_list_tests.js

 Issue 622740  has been merged into this issue.
 Issue 623533  has been merged into this issue.
 Issue 624512  has been merged into this issue.
Cc: -jhawkins@chromium.org
Adding a couple of screenshots of the Cookie Data to help with review.

Screenshot from 2016-07-05 11:07:09.png
54.5 KB View Download
Screenshot from 2016-07-05 11:07:44.png
63.6 KB View Download
 Issue 625369  has been merged into this issue.
 Issue 624856  has been merged into this issue.
 Issue 625194  has been merged into this issue.
Project Member

Comment 27 by bugdroid1@chromium.org, Jul 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86813d9354a393874f5af0cf79a99f67b73ca348

commit 86813d9354a393874f5af0cf79a99f67b73ca348
Author: finnur <finnur@chromium.org>
Date: Fri Jul 08 14:12:30 2016

Site Settings Desktop: Implement the cookies list and details dialog.

Might require some UI polish follow-up, but the functionally should work.

BUG= 614277 ,  543635 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2115833003
Cr-Commit-Position: refs/heads/master@{#404358}

[modify] https://crrev.com/86813d9354a393874f5af0cf79a99f67b73ca348/chrome/app/settings_strings.grdp
[modify] https://crrev.com/86813d9354a393874f5af0cf79a99f67b73ca348/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/86813d9354a393874f5af0cf79a99f67b73ca348/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/86813d9354a393874f5af0cf79a99f67b73ca348/chrome/browser/resources/settings/site_settings/compiled_resources2.gyp
[add] https://crrev.com/86813d9354a393874f5af0cf79a99f67b73ca348/chrome/browser/resources/settings/site_settings/cookie_info.js
[add] https://crrev.com/86813d9354a393874f5af0cf79a99f67b73ca348/chrome/browser/resources/settings/site_settings/cookie_tree_node.js
[add] https://crrev.com/86813d9354a393874f5af0cf79a99f67b73ca348/chrome/browser/resources/settings/site_settings/site_data.html
[add] https://crrev.com/86813d9354a393874f5af0cf79a99f67b73ca348/chrome/browser/resources/settings/site_settings/site_data.js
[add] https://crrev.com/86813d9354a393874f5af0cf79a99f67b73ca348/chrome/browser/resources/settings/site_settings/site_data_details_dialog.html
[add] https://crrev.com/86813d9354a393874f5af0cf79a99f67b73ca348/chrome/browser/resources/settings/site_settings/site_data_details_dialog.js
[modify] https://crrev.com/86813d9354a393874f5af0cf79a99f67b73ca348/chrome/browser/resources/settings/site_settings/site_details.html
[modify] https://crrev.com/86813d9354a393874f5af0cf79a99f67b73ca348/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/86813d9354a393874f5af0cf79a99f67b73ca348/chrome/browser/resources/settings/site_settings/site_settings_behavior.js
[modify] https://crrev.com/86813d9354a393874f5af0cf79a99f67b73ca348/chrome/browser/resources/settings/site_settings/site_settings_category.html
[modify] https://crrev.com/86813d9354a393874f5af0cf79a99f67b73ca348/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js
[modify] https://crrev.com/86813d9354a393874f5af0cf79a99f67b73ca348/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/86813d9354a393874f5af0cf79a99f67b73ca348/chrome/browser/ui/webui/settings/md_settings_ui.cc
[add] https://crrev.com/86813d9354a393874f5af0cf79a99f67b73ca348/chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc
[add] https://crrev.com/86813d9354a393874f5af0cf79a99f67b73ca348/chrome/browser/ui/webui/settings/settings_cookies_view_handler.h
[modify] https://crrev.com/86813d9354a393874f5af0cf79a99f67b73ca348/chrome/chrome_browser_ui.gypi

Comment 28 by bestp...@gmail.com, Jul 12 2016

New setting miss "Keep local data only until you quit your browser."

Comment 29 by bestp...@gmail.com, Jul 12 2016

Sorry, my chrome version is 54.0.2793.0 canary 32-bit.

This setting is very important for me.
Project Member

Comment 30 by bugdroid1@chromium.org, Jul 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4fd43ac1df0f83c523da33c0e56bbd76d8b704d9

commit 4fd43ac1df0f83c523da33c0e56bbd76d8b704d9
Author: finnur <finnur@chromium.org>
Date: Wed Jul 13 02:27:28 2016

Site Settings Desktop: Implement protocol handler section.

BUG= 614277 ,  543635 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2131953002
Cr-Commit-Position: refs/heads/master@{#404912}

[modify] https://crrev.com/4fd43ac1df0f83c523da33c0e56bbd76d8b704d9/chrome/app/settings_strings.grdp
[modify] https://crrev.com/4fd43ac1df0f83c523da33c0e56bbd76d8b704d9/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/4fd43ac1df0f83c523da33c0e56bbd76d8b704d9/chrome/browser/resources/settings/settings_page/settings_router.js
[modify] https://crrev.com/4fd43ac1df0f83c523da33c0e56bbd76d8b704d9/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/4fd43ac1df0f83c523da33c0e56bbd76d8b704d9/chrome/browser/resources/settings/site_settings/constants.js
[add] https://crrev.com/4fd43ac1df0f83c523da33c0e56bbd76d8b704d9/chrome/browser/resources/settings/site_settings/protocol_handlers.html
[add] https://crrev.com/4fd43ac1df0f83c523da33c0e56bbd76d8b704d9/chrome/browser/resources/settings/site_settings/protocol_handlers.js
[modify] https://crrev.com/4fd43ac1df0f83c523da33c0e56bbd76d8b704d9/chrome/browser/resources/settings/site_settings/site_list.js
[modify] https://crrev.com/4fd43ac1df0f83c523da33c0e56bbd76d8b704d9/chrome/browser/resources/settings/site_settings/site_settings_behavior.js
[modify] https://crrev.com/4fd43ac1df0f83c523da33c0e56bbd76d8b704d9/chrome/browser/resources/settings/site_settings/site_settings_category.js
[modify] https://crrev.com/4fd43ac1df0f83c523da33c0e56bbd76d8b704d9/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js
[modify] https://crrev.com/4fd43ac1df0f83c523da33c0e56bbd76d8b704d9/chrome/browser/resources/settings/site_settings_page/site_settings_page.html
[modify] https://crrev.com/4fd43ac1df0f83c523da33c0e56bbd76d8b704d9/chrome/browser/resources/settings/site_settings_page/site_settings_page.js
[modify] https://crrev.com/4fd43ac1df0f83c523da33c0e56bbd76d8b704d9/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/4fd43ac1df0f83c523da33c0e56bbd76d8b704d9/chrome/browser/ui/webui/settings/md_settings_ui.cc
[add] https://crrev.com/4fd43ac1df0f83c523da33c0e56bbd76d8b704d9/chrome/browser/ui/webui/settings/protocol_handlers_handler.cc
[add] https://crrev.com/4fd43ac1df0f83c523da33c0e56bbd76d8b704d9/chrome/browser/ui/webui/settings/protocol_handlers_handler.h
[modify] https://crrev.com/4fd43ac1df0f83c523da33c0e56bbd76d8b704d9/chrome/chrome_browser_ui.gypi

Project Member

Comment 31 by bugdroid1@chromium.org, Jul 13 2016

Labels: merge-merged-2795
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4fd43ac1df0f83c523da33c0e56bbd76d8b704d9

commit 4fd43ac1df0f83c523da33c0e56bbd76d8b704d9
Author: finnur <finnur@chromium.org>
Date: Wed Jul 13 02:27:28 2016

Site Settings Desktop: Implement protocol handler section.

BUG= 614277 ,  543635 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2131953002
Cr-Commit-Position: refs/heads/master@{#404912}

[modify] https://crrev.com/4fd43ac1df0f83c523da33c0e56bbd76d8b704d9/chrome/app/settings_strings.grdp
[modify] https://crrev.com/4fd43ac1df0f83c523da33c0e56bbd76d8b704d9/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/4fd43ac1df0f83c523da33c0e56bbd76d8b704d9/chrome/browser/resources/settings/settings_page/settings_router.js
[modify] https://crrev.com/4fd43ac1df0f83c523da33c0e56bbd76d8b704d9/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/4fd43ac1df0f83c523da33c0e56bbd76d8b704d9/chrome/browser/resources/settings/site_settings/constants.js
[add] https://crrev.com/4fd43ac1df0f83c523da33c0e56bbd76d8b704d9/chrome/browser/resources/settings/site_settings/protocol_handlers.html
[add] https://crrev.com/4fd43ac1df0f83c523da33c0e56bbd76d8b704d9/chrome/browser/resources/settings/site_settings/protocol_handlers.js
[modify] https://crrev.com/4fd43ac1df0f83c523da33c0e56bbd76d8b704d9/chrome/browser/resources/settings/site_settings/site_list.js
[modify] https://crrev.com/4fd43ac1df0f83c523da33c0e56bbd76d8b704d9/chrome/browser/resources/settings/site_settings/site_settings_behavior.js
[modify] https://crrev.com/4fd43ac1df0f83c523da33c0e56bbd76d8b704d9/chrome/browser/resources/settings/site_settings/site_settings_category.js
[modify] https://crrev.com/4fd43ac1df0f83c523da33c0e56bbd76d8b704d9/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js
[modify] https://crrev.com/4fd43ac1df0f83c523da33c0e56bbd76d8b704d9/chrome/browser/resources/settings/site_settings_page/site_settings_page.html
[modify] https://crrev.com/4fd43ac1df0f83c523da33c0e56bbd76d8b704d9/chrome/browser/resources/settings/site_settings_page/site_settings_page.js
[modify] https://crrev.com/4fd43ac1df0f83c523da33c0e56bbd76d8b704d9/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/4fd43ac1df0f83c523da33c0e56bbd76d8b704d9/chrome/browser/ui/webui/settings/md_settings_ui.cc
[add] https://crrev.com/4fd43ac1df0f83c523da33c0e56bbd76d8b704d9/chrome/browser/ui/webui/settings/protocol_handlers_handler.cc
[add] https://crrev.com/4fd43ac1df0f83c523da33c0e56bbd76d8b704d9/chrome/browser/ui/webui/settings/protocol_handlers_handler.h
[modify] https://crrev.com/4fd43ac1df0f83c523da33c0e56bbd76d8b704d9/chrome/chrome_browser_ui.gypi

 Issue 627690  has been merged into this issue.
Issue 628007 has been merged into this issue.
Note how Incognito exceptions should be displayed: https://screenshot.googleplex.com/uo491Wzr1DT
 Issue 628896  has been merged into this issue.
Cc: tbuck...@chromium.org
 Issue 628760  has been merged into this issue.
 Issue 625485  has been merged into this issue.
Blockedon: 628760
Blockedon: 607133

Comment 40 by dbeam@chromium.org, Jul 25 2016

 Issue 631023  has been merged into this issue.
 Issue 635647  has been merged into this issue.
Blockedon: 635845
Blockedon: 635846
Blockedon: 635847
Blockedon: 635850
Blockedon: 635852
Blockedon: 635855
Blockedon: 635858
Blockedon: 635860
Blockedon: 635862
This bug was getting a bit unwieldy and hard to figure out what was remaining. Since dschuyler is pitching in on Site Settings I decided to review the mocks, try to figure out what I think is remaining and split it into separate bugs. I'm hanging each bug off of this bug, for tracking purposes. When all bugs have been resolved, we can close this one.
That was supposed to read: Since dschuyler is pitching in on Site Settings Dave and I decided it would be helpful if I reviewed the mocks, try to figure out what I think is remaining [...]
Blockedon: 635874
 Issue 634048  has been merged into this issue.
Blockedon: 637865
Cc: dschuyler@chromium.org
 Issue 637421  has been merged into this issue.
 Issue 637211  has been merged into this issue.
Blockedon: 632618
Project Member

Comment 59 by bugdroid1@chromium.org, Aug 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d9862f8d67ee97a5b6ec1cbdd19395f5720d0c0

commit 0d9862f8d67ee97a5b6ec1cbdd19395f5720d0c0
Author: finnur <finnur@chromium.org>
Date: Tue Aug 16 11:09:24 2016

Site Settings Desktop: Implement USB devices section.

BUG= 635845 ,  614277 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2237823003
Cr-Commit-Position: refs/heads/master@{#412212}

[modify] https://crrev.com/0d9862f8d67ee97a5b6ec1cbdd19395f5720d0c0/chrome/app/settings_strings.grdp
[modify] https://crrev.com/0d9862f8d67ee97a5b6ec1cbdd19395f5720d0c0/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/0d9862f8d67ee97a5b6ec1cbdd19395f5720d0c0/chrome/browser/resources/settings/route.js
[modify] https://crrev.com/0d9862f8d67ee97a5b6ec1cbdd19395f5720d0c0/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/0d9862f8d67ee97a5b6ec1cbdd19395f5720d0c0/chrome/browser/resources/settings/site_settings/compiled_resources2.gyp
[modify] https://crrev.com/0d9862f8d67ee97a5b6ec1cbdd19395f5720d0c0/chrome/browser/resources/settings/site_settings/constants.js
[modify] https://crrev.com/0d9862f8d67ee97a5b6ec1cbdd19395f5720d0c0/chrome/browser/resources/settings/site_settings/protocol_handlers.html
[modify] https://crrev.com/0d9862f8d67ee97a5b6ec1cbdd19395f5720d0c0/chrome/browser/resources/settings/site_settings/site_list.js
[modify] https://crrev.com/0d9862f8d67ee97a5b6ec1cbdd19395f5720d0c0/chrome/browser/resources/settings/site_settings/site_settings_behavior.js
[modify] https://crrev.com/0d9862f8d67ee97a5b6ec1cbdd19395f5720d0c0/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js
[add] https://crrev.com/0d9862f8d67ee97a5b6ec1cbdd19395f5720d0c0/chrome/browser/resources/settings/site_settings/usb_devices.html
[add] https://crrev.com/0d9862f8d67ee97a5b6ec1cbdd19395f5720d0c0/chrome/browser/resources/settings/site_settings/usb_devices.js
[modify] https://crrev.com/0d9862f8d67ee97a5b6ec1cbdd19395f5720d0c0/chrome/browser/resources/settings/site_settings_page/site_settings_page.html
[modify] https://crrev.com/0d9862f8d67ee97a5b6ec1cbdd19395f5720d0c0/chrome/browser/ui/webui/options/content_settings_handler.cc
[modify] https://crrev.com/0d9862f8d67ee97a5b6ec1cbdd19395f5720d0c0/chrome/browser/ui/webui/options/content_settings_handler.h
[modify] https://crrev.com/0d9862f8d67ee97a5b6ec1cbdd19395f5720d0c0/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/0d9862f8d67ee97a5b6ec1cbdd19395f5720d0c0/chrome/browser/ui/webui/settings/site_settings_handler.cc
[modify] https://crrev.com/0d9862f8d67ee97a5b6ec1cbdd19395f5720d0c0/chrome/browser/ui/webui/settings/site_settings_handler.h
[modify] https://crrev.com/0d9862f8d67ee97a5b6ec1cbdd19395f5720d0c0/chrome/browser/ui/webui/site_settings_helper.cc
[modify] https://crrev.com/0d9862f8d67ee97a5b6ec1cbdd19395f5720d0c0/chrome/browser/ui/webui/site_settings_helper.h
[modify] https://crrev.com/0d9862f8d67ee97a5b6ec1cbdd19395f5720d0c0/chrome/test/data/webui/settings/site_settings_category_tests.js

Project Member

Comment 60 by bugdroid1@chromium.org, Aug 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f40c843852d50fc41aa353588d7799f0f6203626

commit f40c843852d50fc41aa353588d7799f0f6203626
Author: finnur <finnur@chromium.org>
Date: Fri Aug 19 15:27:52 2016

Site Settings Desktop: Implement individual cookie removal and RemoveAll.

BUG= 635852 ,  614277 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2248683006
Cr-Commit-Position: refs/heads/master@{#413151}

[modify] https://crrev.com/f40c843852d50fc41aa353588d7799f0f6203626/chrome/browser/browsing_data/cookies_tree_model.cc
[modify] https://crrev.com/f40c843852d50fc41aa353588d7799f0f6203626/chrome/browser/resources/settings/site_settings/compiled_resources2.gyp
[modify] https://crrev.com/f40c843852d50fc41aa353588d7799f0f6203626/chrome/browser/resources/settings/site_settings/cookie_tree_node.js
[modify] https://crrev.com/f40c843852d50fc41aa353588d7799f0f6203626/chrome/browser/resources/settings/site_settings/site_data.html
[modify] https://crrev.com/f40c843852d50fc41aa353588d7799f0f6203626/chrome/browser/resources/settings/site_settings/site_data.js
[modify] https://crrev.com/f40c843852d50fc41aa353588d7799f0f6203626/chrome/browser/resources/settings/site_settings/site_data_details_dialog.js
[modify] https://crrev.com/f40c843852d50fc41aa353588d7799f0f6203626/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js
[modify] https://crrev.com/f40c843852d50fc41aa353588d7799f0f6203626/chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc
[modify] https://crrev.com/f40c843852d50fc41aa353588d7799f0f6203626/chrome/browser/ui/webui/settings/settings_cookies_view_handler.h

Blockedon: 633682
Blockedon: 640924
Project Member

Comment 64 by bugdroid1@chromium.org, Aug 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aafe66ab5cdbe2036354dd6304a1f517387bab47

commit aafe66ab5cdbe2036354dd6304a1f517387bab47
Author: finnur <finnur@chromium.org>
Date: Fri Aug 26 01:18:48 2016

Site Settings Desktop: Fix cookie data labelling for Indexed DBs.

BUG=640924,  614277 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2277213002
Cr-Commit-Position: refs/heads/master@{#414612}

[modify] https://crrev.com/aafe66ab5cdbe2036354dd6304a1f517387bab47/chrome/browser/resources/settings/site_settings/cookie_tree_node.js

Project Member

Comment 66 by bugdroid1@chromium.org, Sep 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d5f2515c355ca11dd8ca9cdd785df3f3a5b41a3

commit 1d5f2515c355ca11dd8ca9cdd785df3f3a5b41a3
Author: finnur <finnur@chromium.org>
Date: Mon Sep 05 12:29:20 2016

Site Settings Desktop: Support adding exceptions for incognito mode.

BUG= 635855 ,  635862 ,  614277 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2298283002
Cr-Commit-Position: refs/heads/master@{#416534}

[modify] https://crrev.com/1d5f2515c355ca11dd8ca9cdd785df3f3a5b41a3/chrome/app/settings_strings.grdp
[modify] https://crrev.com/1d5f2515c355ca11dd8ca9cdd785df3f3a5b41a3/chrome/browser/resources/settings/site_settings/add_site_dialog.html
[modify] https://crrev.com/1d5f2515c355ca11dd8ca9cdd785df3f3a5b41a3/chrome/browser/resources/settings/site_settings/add_site_dialog.js
[modify] https://crrev.com/1d5f2515c355ca11dd8ca9cdd785df3f3a5b41a3/chrome/browser/resources/settings/site_settings/compiled_resources2.gyp
[modify] https://crrev.com/1d5f2515c355ca11dd8ca9cdd785df3f3a5b41a3/chrome/browser/resources/settings/site_settings/site_details_permission.js
[modify] https://crrev.com/1d5f2515c355ca11dd8ca9cdd785df3f3a5b41a3/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/1d5f2515c355ca11dd8ca9cdd785df3f3a5b41a3/chrome/browser/resources/settings/site_settings/site_list.js
[modify] https://crrev.com/1d5f2515c355ca11dd8ca9cdd785df3f3a5b41a3/chrome/browser/resources/settings/site_settings/site_settings_behavior.js
[modify] https://crrev.com/1d5f2515c355ca11dd8ca9cdd785df3f3a5b41a3/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js
[modify] https://crrev.com/1d5f2515c355ca11dd8ca9cdd785df3f3a5b41a3/chrome/browser/ui/webui/options/content_settings_handler.cc
[modify] https://crrev.com/1d5f2515c355ca11dd8ca9cdd785df3f3a5b41a3/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/1d5f2515c355ca11dd8ca9cdd785df3f3a5b41a3/chrome/browser/ui/webui/settings/site_settings_handler.cc
[modify] https://crrev.com/1d5f2515c355ca11dd8ca9cdd785df3f3a5b41a3/chrome/browser/ui/webui/settings/site_settings_handler.h
[modify] https://crrev.com/1d5f2515c355ca11dd8ca9cdd785df3f3a5b41a3/chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc
[modify] https://crrev.com/1d5f2515c355ca11dd8ca9cdd785df3f3a5b41a3/chrome/browser/ui/webui/site_settings_helper.cc
[modify] https://crrev.com/1d5f2515c355ca11dd8ca9cdd785df3f3a5b41a3/chrome/browser/ui/webui/site_settings_helper.h
[modify] https://crrev.com/1d5f2515c355ca11dd8ca9cdd785df3f3a5b41a3/chrome/test/base/testing_profile.cc
[modify] https://crrev.com/1d5f2515c355ca11dd8ca9cdd785df3f3a5b41a3/chrome/test/base/testing_profile.h
[modify] https://crrev.com/1d5f2515c355ca11dd8ca9cdd785df3f3a5b41a3/chrome/test/data/webui/settings/site_list_tests.js
[modify] https://crrev.com/1d5f2515c355ca11dd8ca9cdd785df3f3a5b41a3/chrome/test/data/webui/settings/test_site_settings_prefs_browser_proxy.js

Project Member

Comment 67 by bugdroid1@chromium.org, Sep 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c8075c0d37d27074caa8c9987a9d03f20d72d03

commit 9c8075c0d37d27074caa8c9987a9d03f20d72d03
Author: finnur <finnur@chromium.org>
Date: Thu Sep 08 11:35:52 2016

Site Settings Desktop: Fix issues with entering URL patterns.

BUG= 633682 ,  614277 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2309283002
Cr-Commit-Position: refs/heads/master@{#417254}

[modify] https://crrev.com/9c8075c0d37d27074caa8c9987a9d03f20d72d03/chrome/browser/resources/settings/site_settings/add_site_dialog.js
[modify] https://crrev.com/9c8075c0d37d27074caa8c9987a9d03f20d72d03/chrome/browser/resources/settings/site_settings/site_settings_behavior.js

Project Member

Comment 69 by bugdroid1@chromium.org, Sep 8 2016

Labels: merge-merged-2854
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c8075c0d37d27074caa8c9987a9d03f20d72d03

commit 9c8075c0d37d27074caa8c9987a9d03f20d72d03
Author: finnur <finnur@chromium.org>
Date: Thu Sep 08 11:35:52 2016

Site Settings Desktop: Fix issues with entering URL patterns.

BUG= 633682 ,  614277 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2309283002
Cr-Commit-Position: refs/heads/master@{#417254}

[modify] https://crrev.com/9c8075c0d37d27074caa8c9987a9d03f20d72d03/chrome/browser/resources/settings/site_settings/add_site_dialog.js
[modify] https://crrev.com/9c8075c0d37d27074caa8c9987a9d03f20d72d03/chrome/browser/resources/settings/site_settings/site_settings_behavior.js

Project Member

Comment 71 by bugdroid1@chromium.org, Sep 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1fbf113bd0f643517fbb0e6e5a7ac832605e2ccb

commit 1fbf113bd0f643517fbb0e6e5a7ac832605e2ccb
Author: finnur <finnur@chromium.org>
Date: Fri Sep 09 10:50:10 2016

Site Settings Desktop: Implement Zoom Levels category.

BUG= 635846 ,  614277 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2323693002
Cr-Commit-Position: refs/heads/master@{#417554}

[modify] https://crrev.com/1fbf113bd0f643517fbb0e6e5a7ac832605e2ccb/chrome/app/settings_strings.grdp
[modify] https://crrev.com/1fbf113bd0f643517fbb0e6e5a7ac832605e2ccb/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/1fbf113bd0f643517fbb0e6e5a7ac832605e2ccb/chrome/browser/resources/settings/route.js
[modify] https://crrev.com/1fbf113bd0f643517fbb0e6e5a7ac832605e2ccb/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/1fbf113bd0f643517fbb0e6e5a7ac832605e2ccb/chrome/browser/resources/settings/site_settings/compiled_resources2.gyp
[modify] https://crrev.com/1fbf113bd0f643517fbb0e6e5a7ac832605e2ccb/chrome/browser/resources/settings/site_settings/constants.js
[modify] https://crrev.com/1fbf113bd0f643517fbb0e6e5a7ac832605e2ccb/chrome/browser/resources/settings/site_settings/site_list.js
[modify] https://crrev.com/1fbf113bd0f643517fbb0e6e5a7ac832605e2ccb/chrome/browser/resources/settings/site_settings/site_settings_behavior.js
[modify] https://crrev.com/1fbf113bd0f643517fbb0e6e5a7ac832605e2ccb/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js
[add] https://crrev.com/1fbf113bd0f643517fbb0e6e5a7ac832605e2ccb/chrome/browser/resources/settings/site_settings/zoom_levels.html
[add] https://crrev.com/1fbf113bd0f643517fbb0e6e5a7ac832605e2ccb/chrome/browser/resources/settings/site_settings/zoom_levels.js
[modify] https://crrev.com/1fbf113bd0f643517fbb0e6e5a7ac832605e2ccb/chrome/browser/resources/settings/site_settings_page/site_settings_page.html
[modify] https://crrev.com/1fbf113bd0f643517fbb0e6e5a7ac832605e2ccb/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/1fbf113bd0f643517fbb0e6e5a7ac832605e2ccb/chrome/browser/ui/webui/settings/site_settings_handler.cc
[modify] https://crrev.com/1fbf113bd0f643517fbb0e6e5a7ac832605e2ccb/chrome/browser/ui/webui/settings/site_settings_handler.h
[modify] https://crrev.com/1fbf113bd0f643517fbb0e6e5a7ac832605e2ccb/chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc
[modify] https://crrev.com/1fbf113bd0f643517fbb0e6e5a7ac832605e2ccb/chrome/test/data/webui/settings/cr_settings_browsertest.js
[modify] https://crrev.com/1fbf113bd0f643517fbb0e6e5a7ac832605e2ccb/chrome/test/data/webui/settings/site_settings_category_tests.js
[modify] https://crrev.com/1fbf113bd0f643517fbb0e6e5a7ac832605e2ccb/chrome/test/data/webui/settings/test_site_settings_prefs_browser_proxy.js
[add] https://crrev.com/1fbf113bd0f643517fbb0e6e5a7ac832605e2ccb/chrome/test/data/webui/settings/zoom_levels_tests.js

 Issue 645814  has been merged into this issue.
Blockedon: 646309
Blockedon: 634039
Blockedon: 651657
Owner: dschuyler@chromium.org
Moving site settings bugs from finnur@ to dschuyler@.
Summary: [Site Settings] Missing site settings (was: Missing site settings)
Blockedon: -635860
Blockedon: -651657
Blockedon: -635858
Blockedon: -632618
Status: Fixed (was: Assigned)
The remaining bugs this was blocking on are independent of the bug's main topic. I've separated them and I'm marking this fixed.

Sign in to add a comment