New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 614276 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Hyperlink is not visible properly on "Floating for YouTube" app.

Reported by rk...@etouch.net, May 24 2016

Issue description

Chrome Version: 52.0.2743.3 Revision 8be70850ebcd3ec9433ba7606521c44009e96655-refs/branch-heads/2743@{#23}(32/64 bit)
OS: Windows(7,8,10)

URL: https://chrome.google.com/webstore/detail/floating-for-youtube/jjphmlaoffndcnecccgemfdaaoighkel?utm_source=chrome-app-launcher-info-dialog

What steps will reproduce the problem?
(1) Launch chrome,navigate to above url and click on 'ADD TO CHROME' button.
(2) Launch app, observe the hyperlink on app

Hyperlink is not visible properly.

Hyperlink should visible properly.

This is a regression issue,broken in ''M-51', below is bisect info:

Good Build: 51.0.2778.0
Bad Build: 51.0.2779.0

Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+log/005d3f2640e3aa72948e4bb236cc3254763f18e6..3b10a1079a38beda8b73f86352d5867d60d6e6f6?pretty=fuller&n=50

Suspecting: r381042 ?

Note: issue is not seen on Mac and Linux OS.
 
Actual_Screenshot.png
344 KB View Download
Labels: ReleaseBlock-Stable
Marking the above issue as RB-Stable as this needs to fixed before M52 goes to stable.

Thank you!
Cc: rnimmagadda@chromium.org
Just to update.

Able to repro this issue on Windows 7 for Google Chrome Canary Version - 53.0.2750.0 
Able to reproduce this issue on Windows 7 for Google Chrome Canary Version - 53.0.2751.0.

sky@ - Any update on this bug? Will you mind in checking if this issue is related to your change, If not please feel free to reassign to the concerned owner.

Thanks!  
Just to update 
Still seeing the issue on windows 7 using latest chrome version 53.0.2757.0.


M52 Stable is approaching soon. Please have a fix / revert ASAP.
Able to reproduce the issue on windows 7 using chrome latest version 53.0.2762.0 .

Sky@ Could you please look into this issue.

Thanks,

Comment 7 by ajha@chromium.org, Jun 14 2016

sky@: Is there any work in progress for this. Please adjust the blocker label if this is not blocking.

Comment 8 by gov...@chromium.org, Jun 16 2016

A friendly reminder that M52 Stable is launching soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch by July 12. All changes MUST be merged into the release branch by 5pm on July 15 to make into the desktop Stable final build cut. Thank you!
Just to update 
Still seeing the issue on windows 7 using latest M-53(53.0.2773.0).

sky@Could you please look into this issue.
Just to update.

Able to repro this issue on Windows 7 for Google Chrome Canary Version - 53.0.2774.3 
614276.png
39.1 KB View Download

Comment 11 Deleted

** IMPORTANT change in M52 merge date due to first 2 weeks of July no release weeks **
M52 Stable is launching very soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged ASAP. All changes MUST be merged into the release branch by 5pm on July 1 to make into the desktop Stable final build cut. Thank you!

Comment 13 by sky@chromium.org, Jun 27 2016

Cc: benwells@chromium.org lfg@chromium.org
Owner: sande...@chromium.org
I suspect I was assigned this because I'm in the regression range. My patch would not have impacted this code. Looking in the regression range I only see two possibilities:
sandersd: https://codereview.chromium.org/1784173005
lfg: https://codereview.chromium.org/1784873003

Are we sure the regression range is correct?
Randomly passing to sandersd and adding benwells as this is an app issue and hopefully he has an idea.
Labels: Needs-Bisect
Labels: -Pri-1 -ReleaseBlock-Stable Pri-2
I'm confused. Is the problem that the link is a little bit different to on Mac, or that the background is completely black?

If it is just that it is a bit different, it's probably just the different text rendering engines on the different platforms.

Lowering priority and removing RBS as based on my guess about what the issue is, it doesn't seem that bad or worthy of holding up stable.

I agree with sky that the regression range looks suspect.

Comment 16 by rk...@etouch.net, Jun 28 2016

Labels: -Needs-Bisect
With respect to comment 14:

Re-bisecting for the above issue and getting same bisect range.

@sky:  Please help me to reassign this issue if your change is not cause for it.
Project Member

Comment 17 by sheriffbot@chromium.org, Jun 28 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
rkot3: Can you clarify what the actual bug is? Is it that:

(a) the entire background is black (that seems like the real bug to me, but isn't what you described)

(b) that the blue link font on black background is hard to read (this doesn't seem like much of a bug to me, or course blue on black is hard to read).
benwells@: Please find the screen cast describing the issue, where the blue colored font on the black back-ground is not readable while compared to Mac the fonts are much bold and readable.  
614276_July_5.mp4
278 KB View Download
Status: WontFix (was: Assigned)
I don't think this is an actual bug. The app should choose a different background / foreground color combination or a different font.

Sign in to add a comment