New issue
Advanced search Search tips

Issue 614271 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

Update Chrome OS to new LSTM TTS voices

Project Member Reported by dmazz...@chromium.org, May 24 2016

Issue description

Google's TTS team has a new text-to-speech engine for us using LSTM (Long short-term-memory) Recurrent Neural Networks. Sizes are pretty similar, let's try to include the same set of 13 voices as part of Chrome OS natively.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/c25c800fa9d8a47cfa223b50918678bf20f5ebfb

commit c25c800fa9d8a47cfa223b50918678bf20f5ebfb
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Fri Jun 03 16:33:50 2016

Update speech synthesis ebuild rules to allow changes to voice file names

BUG= chromium:614271 
TEST=manual test using ChromeVox

Change-Id: Ife415ecfcd1bc9001e8503dd59d8251d91b7a433
Reviewed-on: https://chromium-review.googlesource.com/346900
Commit-Ready: Dominic Mazzoni <dmazzoni@chromium.org>
Tested-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>

[modify] https://crrev.com/c25c800fa9d8a47cfa223b50918678bf20f5ebfb/chromeos-base/common-assets/common-assets-9999.ebuild

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/assets/+/5fc15dee29d1d967ccc46071a732d802d3b34655

commit 5fc15dee29d1d967ccc46071a732d802d3b34655
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Tue May 24 06:35:28 2016

Upgrade Chrome OS speech synthesis with new LSTM synthesis engine and voices

BUG= chromium:614271 
TEST=manual testing using ChromeVox

Change-Id: I58208288c0fb81228602af6f362589335b69046c
Reviewed-on: https://chromium-review.googlesource.com/346805
Commit-Ready: Dominic Mazzoni <dmazzoni@chromium.org>
Tested-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>

[rename] https://crrev.com/5fc15dee29d1d967ccc46071a732d802d3b34655/speech_synthesis/patts/voice_lstm_en-GB.js
[modify] https://crrev.com/5fc15dee29d1d967ccc46071a732d802d3b34655/speech_synthesis/patts/tts_main.js
[add] https://crrev.com/5fc15dee29d1d967ccc46071a732d802d3b34655/speech_synthesis/patts/voice_lstm_pt-BR.zvoice
[modify] https://crrev.com/5fc15dee29d1d967ccc46071a732d802d3b34655/speech_synthesis/patts/manifest_guest.json
[rename] https://crrev.com/5fc15dee29d1d967ccc46071a732d802d3b34655/speech_synthesis/patts/voice_lstm_ko-KR.js
[rename] https://crrev.com/5fc15dee29d1d967ccc46071a732d802d3b34655/speech_synthesis/patts/voice_lstm_en-US.js
[modify] https://crrev.com/5fc15dee29d1d967ccc46071a732d802d3b34655/speech_synthesis/patts/tts_service_x86-64.nexe.zip
[rename] https://crrev.com/5fc15dee29d1d967ccc46071a732d802d3b34655/speech_synthesis/patts/voice_lstm_it-IT.js
[delete] https://crrev.com/20544c6751869f4ffdc205927cdc86c4e6404aab/speech_synthesis/patts/voice_data_hmm_id-ID.zvoice
[add] https://crrev.com/5fc15dee29d1d967ccc46071a732d802d3b34655/speech_synthesis/patts/voice_lstm_hi-IN.zvoice
[rename] https://crrev.com/5fc15dee29d1d967ccc46071a732d802d3b34655/speech_synthesis/patts/voice_lstm_es-ES.js
[add] https://crrev.com/5fc15dee29d1d967ccc46071a732d802d3b34655/speech_synthesis/patts/voice_lstm_id-ID.zvoice
[rename] https://crrev.com/5fc15dee29d1d967ccc46071a732d802d3b34655/speech_synthesis/patts/voice_lstm_nl-NL.js
[rename] https://crrev.com/5fc15dee29d1d967ccc46071a732d802d3b34655/speech_synthesis/patts/voice_lstm_pt-BR.js
[delete] https://crrev.com/20544c6751869f4ffdc205927cdc86c4e6404aab/speech_synthesis/patts/voice_data_hmm_pt-BR.zvoice
[add] https://crrev.com/5fc15dee29d1d967ccc46071a732d802d3b34655/speech_synthesis/patts/voice_lstm_en-IN.zvoice
[delete] https://crrev.com/20544c6751869f4ffdc205927cdc86c4e6404aab/speech_synthesis/patts/voice_data_hmm_es-US.zvoice
[delete] https://crrev.com/20544c6751869f4ffdc205927cdc86c4e6404aab/speech_synthesis/patts/voice_data_hmm_en-IN.zvoice
[add] https://crrev.com/5fc15dee29d1d967ccc46071a732d802d3b34655/speech_synthesis/patts/voice_lstm_ko-KR.zvoice
[delete] https://crrev.com/20544c6751869f4ffdc205927cdc86c4e6404aab/speech_synthesis/patts/voice_data_hmm_it-IT.zvoice
[delete] https://crrev.com/20544c6751869f4ffdc205927cdc86c4e6404aab/speech_synthesis/patts/voice_data_hmm_en-US.zvoice
[rename] https://crrev.com/5fc15dee29d1d967ccc46071a732d802d3b34655/speech_synthesis/patts/voice_lstm_es-US.js
[add] https://crrev.com/5fc15dee29d1d967ccc46071a732d802d3b34655/speech_synthesis/patts/voice_lstm_nl-NL.zvoice
[add] https://crrev.com/5fc15dee29d1d967ccc46071a732d802d3b34655/speech_synthesis/patts/voice_lstm_it-IT.zvoice
[delete] https://crrev.com/20544c6751869f4ffdc205927cdc86c4e6404aab/speech_synthesis/patts/voice_data_hmm_ko-KR.zvoice
[rename] https://crrev.com/5fc15dee29d1d967ccc46071a732d802d3b34655/speech_synthesis/patts/voice_lstm_fr-FR.js
[delete] https://crrev.com/20544c6751869f4ffdc205927cdc86c4e6404aab/speech_synthesis/patts/voice_data_hmm_hi-IN.zvoice
[delete] https://crrev.com/20544c6751869f4ffdc205927cdc86c4e6404aab/speech_synthesis/patts/voice_data_hmm_de-DE.zvoice
[rename] https://crrev.com/5fc15dee29d1d967ccc46071a732d802d3b34655/speech_synthesis/patts/voice_lstm_de-DE.js
[modify] https://crrev.com/5fc15dee29d1d967ccc46071a732d802d3b34655/speech_synthesis/patts/tts_service_x86-32.nexe.zip
[delete] https://crrev.com/20544c6751869f4ffdc205927cdc86c4e6404aab/speech_synthesis/patts/voice_data_hmm_es-ES.zvoice
[rename] https://crrev.com/5fc15dee29d1d967ccc46071a732d802d3b34655/speech_synthesis/patts/voice_lstm_en-IN.js
[add] https://crrev.com/5fc15dee29d1d967ccc46071a732d802d3b34655/speech_synthesis/patts/voice_lstm_es-ES.zvoice
[delete] https://crrev.com/20544c6751869f4ffdc205927cdc86c4e6404aab/speech_synthesis/patts/voice_data_hmm_fr-FR.zvoice
[add] https://crrev.com/5fc15dee29d1d967ccc46071a732d802d3b34655/speech_synthesis/patts/voice_lstm_en-US.zvoice
[add] https://crrev.com/5fc15dee29d1d967ccc46071a732d802d3b34655/speech_synthesis/patts/voice_lstm_fr-FR.zvoice
[modify] https://crrev.com/5fc15dee29d1d967ccc46071a732d802d3b34655/speech_synthesis/patts/manifest.json
[rename] https://crrev.com/5fc15dee29d1d967ccc46071a732d802d3b34655/speech_synthesis/patts/voice_lstm_hi-IN.js
[add] https://crrev.com/5fc15dee29d1d967ccc46071a732d802d3b34655/speech_synthesis/patts/voice_lstm_es-US.zvoice
[rename] https://crrev.com/5fc15dee29d1d967ccc46071a732d802d3b34655/speech_synthesis/patts/voice_lstm_id-ID.js
[modify] https://crrev.com/5fc15dee29d1d967ccc46071a732d802d3b34655/speech_synthesis/patts/tts_controller.js
[modify] https://crrev.com/5fc15dee29d1d967ccc46071a732d802d3b34655/speech_synthesis/patts/tts_service_arm.nexe.zip
[add] https://crrev.com/5fc15dee29d1d967ccc46071a732d802d3b34655/speech_synthesis/patts/voice_lstm_de-DE.zvoice
[delete] https://crrev.com/20544c6751869f4ffdc205927cdc86c4e6404aab/speech_synthesis/patts/voice_data_hmm_en-GB.zvoice
[add] https://crrev.com/5fc15dee29d1d967ccc46071a732d802d3b34655/speech_synthesis/patts/voice_lstm_en-GB.zvoice
[delete] https://crrev.com/20544c6751869f4ffdc205927cdc86c4e6404aab/speech_synthesis/patts/voice_data_hmm_nl-NL.zvoice

Cc: kathrelk...@chromium.org
Labels: -Pri-3 Pri-2
Status: Fixed (was: Started)
@kathrelkeld and @lpalmaro we've updated the TTS engine in M53 and I've tested it on Canary; could you please help sanity-check that nothing has regressed?

Would be worth checking:
* Each supported language (de, en, es, fr, hi, id, it, ko, np, pt-BR)
* Each architecture (x86, x86-64, ARM)
* Low-end devices (the new engine may require a bit more cpu)

We can poke at some of this during M53 FullRelease (early July-ish), but a detailed-scope check on various languages is out of our wheelhouse.

Laura, shall we kick off another LQA pass once M53 is in beta?
Any time before stable should be fine. If we find a showstopper we can just revert back to the previous engine safely. A detailed look at the languages isn't necessary. Thanks!

Status: Verified (was: Fixed)
M53 is well into stable with no major issues found.
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/assets/+/4c52693b101710d97295d5160db26d9f4a3fb93d

commit 4c52693b101710d97295d5160db26d9f4a3fb93d
Author: Dominic Mazzoni <dmazzoni@chromium.org>
Date: Wed Feb 22 17:36:09 2017

Upgrade Chrome OS speech synthesis with new LSTM synthesis engine and voices

The changes to the manifest and code .js files are the same as
5fc15dee29, which was reverted due to  http://crbug.com/659888  .
The speech engine (.nexe files) and voice data files are a new
build from upstream (February 2017), containing a fix for that bug
and numerous other improvements.

In particular, the regression was that word callbacks were broken,
and I've specifically tested that those are working in this build.

BUG= chromium:614271 
TEST=Manually tested using ChromeVox and TTS Demo from web store

Change-Id: Ibcd670fc69814b9dd7c6540813c995b6baacfc2b
Reviewed-on: https://chromium-review.googlesource.com/443133
Reviewed-by: Dan Erat <derat@chromium.org>
Tested-by: Dominic Mazzoni <dmazzoni@chromium.org>

[rename] https://crrev.com/4c52693b101710d97295d5160db26d9f4a3fb93d/speech_synthesis/patts/voice_lstm_en-GB.js
[modify] https://crrev.com/4c52693b101710d97295d5160db26d9f4a3fb93d/speech_synthesis/patts/tts_main.js
[add] https://crrev.com/4c52693b101710d97295d5160db26d9f4a3fb93d/speech_synthesis/patts/voice_lstm_pt-BR.zvoice
[modify] https://crrev.com/4c52693b101710d97295d5160db26d9f4a3fb93d/speech_synthesis/patts/manifest_guest.json
[rename] https://crrev.com/4c52693b101710d97295d5160db26d9f4a3fb93d/speech_synthesis/patts/voice_lstm_ko-KR.js
[rename] https://crrev.com/4c52693b101710d97295d5160db26d9f4a3fb93d/speech_synthesis/patts/voice_lstm_en-US.js
[modify] https://crrev.com/4c52693b101710d97295d5160db26d9f4a3fb93d/speech_synthesis/patts/tts_service_x86-64.nexe.zip
[rename] https://crrev.com/4c52693b101710d97295d5160db26d9f4a3fb93d/speech_synthesis/patts/voice_lstm_it-IT.js
[delete] https://crrev.com/240e6bd185241e1c2ecc19ecf1c763fd88752d7c/speech_synthesis/patts/voice_data_hmm_id-ID.zvoice
[add] https://crrev.com/4c52693b101710d97295d5160db26d9f4a3fb93d/speech_synthesis/patts/voice_lstm_hi-IN.zvoice
[rename] https://crrev.com/4c52693b101710d97295d5160db26d9f4a3fb93d/speech_synthesis/patts/voice_lstm_es-ES.js
[add] https://crrev.com/4c52693b101710d97295d5160db26d9f4a3fb93d/speech_synthesis/patts/voice_lstm_id-ID.zvoice
[rename] https://crrev.com/4c52693b101710d97295d5160db26d9f4a3fb93d/speech_synthesis/patts/voice_lstm_nl-NL.js
[rename] https://crrev.com/4c52693b101710d97295d5160db26d9f4a3fb93d/speech_synthesis/patts/voice_lstm_pt-BR.js
[delete] https://crrev.com/240e6bd185241e1c2ecc19ecf1c763fd88752d7c/speech_synthesis/patts/voice_data_hmm_pt-BR.zvoice
[add] https://crrev.com/4c52693b101710d97295d5160db26d9f4a3fb93d/speech_synthesis/patts/voice_lstm_en-IN.zvoice
[delete] https://crrev.com/240e6bd185241e1c2ecc19ecf1c763fd88752d7c/speech_synthesis/patts/voice_data_hmm_es-US.zvoice
[delete] https://crrev.com/240e6bd185241e1c2ecc19ecf1c763fd88752d7c/speech_synthesis/patts/voice_data_hmm_en-IN.zvoice
[add] https://crrev.com/4c52693b101710d97295d5160db26d9f4a3fb93d/speech_synthesis/patts/voice_lstm_ko-KR.zvoice
[delete] https://crrev.com/240e6bd185241e1c2ecc19ecf1c763fd88752d7c/speech_synthesis/patts/voice_data_hmm_it-IT.zvoice
[delete] https://crrev.com/240e6bd185241e1c2ecc19ecf1c763fd88752d7c/speech_synthesis/patts/voice_data_hmm_en-US.zvoice
[rename] https://crrev.com/4c52693b101710d97295d5160db26d9f4a3fb93d/speech_synthesis/patts/voice_lstm_es-US.js
[add] https://crrev.com/4c52693b101710d97295d5160db26d9f4a3fb93d/speech_synthesis/patts/voice_lstm_nl-NL.zvoice
[add] https://crrev.com/4c52693b101710d97295d5160db26d9f4a3fb93d/speech_synthesis/patts/voice_lstm_it-IT.zvoice
[delete] https://crrev.com/240e6bd185241e1c2ecc19ecf1c763fd88752d7c/speech_synthesis/patts/voice_data_hmm_ko-KR.zvoice
[rename] https://crrev.com/4c52693b101710d97295d5160db26d9f4a3fb93d/speech_synthesis/patts/voice_lstm_fr-FR.js
[delete] https://crrev.com/240e6bd185241e1c2ecc19ecf1c763fd88752d7c/speech_synthesis/patts/voice_data_hmm_hi-IN.zvoice
[delete] https://crrev.com/240e6bd185241e1c2ecc19ecf1c763fd88752d7c/speech_synthesis/patts/voice_data_hmm_de-DE.zvoice
[rename] https://crrev.com/4c52693b101710d97295d5160db26d9f4a3fb93d/speech_synthesis/patts/voice_lstm_de-DE.js
[modify] https://crrev.com/4c52693b101710d97295d5160db26d9f4a3fb93d/speech_synthesis/patts/tts_service_x86-32.nexe.zip
[delete] https://crrev.com/240e6bd185241e1c2ecc19ecf1c763fd88752d7c/speech_synthesis/patts/voice_data_hmm_es-ES.zvoice
[rename] https://crrev.com/4c52693b101710d97295d5160db26d9f4a3fb93d/speech_synthesis/patts/voice_lstm_en-IN.js
[add] https://crrev.com/4c52693b101710d97295d5160db26d9f4a3fb93d/speech_synthesis/patts/voice_lstm_es-ES.zvoice
[delete] https://crrev.com/240e6bd185241e1c2ecc19ecf1c763fd88752d7c/speech_synthesis/patts/voice_data_hmm_fr-FR.zvoice
[add] https://crrev.com/4c52693b101710d97295d5160db26d9f4a3fb93d/speech_synthesis/patts/voice_lstm_en-US.zvoice
[add] https://crrev.com/4c52693b101710d97295d5160db26d9f4a3fb93d/speech_synthesis/patts/voice_lstm_fr-FR.zvoice
[modify] https://crrev.com/4c52693b101710d97295d5160db26d9f4a3fb93d/speech_synthesis/patts/manifest.json
[rename] https://crrev.com/4c52693b101710d97295d5160db26d9f4a3fb93d/speech_synthesis/patts/voice_lstm_hi-IN.js
[add] https://crrev.com/4c52693b101710d97295d5160db26d9f4a3fb93d/speech_synthesis/patts/voice_lstm_es-US.zvoice
[rename] https://crrev.com/4c52693b101710d97295d5160db26d9f4a3fb93d/speech_synthesis/patts/voice_lstm_id-ID.js
[modify] https://crrev.com/4c52693b101710d97295d5160db26d9f4a3fb93d/speech_synthesis/patts/tts_controller.js
[modify] https://crrev.com/4c52693b101710d97295d5160db26d9f4a3fb93d/speech_synthesis/patts/tts_service_arm.nexe.zip
[add] https://crrev.com/4c52693b101710d97295d5160db26d9f4a3fb93d/speech_synthesis/patts/voice_lstm_de-DE.zvoice
[delete] https://crrev.com/240e6bd185241e1c2ecc19ecf1c763fd88752d7c/speech_synthesis/patts/voice_data_hmm_en-GB.zvoice
[add] https://crrev.com/4c52693b101710d97295d5160db26d9f4a3fb93d/speech_synthesis/patts/voice_lstm_en-GB.zvoice
[delete] https://crrev.com/240e6bd185241e1c2ecc19ecf1c763fd88752d7c/speech_synthesis/patts/voice_data_hmm_nl-NL.zvoice

Sign in to add a comment