server/hosts/abstract_ssh is leaking ssh master connections |
|||
Issue description
The close method of AbstractSSHHost cleans the ssh master connection and after that tries to execute a 'pkill -f ...' that creates an additional master connection that is never closed.
Steps To Reproduce:
import common
from autotest_lib.server import hosts
from server.cros.network import wifi_client
h = hosts.create_host('ip')
w = wifi_client.WiFiClient(h, './debug', False)
w.close()
Verify there is still one connection open:
ps aux | grep 'ip'
Expected Result:
0 connections open from ps aux output
Actual Result:
1 connection open
How frequently does this problem reproduce? (Always, sometimes, hard to
reproduce?)
Always
What is the impact to the user, and is there a workaround? If so, what is
it?
Ssh master connections will accumulate until the system become unstable
,
May 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/773179ec22d219d56ca02e18f295bb4350bccb45 commit 773179ec22d219d56ca02e18f295bb4350bccb45 Author: Godofredo Contreras <godofredoc@google.com> Date: Tue May 24 17:17:48 2016 Fix for leaked ssh master connections. AbstractSSHHost is cleaning the ssh master connection and then running "pkill" that opens a new master connection that is never closed. BUG= 614270 Change-Id: Ib42e01e478260aa9e429f80e6aa492232ae614bf Reviewed-on: https://chromium-review.googlesource.com/347070 Commit-Ready: Godofredo Contreras <godofredoc@chromium.org> Tested-by: Godofredo Contreras <godofredoc@chromium.org> Reviewed-by: Roshan Pius <rpius@chromium.org> Reviewed-by: Dan Shi <dshi@google.com> [modify] https://crrev.com/773179ec22d219d56ca02e18f295bb4350bccb45/server/hosts/abstract_ssh.py
,
Jun 10 2016
,
Jun 21 2016
As discussed with Godofredo, no manual testing required. Closing this as verified |
|||
►
Sign in to add a comment |
|||
Comment 1 by godofredoc@chromium.org
, May 24 2016