New issue
Advanced search Search tips

Issue 614265 link

Starred by 4 users
Status: Fixed
Owner:
dbeam@chromium.org
Closed: Dec 2016
Cc:
rdevlin....@chromium.org
tbuck...@chromium.org
bettes@chromium.org
steve...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 618561
issue 622681
issue 624420
issue 629604
Blocking:
issue 614588
issue 614589



Sign in to add a comment

Implement "controlled by" indicators (eg. enterprise policy, extension)

Project Member Reported by tbuck...@chromium.org, May 24 2016 
Spec: https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/specs#%2FSPEC-settings_tooltips.png%3Fz=width

We should show indicators in the same places/conditions as the old settings page. If more definition is needed, let me know who I can work with to capture the existing behavior.

Comment 1 by tbuck...@chromium.org, May 25 2016

Owner: dbeam@chromium.org
Status: Assigned (was: Available)

Comment 2 by dbeam@chromium.org, May 26 2016

Status: Started (was: Assigned)

Comment 3 by tbuck...@chromium.org, May 27 2016

Blocking: 614588 614589
Project Member

Comment 4 by bugdroid1@chromium.org, May 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/359d5c721bd4b767cd9964cf9b5a2e4f66e59f45

commit 359d5c721bd4b767cd9964cf9b5a2e4f66e59f45
Author: dbeam <dbeam@chromium.org>
Date: Fri May 27 21:50:15 2016

MD Settings: add <paper-tooltip> to show controlled indicators

R=michaelpg@chromium.org
BUG= 614265 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2013323002
Cr-Commit-Position: refs/heads/master@{#396571}

[modify] https://crrev.com/359d5c721bd4b767cd9964cf9b5a2e4f66e59f45/third_party/polymer/v1_0/bower.json
[add] https://crrev.com/359d5c721bd4b767cd9964cf9b5a2e4f66e59f45/third_party/polymer/v1_0/components-chromium/paper-tooltip/bower.json
[add] https://crrev.com/359d5c721bd4b767cd9964cf9b5a2e4f66e59f45/third_party/polymer/v1_0/components-chromium/paper-tooltip/compiled_resources2.gyp
[add] https://crrev.com/359d5c721bd4b767cd9964cf9b5a2e4f66e59f45/third_party/polymer/v1_0/components-chromium/paper-tooltip/paper-tooltip-extracted.js
[add] https://crrev.com/359d5c721bd4b767cd9964cf9b5a2e4f66e59f45/third_party/polymer/v1_0/components-chromium/paper-tooltip/paper-tooltip.html
[modify] https://crrev.com/359d5c721bd4b767cd9964cf9b5a2e4f66e59f45/third_party/polymer/v1_0/components_summary.txt
[modify] https://crrev.com/359d5c721bd4b767cd9964cf9b5a2e4f66e59f45/ui/webui/resources/polymer_resources.grdp
Project Member

Comment 5 by bugdroid1@chromium.org, May 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a67b4e040e5618f4ff21a64c3c2a813f17af87a4

commit a67b4e040e5618f4ff21a64c3c2a813f17af87a4
Author: dbeam <dbeam@chromium.org>
Date: Fri May 27 22:43:37 2016

MD Settings: implement "controlled by" indicator UI

R=michaelpg@chromium.org
BUG= 614265 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2019563002
Cr-Commit-Position: refs/heads/master@{#396588}

[modify] https://crrev.com/a67b4e040e5618f4ff21a64c3c2a813f17af87a4/ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.html

Comment 6 by dbeam@chromium.org, May 27 2016

Status: Fixed (was: Started)

Comment 7 by tbuck...@chromium.org, May 30 2016

Status: Assigned (was: Fixed)
@dbeam does this include adding the controlled-by indicators throughout settings?

Comment 8 by dbeam@chromium.org, May 31 2016 

right now there are icon buttons with tooltips for every checkbox.

do we have "controlled by X" indicators that aren't next to pref-based checkboxes?  i assume yes as you re-opened this?

Comment 9 by dbeam@chromium.org, Jun 4 2016

Cc: tbuck...@chromium.org
alright, here's a list of all the controlled settings that I could find in old chrome://settings:
https://docs.google.com/document/d/1Y7froYqLdNVmEAJkM6N-CITRSocK3oJPLDDekWmAL9k/edit

that doesn't mean it's the end-all, but it's a good start

Comment 12 by tbuck...@chromium.org, Jun 23 2016

Blockedon: 622681

Comment 13 by tbuck...@chromium.org, Jun 30 2016

Blockedon: 624420

Comment 14 by dbeam@chromium.org, Jul 18 2016

Blockedon: 618561
bettes@: here's some examples of <button>, <input type="radio">, and <select> from the previous settings page

I don't think any of those have defined mocks yet.
2016-07-18-140450_337x146_scrot.png
13.4 KB View Download
2016-07-18-140723_366x135_scrot.png
9.7 KB View Download
2016-07-18-140728_336x121_scrot.png
9.1 KB View Download
2016-07-18-141013_397x91_scrot.png
8.9 KB View Download
2016-07-18-141026_559x107_scrot.png
11.6 KB View Download
2016-07-18-141031_573x131_scrot.png
15.7 KB View Download

Comment 15 by dbeam@chromium.org, Jul 18 2016 

oh, and here's one showing how the default search engine /row/ looks
2016-07-18-140457_717x281_scrot.png
32.0 KB View Download

Comment 16 by bettes@chromium.org, Jul 18 2016 

0.6 alpha for all disabled text and components.

Comment 17 by dbeam@chromium.org, Jul 18 2016

Cc: rdevlin....@chromium.org
here's some examples of extension-controlled UIs

note: if the extension is installed by policy (and therefore can't be disabled), all these "Disable extension" buttons are useless and don't work :(
extension_controlled_homepage.png
19.2 KB View Download
extension_controlled_startup_pages.png
14.7 KB View Download
extension_controlled_ntp.png
15.3 KB View Download
extension_controlled_proxy.png
8.5 KB View Download
extension_controlled_search_engines.png
15.4 KB View Download
extension_controlled_search_engines_dialog.png
36.1 KB View Download

Comment 18 by rdevlin....@chromium.org, Jul 19 2016 

Could we sub out "disable" for a note that it's installed by policy and the handy policy icon indicator?

Comment 19 by dbeam@chromium.org, Jul 19 2016 

yeah, we should show something like that (or worst case just hide the useless button, but that doesn't make the "why?" story very clear)

Comment 20 by dbeam@chromium.org, Jul 19 2016

Status: Started (was: Assigned)

Comment 21 by dbeam@chromium.org, Jul 19 2016

Blockedon: 629604
Project Member

Comment 23 by bugdroid1@chromium.org, Jul 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78bc682de08a15933cdbe62f724c804dbb493eb8

commit 78bc682de08a15933cdbe62f724c804dbb493eb8
Author: dbeam <dbeam@chromium.org>
Date: Wed Jul 27 13:03:25 2016

MD Settings: make .{primary,secondary,tertiary}-button selectors less specific

This is so theyll work with other tag names (i.e. <controlled-button>),
not just <paper-button>.

R=stevenjb@chromium.org
BUG= 614265 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2177283007
Cr-Commit-Position: refs/heads/master@{#408105}

[modify] https://crrev.com/78bc682de08a15933cdbe62f724c804dbb493eb8/chrome/browser/resources/settings/settings_shared_css.html
Project Member

Comment 24 by bugdroid1@chromium.org, Jul 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d90c9872868d1316fc2bc74e35abf50a22c825ef

commit d90c9872868d1316fc2bc74e35abf50a22c825ef
Author: dbeam <dbeam@chromium.org>
Date: Fri Jul 29 04:43:45 2016

MD Settings: made proxy button respect policy

R=stevenjb@chromium.org
BUG= 614265 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2180393002
Cr-Commit-Position: refs/heads/master@{#408578}

[modify] https://crrev.com/d90c9872868d1316fc2bc74e35abf50a22c825ef/chrome/browser/extensions/api/settings_private/prefs_util.cc
[modify] https://crrev.com/d90c9872868d1316fc2bc74e35abf50a22c825ef/chrome/browser/resources/settings/system_page/system_page.html
Project Member

Comment 25 by bugdroid1@chromium.org, Aug 4 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff2144883b2063fa79b38a99d27a4f270a934993

commit ff2144883b2063fa79b38a99d27a4f270a934993
Author: dbeam <dbeam@chromium.org>
Date: Thu Aug 04 23:22:36 2016

MD Settings: add a <controlled-radio-button>

It's a new control (currently in settings) that wraps a
<paper-radio-button> and a <cr-pref-policy-indicator> and magically
manages whether the radio button is controlled/disabled and whether the
indicator should show (when the pref is controlled and this specific
option is the effective value).

Because <controlled-radio-button> internally depends on settings-shared
styles, I didn't need to change:

  paper-radio-button {

selectors to:

  paper-radio-button,
  controlled-radio-button {

as I had to with <controlled-button> (as selectors like
paper-button.primary-button specifically made assumptions about tag
names).

I also had to update what <settings-radio-group> considers selectable.

Q: Which {paper,settings,controlled}-radio* thing should I use?

A: If a radio group is backed by a managable pref (ex: use NTP as homepage,
what to do on startup), it should use:

  <settings-radio-group pref="...">
    <controlled-radio-button name="..." pref="...">

If radio group displays a pref but there's no policy to manage it (ex:
device scrolling mode):

  <settings-radio-group pref="...">
    <paper-radio-button name="...">

If a radio group doesn't deal with a pref at all (ex: channel switcher):

  <paper-radio-group>
    <paper-radio-button name="...">

R=stevenjb@chromium.org
BUG= 614265 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2210063002
Cr-Commit-Position: refs/heads/master@{#409929}

[modify] https://crrev.com/ff2144883b2063fa79b38a99d27a4f270a934993/chrome/browser/resources/settings/about_page/channel_switcher_dialog.html
[modify] https://crrev.com/ff2144883b2063fa79b38a99d27a4f270a934993/chrome/browser/resources/settings/appearance_page/appearance_page.html
[add] https://crrev.com/ff2144883b2063fa79b38a99d27a4f270a934993/chrome/browser/resources/settings/controls/controlled_radio_button.html
[add] https://crrev.com/ff2144883b2063fa79b38a99d27a4f270a934993/chrome/browser/resources/settings/controls/controlled_radio_button.js
[modify] https://crrev.com/ff2144883b2063fa79b38a99d27a4f270a934993/chrome/browser/resources/settings/controls/settings_radio_group.html
[modify] https://crrev.com/ff2144883b2063fa79b38a99d27a4f270a934993/chrome/browser/resources/settings/controls/settings_radio_group.js
[modify] https://crrev.com/ff2144883b2063fa79b38a99d27a4f270a934993/chrome/browser/resources/settings/on_startup_page/on_startup_page.html
[modify] https://crrev.com/ff2144883b2063fa79b38a99d27a4f270a934993/chrome/browser/resources/settings/on_startup_page/startup_urls_page.html
[modify] https://crrev.com/ff2144883b2063fa79b38a99d27a4f270a934993/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/ff2144883b2063fa79b38a99d27a4f270a934993/chrome/test/data/webui/settings/cr_settings_browsertest.js
[delete] https://crrev.com/f9a1b4004496079bc1e4a2bd82c8f8fffd001281/chrome/test/data/webui/settings/radio_group_tests.js
Project Member

Comment 28 by bugdroid1@chromium.org, Aug 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bef36761c97f07ef87860cbd2c2cedecc3b29467

commit bef36761c97f07ef87860cbd2c2cedecc3b29467
Author: dbeam <dbeam@chromium.org>
Date: Fri Aug 05 04:36:45 2016

MD Settings: closure compile <controlled-radio-button>

R=stevenjb@chromium.org
BUG= 614265 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2216053002
Cr-Commit-Position: refs/heads/master@{#409990}

[modify] https://crrev.com/bef36761c97f07ef87860cbd2c2cedecc3b29467/chrome/browser/resources/settings/controls/compiled_resources2.gyp
Project Member

Comment 29 by bugdroid1@chromium.org, Aug 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a620af406275d8e5bf37832661f773ec60f3802a

commit a620af406275d8e5bf37832661f773ec60f3802a
Author: dbeam <dbeam@chromium.org>
Date: Thu Aug 11 06:09:20 2016

MD Settings: implement metrics reporting checkbox on desktop

BUG= 614265 , 632443 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2233443002
Cr-Commit-Position: refs/heads/master@{#411276}

[modify] https://crrev.com/a620af406275d8e5bf37832661f773ec60f3802a/chrome/browser/metrics/chrome_metrics_service_accessor.h
[modify] https://crrev.com/a620af406275d8e5bf37832661f773ec60f3802a/chrome/browser/resources/settings/privacy_page/compiled_resources2.gyp
[modify] https://crrev.com/a620af406275d8e5bf37832661f773ec60f3802a/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/a620af406275d8e5bf37832661f773ec60f3802a/chrome/browser/resources/settings/privacy_page/privacy_page.js
[modify] https://crrev.com/a620af406275d8e5bf37832661f773ec60f3802a/chrome/browser/resources/settings/privacy_page/privacy_page_browser_proxy.js
[modify] https://crrev.com/a620af406275d8e5bf37832661f773ec60f3802a/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/a620af406275d8e5bf37832661f773ec60f3802a/chrome/browser/ui/webui/settings/md_settings_ui.cc
[add] https://crrev.com/a620af406275d8e5bf37832661f773ec60f3802a/chrome/browser/ui/webui/settings/metrics_reporting_handler.cc
[add] https://crrev.com/a620af406275d8e5bf37832661f773ec60f3802a/chrome/browser/ui/webui/settings/metrics_reporting_handler.h
[add] https://crrev.com/a620af406275d8e5bf37832661f773ec60f3802a/chrome/browser/ui/webui/settings/metrics_reporting_handler_unittest.cc
[modify] https://crrev.com/a620af406275d8e5bf37832661f773ec60f3802a/chrome/chrome_browser_ui.gypi
[modify] https://crrev.com/a620af406275d8e5bf37832661f773ec60f3802a/chrome/chrome_tests_unit.gypi
[modify] https://crrev.com/a620af406275d8e5bf37832661f773ec60f3802a/chrome/test/data/webui/settings/cr_settings_browsertest.js
[add] https://crrev.com/a620af406275d8e5bf37832661f773ec60f3802a/chrome/test/data/webui/settings/metrics_reporting_tests.js
[modify] https://crrev.com/a620af406275d8e5bf37832661f773ec60f3802a/ui/webui/resources/cr_elements/policy/cr_policy_indicator.css
[modify] https://crrev.com/a620af406275d8e5bf37832661f773ec60f3802a/ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.html
[modify] https://crrev.com/a620af406275d8e5bf37832661f773ec60f3802a/ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.js
[add] https://crrev.com/a620af406275d8e5bf37832661f773ec60f3802a/ui/webui/resources/cr_elements/policy/cr_policy_vars_css.html
[modify] https://crrev.com/a620af406275d8e5bf37832661f773ec60f3802a/ui/webui/resources/cr_elements_resources.grdp

Comment 30 by michae...@chromium.org, Sep 20 2016

Blockedon: 648498

Comment 31 by steve...@chromium.org, Oct 21 2016 

Do we have new mocks for the extension-controlled UIs mentioned in #17 ?

In particular, there is an otherwise empty "Proxy" section that is only shown if this warning is visible. This exists on all platforms.

Comment 32 by dbeam@chromium.org, Oct 24 2016

Cc: dbeam@chromium.org
Owner: bettes@chromium.org
yeah, we need mocks for this still, I think.

I don't remember if I talked with bettes@ about this last Tuesday (my most recent day in the office) or if I just thought about it.

But either way, bettes@: we need some mocks for this.  see comment 17 for what it looks like in old options.

note: material design discourages rich content in tooltips (what policy does).

Comment 33 by bettes@chromium.org, Oct 24 2016

Labels: -Pri-2 Pri-1

Comment 34 by bettes@chromium.org, Oct 24 2016

Cc: bettes@chromium.org
 Issue 641664  has been merged into this issue.

Comment 35 by dbeam@chromium.org, Oct 29 2016 

Alan!! help me get implemented!

- this bug

Comment 36 by bettes@chromium.org, Nov 4 2016 

Let's create a new row for extension management, with DISABLE as the action button. Hyperlink the extension name to direct people to chrome://extensions. Use the extension icon, and the CWS icon if none is available (?).  

For extension management enacted by policy, place the building at the end of the string. 


Specs
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/specs#%2FSPEC-settings_mgmt.png%3Fz=width

Preview
https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Inner%20Pages/03-Settings/preview/cards#%2FPREVIEW__mgmt.png%3Fz=width
Screen Shot 2016-11-04 at 12.01.38 PM.png
98.0 KB View Download

Comment 37 by bettes@chromium.org, Nov 4 2016

Owner: dbeam@chromium.org
Status: Assigned (was: Started)

Comment 38 by dbeam@chromium.org, Nov 4 2016

Status: Started (was: Assigned)

Comment 39 by dbeam@chromium.org, Nov 10 2016

Cc: -dbeam@chromium.org steve...@chromium.org
Project Member

Comment 40 by bugdroid1@chromium.org, Nov 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/455f3cce3da21f8e677100b0c0abd8d35e24876e

commit 455f3cce3da21f8e677100b0c0abd8d35e24876e
Author: dbeam <dbeam@chromium.org>
Date: Thu Nov 17 02:08:29 2016

MD Settings: clarify "controlled by" logic

Before, we were using PrefService::Preference::IsExtensionControlled()
to determine if a pref was controlled by an extension. But, as far as I
can tell, that determines if a pref was *registered* by an extension.

What we want to know is whether an extension was installed (either by a
user or by policy) that overrides a function pref value. I re-used the
same code that /options/ used, which is a complicated mixture of enums,
manifest sniffing, and pref filtering. But it works. I've added a small
shim to re-use that from settings, based on pref name. It's not amazing,
but it'll work for now.

What next?

Well, this turns off extension puzzle piece icons and tooltips. This CL
also plumbs more information about whether an extension can be disabled
(a major shortcoming of the old UI, as disable buttons don't work in
some cases).

Next step: show a separate row-like UI.  See  crbug.com/614265#c36 .

R=stevenjb@chromium.org
BUG= 614265 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2479973002
Cr-Commit-Position: refs/heads/master@{#432704}

[modify] https://crrev.com/455f3cce3da21f8e677100b0c0abd8d35e24876e/chrome/browser/extensions/api/settings_private/prefs_util.cc
[modify] https://crrev.com/455f3cce3da21f8e677100b0c0abd8d35e24876e/chrome/browser/extensions/api/settings_private/prefs_util.h
[modify] https://crrev.com/455f3cce3da21f8e677100b0c0abd8d35e24876e/chrome/browser/extensions/settings_api_helpers.cc
[modify] https://crrev.com/455f3cce3da21f8e677100b0c0abd8d35e24876e/chrome/browser/extensions/settings_api_helpers.h
[modify] https://crrev.com/455f3cce3da21f8e677100b0c0abd8d35e24876e/chrome/browser/resources/settings/controls/controlled_button.js
[modify] https://crrev.com/455f3cce3da21f8e677100b0c0abd8d35e24876e/chrome/browser/resources/settings/controls/settings_checkbox.html
[modify] https://crrev.com/455f3cce3da21f8e677100b0c0abd8d35e24876e/chrome/browser/resources/settings/controls/settings_input.html
[modify] https://crrev.com/455f3cce3da21f8e677100b0c0abd8d35e24876e/chrome/browser/resources/settings/controls/settings_toggle_button.html
[modify] https://crrev.com/455f3cce3da21f8e677100b0c0abd8d35e24876e/chrome/browser/resources/settings/date_time_page/date_time_page.js
[modify] https://crrev.com/455f3cce3da21f8e677100b0c0abd8d35e24876e/chrome/browser/ui/webui/options/browser_options_handler.cc
[modify] https://crrev.com/455f3cce3da21f8e677100b0c0abd8d35e24876e/chrome/browser/ui/webui/policy_indicator_localized_strings_provider.cc
[modify] https://crrev.com/455f3cce3da21f8e677100b0c0abd8d35e24876e/chrome/common/extensions/api/settings_private.idl
[modify] https://crrev.com/455f3cce3da21f8e677100b0c0abd8d35e24876e/chrome/test/data/webui/settings/controlled_button_tests.js
[modify] https://crrev.com/455f3cce3da21f8e677100b0c0abd8d35e24876e/chrome/test/data/webui/settings/controlled_radio_button_tests.js
[modify] https://crrev.com/455f3cce3da21f8e677100b0c0abd8d35e24876e/third_party/closure_compiler/externs/settings_private.js
[modify] https://crrev.com/455f3cce3da21f8e677100b0c0abd8d35e24876e/third_party/closure_compiler/interfaces/settings_private_interface.js
[modify] https://crrev.com/455f3cce3da21f8e677100b0c0abd8d35e24876e/ui/webui/resources/cr_elements/policy/cr_policy_indicator_behavior.js
[modify] https://crrev.com/455f3cce3da21f8e677100b0c0abd8d35e24876e/ui/webui/resources/cr_elements/policy/cr_policy_pref_behavior.js
[modify] https://crrev.com/455f3cce3da21f8e677100b0c0abd8d35e24876e/ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.js
Project Member

Comment 41 by bugdroid1@chromium.org, Nov 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a36353a53249a1820b6ae8c2ebb1e81e51ac30d

commit 0a36353a53249a1820b6ae8c2ebb1e81e51ac30d
Author: Dan Beam <dbeam@chromium.org>
Date: Thu Nov 17 04:35:59 2016

MD Settings: create a shared handler/browser proxy to control extensions

Will be used by extension controlled indicator in an upcoming CL.

R=tommycli@chromium.org
BUG= 614265 

Review URL: https://codereview.chromium.org/2509543002 .

Cr-Commit-Position: refs/heads/master@{#432742}

[modify] https://crrev.com/0a36353a53249a1820b6ae8c2ebb1e81e51ac30d/chrome/browser/resources/settings/compiled_resources2.gyp
[add] https://crrev.com/0a36353a53249a1820b6ae8c2ebb1e81e51ac30d/chrome/browser/resources/settings/extension_control_browser_proxy.html
[add] https://crrev.com/0a36353a53249a1820b6ae8c2ebb1e81e51ac30d/chrome/browser/resources/settings/extension_control_browser_proxy.js
[modify] https://crrev.com/0a36353a53249a1820b6ae8c2ebb1e81e51ac30d/chrome/browser/resources/settings/search_engines_page/compiled_resources2.gyp
[modify] https://crrev.com/0a36353a53249a1820b6ae8c2ebb1e81e51ac30d/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html
[modify] https://crrev.com/0a36353a53249a1820b6ae8c2ebb1e81e51ac30d/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.js
[modify] https://crrev.com/0a36353a53249a1820b6ae8c2ebb1e81e51ac30d/chrome/browser/resources/settings/search_engines_page/search_engines_browser_proxy.js
[modify] https://crrev.com/0a36353a53249a1820b6ae8c2ebb1e81e51ac30d/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/0a36353a53249a1820b6ae8c2ebb1e81e51ac30d/chrome/browser/ui/BUILD.gn
[add] https://crrev.com/0a36353a53249a1820b6ae8c2ebb1e81e51ac30d/chrome/browser/ui/webui/settings/extension_control_handler.cc
[add] https://crrev.com/0a36353a53249a1820b6ae8c2ebb1e81e51ac30d/chrome/browser/ui/webui/settings/extension_control_handler.h
[modify] https://crrev.com/0a36353a53249a1820b6ae8c2ebb1e81e51ac30d/chrome/browser/ui/webui/settings/md_settings_ui.cc
[modify] https://crrev.com/0a36353a53249a1820b6ae8c2ebb1e81e51ac30d/chrome/browser/ui/webui/settings/search_engines_handler.cc
[modify] https://crrev.com/0a36353a53249a1820b6ae8c2ebb1e81e51ac30d/chrome/browser/ui/webui/settings/search_engines_handler.h
[modify] https://crrev.com/0a36353a53249a1820b6ae8c2ebb1e81e51ac30d/chrome/test/data/webui/settings/cr_settings_browsertest.js
[modify] https://crrev.com/0a36353a53249a1820b6ae8c2ebb1e81e51ac30d/chrome/test/data/webui/settings/search_engines_page_test.js
[add] https://crrev.com/0a36353a53249a1820b6ae8c2ebb1e81e51ac30d/chrome/test/data/webui/settings/test_extension_control_browser_proxy.js
[modify] https://crrev.com/0a36353a53249a1820b6ae8c2ebb1e81e51ac30d/chrome/test/data/webui/settings/test_search_engines_browser_proxy.js
Project Member

Comment 42 by bugdroid1@chromium.org, Nov 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d3df9aeeedfdc4e57e3450f3cc6168037766609

commit 9d3df9aeeedfdc4e57e3450f3cc6168037766609
Author: Dan Beam <dbeam@chromium.org>
Date: Thu Nov 17 05:28:47 2016

Implement extension controlled indicators, starting with New Tab page

R=dpapad@chromium.org
BUG= 614265 

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
NOTRY=true  # fixed a merge, see patchset 3

Review URL: https://codereview.chromium.org/2507003005 .

Cr-Commit-Position: refs/heads/master@{#432764}

[modify] https://crrev.com/9d3df9aeeedfdc4e57e3450f3cc6168037766609/chrome/app/generated_resources.grd
[modify] https://crrev.com/9d3df9aeeedfdc4e57e3450f3cc6168037766609/chrome/app/settings_strings.grdp
[modify] https://crrev.com/9d3df9aeeedfdc4e57e3450f3cc6168037766609/chrome/browser/resources/settings/controls/compiled_resources2.gyp
[add] https://crrev.com/9d3df9aeeedfdc4e57e3450f3cc6168037766609/chrome/browser/resources/settings/controls/extension_controlled_indicator.html
[add] https://crrev.com/9d3df9aeeedfdc4e57e3450f3cc6168037766609/chrome/browser/resources/settings/controls/extension_controlled_indicator.js
[modify] https://crrev.com/9d3df9aeeedfdc4e57e3450f3cc6168037766609/chrome/browser/resources/settings/on_startup_page/compiled_resources2.gyp
[add] https://crrev.com/9d3df9aeeedfdc4e57e3450f3cc6168037766609/chrome/browser/resources/settings/on_startup_page/on_startup_browser_proxy.html
[add] https://crrev.com/9d3df9aeeedfdc4e57e3450f3cc6168037766609/chrome/browser/resources/settings/on_startup_page/on_startup_browser_proxy.js
[modify] https://crrev.com/9d3df9aeeedfdc4e57e3450f3cc6168037766609/chrome/browser/resources/settings/on_startup_page/on_startup_page.html
[modify] https://crrev.com/9d3df9aeeedfdc4e57e3450f3cc6168037766609/chrome/browser/resources/settings/on_startup_page/on_startup_page.js
[modify] https://crrev.com/9d3df9aeeedfdc4e57e3450f3cc6168037766609/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/9d3df9aeeedfdc4e57e3450f3cc6168037766609/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/9d3df9aeeedfdc4e57e3450f3cc6168037766609/chrome/browser/ui/webui/policy_indicator_localized_strings_provider.cc
[modify] https://crrev.com/9d3df9aeeedfdc4e57e3450f3cc6168037766609/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/9d3df9aeeedfdc4e57e3450f3cc6168037766609/chrome/browser/ui/webui/settings/md_settings_ui.cc
[add] https://crrev.com/9d3df9aeeedfdc4e57e3450f3cc6168037766609/chrome/browser/ui/webui/settings/on_startup_handler.cc
[add] https://crrev.com/9d3df9aeeedfdc4e57e3450f3cc6168037766609/chrome/browser/ui/webui/settings/on_startup_handler.h

Comment 43 by dschuyler@chromium.org, Nov 17 2016

Blockedon: 662596
Project Member

Comment 45 by bugdroid1@chromium.org, Nov 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bdd3118a4e135f542c9b43af8b39b3a9957b00ce

commit bdd3118a4e135f542c9b43af8b39b3a9957b00ce
Author: dbeam <dbeam@chromium.org>
Date: Fri Nov 18 03:40:25 2016

MD Settings: add extension-controlled indicator to homepage

R=dpapad@chromium.org
BUG= 614265 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2516503002
Cr-Commit-Position: refs/heads/master@{#433066}

[modify] https://crrev.com/bdd3118a4e135f542c9b43af8b39b3a9957b00ce/chrome/browser/resources/settings/appearance_page/appearance_page.html
[modify] https://crrev.com/bdd3118a4e135f542c9b43af8b39b3a9957b00ce/chrome/browser/resources/settings/appearance_page/appearance_page.js
Project Member

Comment 46 by bugdroid1@chromium.org, Nov 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/696a7dd93480b82519ceefb404d96abeba0f02e7

commit 696a7dd93480b82519ceefb404d96abeba0f02e7
Author: dbeam <dbeam@chromium.org>
Date: Sat Nov 19 03:29:57 2016

MD Settings: implement support for extension-controlled startup URLs

R=dpapad@chromium.org
BUG= 614265 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2520573002
Cr-Commit-Position: refs/heads/master@{#433390}

[modify] https://crrev.com/696a7dd93480b82519ceefb404d96abeba0f02e7/chrome/browser/extensions/api/settings_private/prefs_util.cc
[modify] https://crrev.com/696a7dd93480b82519ceefb404d96abeba0f02e7/chrome/browser/resources/settings/controls/compiled_resources2.gyp
[modify] https://crrev.com/696a7dd93480b82519ceefb404d96abeba0f02e7/chrome/browser/resources/settings/controls/controlled_radio_button.html
[modify] https://crrev.com/696a7dd93480b82519ceefb404d96abeba0f02e7/chrome/browser/resources/settings/controls/controlled_radio_button.js
[modify] https://crrev.com/696a7dd93480b82519ceefb404d96abeba0f02e7/chrome/browser/resources/settings/on_startup_page/on_startup_page.html
[modify] https://crrev.com/696a7dd93480b82519ceefb404d96abeba0f02e7/chrome/browser/resources/settings/on_startup_page/startup_url_entry.html
[modify] https://crrev.com/696a7dd93480b82519ceefb404d96abeba0f02e7/chrome/browser/resources/settings/on_startup_page/startup_url_entry.js
[modify] https://crrev.com/696a7dd93480b82519ceefb404d96abeba0f02e7/chrome/browser/resources/settings/on_startup_page/startup_urls_page.html
[modify] https://crrev.com/696a7dd93480b82519ceefb404d96abeba0f02e7/chrome/browser/resources/settings/on_startup_page/startup_urls_page.js
[modify] https://crrev.com/696a7dd93480b82519ceefb404d96abeba0f02e7/chrome/test/data/webui/settings/startup_urls_page_test.js
Project Member

Comment 49 by bugdroid1@chromium.org, Dec 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebca4c2dfacabe8c38cf4d7122f18334aced2f7f

commit ebca4c2dfacabe8c38cf4d7122f18334aced2f7f
Author: dbeam <dbeam@chromium.org>
Date: Fri Dec 02 01:05:38 2016

MD Settings: fix appearance of managed metrics reporting checkbox

TBR=dpapad@chromium.org
BUG= 614265 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2535173007
Cr-Commit-Position: refs/heads/master@{#435800}

[modify] https://crrev.com/ebca4c2dfacabe8c38cf4d7122f18334aced2f7f/chrome/browser/resources/settings/privacy_page/privacy_page.html
Project Member

Comment 51 by bugdroid1@chromium.org, Dec 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/119a280cbd120b06bd7ce82f890624de5ca57e13

commit 119a280cbd120b06bd7ce82f890624de5ca57e13
Author: dbeam <dbeam@chromium.org>
Date: Sat Dec 03 00:45:54 2016

MD Settings: simplify spelling service toggle and make it respect policy

R=dschuyler@chromium.org
BUG= 614265 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2544453003
Cr-Commit-Position: refs/heads/master@{#436106}

[modify] https://crrev.com/119a280cbd120b06bd7ce82f890624de5ca57e13/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/119a280cbd120b06bd7ce82f890624de5ca57e13/chrome/browser/resources/settings/privacy_page/privacy_page.js

Comment 53 by dbeam@chromium.org, Dec 8 2016

Blockedon: -662596 -648498
Status: Fixed (was: Started)
removing specific, targeted issues (as the majority of this is done) and marking this bug fixed
►

Sign in to add a comment