New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 614262 link

Starred by 2 users
Status: Fixed
Owner:
wangxianzhu@chromium.org
Closed: May 2016
Cc:
█ brajkumar@chromium.org
█ rnimmagadda@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug-Regression



Sign in to add a comment

while printing unordered list with style number, if list item starts with <br/> list number is missing

Reported by sai.sail...@gmail.com, May 24 2016 
Chrome Version       : Version 50.0.2661.102 m
URLs (if applicable) :
Other browsers tested:
  Add OK or FAIL, along with the version, after other browsers where you
have tested this issue:

    Firefox: OK (45.0)
         IE: OK (IE 11)

Open the attachment in chrome and Print it. Can see number "1" is missing.
Open IE or Firefox and print. Can see number not missing.
Print_UL_Number_Missing.html
772 bytes View Download

Comment 1 by brajkumar@chromium.org, May 25 2016

Cc: brajkumar@chromium.org
Labels: -Type-Bug hasbisect M-52 OS-Linux OS-Mac OS-Windows Type-Bug-Regression
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce on Windows 7, Ubuntu 14.04 and Mac OS 10.11.4 using chrome stable M50-50.0.2661.102 .

Bisect Information:
=====================
Good build: 50.0.2625.0 
Bad Build : 50.0.2627.0 

Change Log URL: https://chromium.googlesource.com/chromium/src/+log/dcef3f353a82567ab9826d62748cb1c10bca2dfd..f7c153ad3d0af0069174f03d962b1642b8fc1d84

From the above change log suspecting below change

Review URL: https://codereview.chromium.org/1592493002

wangxianzhu@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!
Project Member

Comment 2 by bugdroid1@chromium.org, May 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a19a7c66cdcbb95284ebf6157ad6cf4a82fbc89

commit 6a19a7c66cdcbb95284ebf6157ad6cf4a82fbc89
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Wed May 25 23:54:03 2016

Fix printing issue of list item with blank first line

The problem was that LayoutObject::addElementVisualOverflowRects()
doesn't cover list markers. Filed  crbug.com/614781  for this.

Let BlockPainter unite its visual overflow and the result of
addElementVisualOverflowRects() to ensure whole visual overflow
coverage.

BUG= 614262 
TEST=printing/list-item-with-empty-first-line.html

Review-Url: https://codereview.chromium.org/2011863005
Cr-Commit-Position: refs/heads/master@{#396046}

[modify] https://crrev.com/6a19a7c66cdcbb95284ebf6157ad6cf4a82fbc89/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/6a19a7c66cdcbb95284ebf6157ad6cf4a82fbc89/third_party/WebKit/LayoutTests/printing/list-item-with-empty-first-line-expected.png
[add] https://crrev.com/6a19a7c66cdcbb95284ebf6157ad6cf4a82fbc89/third_party/WebKit/LayoutTests/printing/list-item-with-empty-first-line-expected.txt
[add] https://crrev.com/6a19a7c66cdcbb95284ebf6157ad6cf4a82fbc89/third_party/WebKit/LayoutTests/printing/list-item-with-empty-first-line.html
[modify] https://crrev.com/6a19a7c66cdcbb95284ebf6157ad6cf4a82fbc89/third_party/WebKit/Source/core/layout/LayoutObject.h
[modify] https://crrev.com/6a19a7c66cdcbb95284ebf6157ad6cf4a82fbc89/third_party/WebKit/Source/core/paint/BlockPainter.cpp

Comment 3 by wangxianzhu@chromium.org, May 25 2016

Labels: Merge-Request-52
Project Member

Comment 4 by bugdroid1@chromium.org, May 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd0db5c9547d55cf04685b1337f31e1a98a04ee2

commit cd0db5c9547d55cf04685b1337f31e1a98a04ee2
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Thu May 26 01:03:17 2016

Auto-rebaseline for r396046

https://chromium.googlesource.com/chromium/src/+/6a19a7c66

BUG= 614262 
TBR=wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/2010073002 .

Cr-Commit-Position: refs/heads/master@{#396066}

[modify] https://crrev.com/cd0db5c9547d55cf04685b1337f31e1a98a04ee2/third_party/WebKit/LayoutTests/TestExpectations
[rename] https://crrev.com/cd0db5c9547d55cf04685b1337f31e1a98a04ee2/third_party/WebKit/LayoutTests/platform/linux/printing/list-item-with-empty-first-line-expected.txt
[add] https://crrev.com/cd0db5c9547d55cf04685b1337f31e1a98a04ee2/third_party/WebKit/LayoutTests/platform/linux/virtual/threaded/printing/list-item-with-empty-first-line-expected.png
[copy] https://crrev.com/cd0db5c9547d55cf04685b1337f31e1a98a04ee2/third_party/WebKit/LayoutTests/platform/linux/virtual/threaded/printing/list-item-with-empty-first-line-expected.txt
[add] https://crrev.com/cd0db5c9547d55cf04685b1337f31e1a98a04ee2/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/threaded/printing/list-item-with-empty-first-line-expected.png
[add] https://crrev.com/cd0db5c9547d55cf04685b1337f31e1a98a04ee2/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/threaded/printing/list-item-with-empty-first-line-expected.png
[add] https://crrev.com/cd0db5c9547d55cf04685b1337f31e1a98a04ee2/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/threaded/printing/list-item-with-empty-first-line-expected.png
[add] https://crrev.com/cd0db5c9547d55cf04685b1337f31e1a98a04ee2/third_party/WebKit/LayoutTests/platform/mac/printing/list-item-with-empty-first-line-expected.png
[add] https://crrev.com/cd0db5c9547d55cf04685b1337f31e1a98a04ee2/third_party/WebKit/LayoutTests/platform/mac/printing/list-item-with-empty-first-line-expected.txt
[add] https://crrev.com/cd0db5c9547d55cf04685b1337f31e1a98a04ee2/third_party/WebKit/LayoutTests/platform/mac/virtual/threaded/printing/list-item-with-empty-first-line-expected.png
[add] https://crrev.com/cd0db5c9547d55cf04685b1337f31e1a98a04ee2/third_party/WebKit/LayoutTests/platform/mac/virtual/threaded/printing/list-item-with-empty-first-line-expected.txt
[add] https://crrev.com/cd0db5c9547d55cf04685b1337f31e1a98a04ee2/third_party/WebKit/LayoutTests/platform/win/printing/list-item-with-empty-first-line-expected.txt
[add] https://crrev.com/cd0db5c9547d55cf04685b1337f31e1a98a04ee2/third_party/WebKit/LayoutTests/platform/win/virtual/threaded/printing/list-item-with-empty-first-line-expected.txt
[copy] https://crrev.com/cd0db5c9547d55cf04685b1337f31e1a98a04ee2/third_party/WebKit/LayoutTests/platform/win7/printing/list-item-with-empty-first-line-expected.txt
[add] https://crrev.com/cd0db5c9547d55cf04685b1337f31e1a98a04ee2/third_party/WebKit/LayoutTests/platform/win7/virtual/threaded/printing/list-item-with-empty-first-line-expected.png
[copy] https://crrev.com/cd0db5c9547d55cf04685b1337f31e1a98a04ee2/third_party/WebKit/LayoutTests/platform/win7/virtual/threaded/printing/list-item-with-empty-first-line-expected.txt
Project Member

Comment 5 by bugdroid1@chromium.org, May 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a73c494f76acb990bd6a9eaf4c1143ddab2e060

commit 1a73c494f76acb990bd6a9eaf4c1143ddab2e060
Author: hajimehoshi <hajimehoshi@chromium.org>
Date: Thu May 26 04:42:51 2016

Revert of Auto-rebaseline for r396046 (patchset #1 id:1 of https://codereview.chromium.org/2010073002/ )

Reason for revert:
This causes test failures (e.g. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/10558)

Original issue's description:
> Auto-rebaseline for r396046
>
> https://chromium.googlesource.com/chromium/src/+/6a19a7c66
>
> BUG= 614262 
> TBR=wangxianzhu@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/cd0db5c9547d55cf04685b1337f31e1a98a04ee2

TBR=wangxianzhu@chromium.org,blink-rebaseline-bot@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 614262 

Review-Url: https://codereview.chromium.org/2017513002
Cr-Commit-Position: refs/heads/master@{#396121}

[modify] https://crrev.com/1a73c494f76acb990bd6a9eaf4c1143ddab2e060/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/d9a96896948d55fb51b919566f7a6c5ec1fd4980/third_party/WebKit/LayoutTests/platform/linux/virtual/threaded/printing/list-item-with-empty-first-line-expected.png
[delete] https://crrev.com/d9a96896948d55fb51b919566f7a6c5ec1fd4980/third_party/WebKit/LayoutTests/platform/linux/virtual/threaded/printing/list-item-with-empty-first-line-expected.txt
[delete] https://crrev.com/d9a96896948d55fb51b919566f7a6c5ec1fd4980/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/threaded/printing/list-item-with-empty-first-line-expected.png
[delete] https://crrev.com/d9a96896948d55fb51b919566f7a6c5ec1fd4980/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/threaded/printing/list-item-with-empty-first-line-expected.png
[delete] https://crrev.com/d9a96896948d55fb51b919566f7a6c5ec1fd4980/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/threaded/printing/list-item-with-empty-first-line-expected.png
[delete] https://crrev.com/d9a96896948d55fb51b919566f7a6c5ec1fd4980/third_party/WebKit/LayoutTests/platform/mac/printing/list-item-with-empty-first-line-expected.png
[delete] https://crrev.com/d9a96896948d55fb51b919566f7a6c5ec1fd4980/third_party/WebKit/LayoutTests/platform/mac/printing/list-item-with-empty-first-line-expected.txt
[delete] https://crrev.com/d9a96896948d55fb51b919566f7a6c5ec1fd4980/third_party/WebKit/LayoutTests/platform/mac/virtual/threaded/printing/list-item-with-empty-first-line-expected.png
[delete] https://crrev.com/d9a96896948d55fb51b919566f7a6c5ec1fd4980/third_party/WebKit/LayoutTests/platform/mac/virtual/threaded/printing/list-item-with-empty-first-line-expected.txt
[delete] https://crrev.com/d9a96896948d55fb51b919566f7a6c5ec1fd4980/third_party/WebKit/LayoutTests/platform/win/printing/list-item-with-empty-first-line-expected.txt
[delete] https://crrev.com/d9a96896948d55fb51b919566f7a6c5ec1fd4980/third_party/WebKit/LayoutTests/platform/win/virtual/threaded/printing/list-item-with-empty-first-line-expected.txt
[delete] https://crrev.com/d9a96896948d55fb51b919566f7a6c5ec1fd4980/third_party/WebKit/LayoutTests/platform/win7/printing/list-item-with-empty-first-line-expected.txt
[delete] https://crrev.com/d9a96896948d55fb51b919566f7a6c5ec1fd4980/third_party/WebKit/LayoutTests/platform/win7/virtual/threaded/printing/list-item-with-empty-first-line-expected.png
[delete] https://crrev.com/d9a96896948d55fb51b919566f7a6c5ec1fd4980/third_party/WebKit/LayoutTests/platform/win7/virtual/threaded/printing/list-item-with-empty-first-line-expected.txt
[rename] https://crrev.com/1a73c494f76acb990bd6a9eaf4c1143ddab2e060/third_party/WebKit/LayoutTests/printing/list-item-with-empty-first-line-expected.txt
Project Member

Comment 6 by bugdroid1@chromium.org, May 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b3fc4baed096f8cb3f9f3c4ad67177a9ec53724

commit 5b3fc4baed096f8cb3f9f3c4ad67177a9ec53724
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Thu May 26 05:43:01 2016

Auto-rebaseline for r396121

https://chromium.googlesource.com/chromium/src/+/1a73c494f

BUG= 614262 
TBR=hajimehoshi@chromium.org

Review URL: https://codereview.chromium.org/2018443002 .

Cr-Commit-Position: refs/heads/master@{#396126}

[modify] https://crrev.com/5b3fc4baed096f8cb3f9f3c4ad67177a9ec53724/third_party/WebKit/LayoutTests/TestExpectations
[rename] https://crrev.com/5b3fc4baed096f8cb3f9f3c4ad67177a9ec53724/third_party/WebKit/LayoutTests/platform/linux/printing/list-item-with-empty-first-line-expected.txt
[add] https://crrev.com/5b3fc4baed096f8cb3f9f3c4ad67177a9ec53724/third_party/WebKit/LayoutTests/platform/linux/virtual/threaded/printing/list-item-with-empty-first-line-expected.png
[copy] https://crrev.com/5b3fc4baed096f8cb3f9f3c4ad67177a9ec53724/third_party/WebKit/LayoutTests/platform/linux/virtual/threaded/printing/list-item-with-empty-first-line-expected.txt
[add] https://crrev.com/5b3fc4baed096f8cb3f9f3c4ad67177a9ec53724/third_party/WebKit/LayoutTests/platform/mac/printing/list-item-with-empty-first-line-expected.png
[add] https://crrev.com/5b3fc4baed096f8cb3f9f3c4ad67177a9ec53724/third_party/WebKit/LayoutTests/platform/mac/printing/list-item-with-empty-first-line-expected.txt
[add] https://crrev.com/5b3fc4baed096f8cb3f9f3c4ad67177a9ec53724/third_party/WebKit/LayoutTests/platform/mac/virtual/threaded/printing/list-item-with-empty-first-line-expected.png
[add] https://crrev.com/5b3fc4baed096f8cb3f9f3c4ad67177a9ec53724/third_party/WebKit/LayoutTests/platform/mac/virtual/threaded/printing/list-item-with-empty-first-line-expected.txt
[add] https://crrev.com/5b3fc4baed096f8cb3f9f3c4ad67177a9ec53724/third_party/WebKit/LayoutTests/platform/win/printing/list-item-with-empty-first-line-expected.txt
[add] https://crrev.com/5b3fc4baed096f8cb3f9f3c4ad67177a9ec53724/third_party/WebKit/LayoutTests/platform/win/virtual/threaded/printing/list-item-with-empty-first-line-expected.txt
[add] https://crrev.com/5b3fc4baed096f8cb3f9f3c4ad67177a9ec53724/third_party/WebKit/LayoutTests/platform/win7/printing/list-item-with-empty-first-line-expected.png
[add] https://crrev.com/5b3fc4baed096f8cb3f9f3c4ad67177a9ec53724/third_party/WebKit/LayoutTests/platform/win7/virtual/threaded/printing/list-item-with-empty-first-line-expected.png

Comment 7 by hajimehoshi@chromium.org, May 26 2016

Blockedon: 614917

Comment 8 by wangxianzhu@chromium.org, May 26 2016

Blockedon: -614917

Comment 9 by tin...@google.com, May 27 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Project Member

Comment 10 by bugdroid1@chromium.org, May 27 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/343998e6bc865e694516e2c340d47d1d171345f7

commit 343998e6bc865e694516e2c340d47d1d171345f7
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Fri May 27 18:58:54 2016

Fix printing issue of list item with blank first line

The problem was that LayoutObject::addElementVisualOverflowRects()
doesn't cover list markers. Filed  crbug.com/614781  for this.

Let BlockPainter unite its visual overflow and the result of
addElementVisualOverflowRects() to ensure whole visual overflow
coverage.

BUG= 614262 
TEST=printing/list-item-with-empty-first-line.html

Review-Url: https://codereview.chromium.org/2011863005
Cr-Commit-Position: refs/heads/master@{#396046}

Review URL: https://codereview.chromium.org/2020733002 .

Cr-Commit-Position: refs/branch-heads/2743@{#105}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/343998e6bc865e694516e2c340d47d1d171345f7/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/343998e6bc865e694516e2c340d47d1d171345f7/third_party/WebKit/LayoutTests/printing/list-item-with-empty-first-line-expected.png
[add] https://crrev.com/343998e6bc865e694516e2c340d47d1d171345f7/third_party/WebKit/LayoutTests/printing/list-item-with-empty-first-line-expected.txt
[add] https://crrev.com/343998e6bc865e694516e2c340d47d1d171345f7/third_party/WebKit/LayoutTests/printing/list-item-with-empty-first-line.html
[modify] https://crrev.com/343998e6bc865e694516e2c340d47d1d171345f7/third_party/WebKit/Source/core/layout/LayoutObject.h
[modify] https://crrev.com/343998e6bc865e694516e2c340d47d1d171345f7/third_party/WebKit/Source/core/paint/BlockPainter.cpp

Comment 11 by wangxianzhu@chromium.org, May 27 2016

Status: Fixed (was: Assigned)

Comment 12 by sai.sail...@gmail.com, May 28 2016 

Thank you for quick fix. Verified in 53.0.2750.0 canary (64-bit). Fix looked good to me. I appreciate your work. Now, waiting eagerly this to be released.

Thanks a lot....! :-)
Print_UL_Number_Missing.pdf
51.7 KB Download

Comment 13 by rnimmagadda@chromium.org, May 31 2016

Cc: rnimmagadda@chromium.org
Labels: TE-Verified-M52 TE-Verified-52.0.2743.19
Verified the fix on Windows 7, MAC (10.11.5) & Ubuntu Trusty (14.04) for Google Chrome Dev Version - 52.0.2743.19

Screen-recording is attached.

TE-Verified Labels are added.
614262.mov
484 KB Download
►

Sign in to add a comment