New issue
Advanced search Search tips

Issue 614244 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: May 2016
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

MacViews browser failing compilation

Project Member Reported by karandeepb@chromium.org, May 24 2016 
Version: 53.0.2747.0
OS: Mac

What steps will reproduce the problem?
(1) Build with mac_views_browser=1
(2) Compilation fails with the following error messages-

In file included from ../../chrome/browser/ui/views/frame/browser_non_client_frame_view_factory_mac.mm:5:
../../chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.h:42:23: error: only virtual member functions can be marked 'override'
  void UpdateAvatar() override;
                      ^~~~~~~~
../../chrome/browser/ui/views/frame/browser_non_client_frame_view_factory_mac.mm:11:14: error: allocating an object of abstract class type 'BrowserNonClientFrameViewMac'
  return new BrowserNonClientFrameViewMac(frame, browser_view);
             ^
../../chrome/browser/ui/views/frame/browser_non_client_frame_view.h:86:16: note: unimplemented pure virtual method 'UpdateProfileIcons' in 'BrowserNonClientFrameViewMac'
  virtual void UpdateProfileIcons() = 0;
Project Member

Comment 1 by bugdroid1@chromium.org, May 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25c2cd1a7b9f29b42ce549b98437ad48c92b38f6

commit 25c2cd1a7b9f29b42ce549b98437ad48c92b38f6
Author: tapted <tapted@chromium.org>
Date: Tue May 24 03:58:35 2016

MacViewsBrowser: Fix broken compile - renamed method after r395397

r395397 is "Simplify some old avatar menu button code."

`compile` step broke in http://go/macviewsbuilder/builds/10802 with

browser_non_client_frame_view_mac.h:42:23:
error: only virtual member functions can be marked 'override'
  void UpdateAvatar() override;

It just needs to be renamed to UpdateProfileIcons().

BUG= 425229 , 614244 
TBR=estade@chromium.org

Review-Url: https://codereview.chromium.org/2001383002
Cr-Commit-Position: refs/heads/master@{#395529}

[modify] https://crrev.com/25c2cd1a7b9f29b42ce549b98437ad48c92b38f6/chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.h
[modify] https://crrev.com/25c2cd1a7b9f29b42ce549b98437ad48c92b38f6/chrome/browser/ui/views/frame/browser_non_client_frame_view_mac.mm

Comment 2 by tapted@chromium.org, May 24 2016

Status: Fixed (was: Available)

Comment 3 by tapted@chromium.org, May 24 2016 

`compile` step is green again in http://go/macviewsbuilder/builds/10838
►

Sign in to add a comment