New issue
Advanced search Search tips

Issue 614227 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

CronetUrlRequestContextTest#testRealTimeNetworkQualityObservations failing on all Cronet bots

Project Member Reported by aelias@chromium.org, May 24 2016

Issue description

Example failure: https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20Cronet%20Builder%20(dbg)/builds/2059 .  I can also repro locally, seems like a recent regression.
 

Comment 1 by aelias@chromium.org, May 24 2016

Cc: pauljensen@chromium.org
Owner: xunji...@chromium.org
Correction, it is flaky locally.  Oddly, it failed on 3 bots at once (after being green for 10 runs earlier) so it might be affected by environmental factors?  Anyway, I can't find an obvious culprit, so assigning to Cronet folks.
Components: Internals>Network>Library
Owner: tbansal@chromium.org
Tarun, would you mind taking a look at this? Do you know if there's any recent change in NQE that might have caused this test failure?
Project Member

Comment 3 by bugdroid1@chromium.org, May 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aeee178ce621bfa3a9250f749d8e54a5b42bc54d

commit aeee178ce621bfa3a9250f749d8e54a5b42bc54d
Author: aelias <aelias@chromium.org>
Date: Tue May 24 01:37:49 2016

Mark CronetUrlRequestContextTest#testRealTimeNetworkQualityObservations flaky.

This test failed once on 3 different Cronet bots, and I can also
reproduce flakiness locally.

TBR=xunjieli
NOTRY=true
BUG= 614227 

Review-Url: https://codereview.chromium.org/2005153002
Cr-Commit-Position: refs/heads/master@{#395508}

[modify] https://crrev.com/aeee178ce621bfa3a9250f749d8e54a5b42bc54d/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java

I noticed this before, and I have verified that https://codereview.chromium.org/1999303002/ fixes it. I manually added android_cronet_tester on that CQ, and it looks happy.

Can you look at the CL, ad if it looks good, we can push it to CQ?
Project Member

Comment 5 by bugdroid1@chromium.org, May 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86d66363a9aad84556298c81c4a5af935d67d03b

commit 86d66363a9aad84556298c81c4a5af935d67d03b
Author: tbansal <tbansal@chromium.org>
Date: Fri May 27 16:42:17 2016

Fix flaky NQE cronet test

Example of a flaky run from testbot:
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cronet_tester/builds/168
and https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Builder/builds/2184

A recent NQE CL changed the logic so that throughput
observations are now posted to NQE (before that CL, the
observations were available synchronously).

BUG= 614227 

Review-Url: https://codereview.chromium.org/1999303002
Cr-Commit-Position: refs/heads/master@{#396488}

[modify] https://crrev.com/86d66363a9aad84556298c81c4a5af935d67d03b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java

Status: Fixed (was: Assigned)
Components: Internals>Network>NetworkQuality

Sign in to add a comment