Top hosts in Chrome should use only 200s |
|||||||
Issue descriptionChrome computes a list of the most visited hosts for a profile. This list should include only those hosts at the end of a redirect chain and not any redirects.
,
Aug 18 2016
HistoryBackend::QueryRedirectsFrom() could be used to find if an URL is a redirect and skip that in top host calculation. https://cs.chromium.org/chromium/src/components/history/core/browser/history_backend.cc?rcl=1471447605&l=1316
,
Aug 18 2016
,
Aug 19 2016
,
Sep 6 2016
,
Sep 6 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/276df9be47cf9aec1dc7501afef203e1e5b2b052 commit 276df9be47cf9aec1dc7501afef203e1e5b2b052 Author: rajendrant <rajendrant@chromium.org> Date: Tue Sep 06 17:51:14 2016 Top Hosts computation should not use redirected urls and subframe urls BUG= 614188 Review-Url: https://codereview.chromium.org/2298093002 Cr-Commit-Position: refs/heads/master@{#416658} [modify] https://crrev.com/276df9be47cf9aec1dc7501afef203e1e5b2b052/components/history/core/browser/history_backend_unittest.cc [modify] https://crrev.com/276df9be47cf9aec1dc7501afef203e1e5b2b052/components/history/core/browser/history_database.cc
,
Sep 7 2016
,
Sep 7 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/93c15ff6e88b400e8f681c66c50a702441540a72 commit 93c15ff6e88b400e8f681c66c50a702441540a72 Author: rajendrant <rajendrant@chromium.org> Date: Wed Sep 07 20:54:18 2016 Top Hosts computation should not use redirected urls and subframe urls BUG= 614188 Review-Url: https://codereview.chromium.org/2298093002 Cr-Commit-Position: refs/heads/master@{#416658} (cherry picked from commit 276df9be47cf9aec1dc7501afef203e1e5b2b052) Review URL: https://codereview.chromium.org/2319263002 . Cr-Commit-Position: refs/branch-heads/2840@{#215} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/93c15ff6e88b400e8f681c66c50a702441540a72/components/history/core/browser/history_backend_unittest.cc [modify] https://crrev.com/93c15ff6e88b400e8f681c66c50a702441540a72/components/history/core/browser/history_database.cc
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/93c15ff6e88b400e8f681c66c50a702441540a72 commit 93c15ff6e88b400e8f681c66c50a702441540a72 Author: rajendrant <rajendrant@chromium.org> Date: Wed Sep 07 20:54:18 2016 Top Hosts computation should not use redirected urls and subframe urls BUG= 614188 Review-Url: https://codereview.chromium.org/2298093002 Cr-Commit-Position: refs/heads/master@{#416658} (cherry picked from commit 276df9be47cf9aec1dc7501afef203e1e5b2b052) Review URL: https://codereview.chromium.org/2319263002 . Cr-Commit-Position: refs/branch-heads/2840@{#215} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/93c15ff6e88b400e8f681c66c50a702441540a72/components/history/core/browser/history_backend_unittest.cc [modify] https://crrev.com/93c15ff6e88b400e8f681c66c50a702441540a72/components/history/core/browser/history_database.cc |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by sheriffbot@chromium.org
, Jul 9 2016