Create integration tests to validate WebStateObserver |
|||||||||||
Issue descriptionCurrently no tests verify WebStateObserver callbacks, or UI affected by this (e.g. lock icon). It would be useful to have tests here.
,
May 31 2017
baxley@ is this still something that would be useful?
,
May 31 2017
Actually we have many integration tests for this in ios_web_unittest and ios_web_inttest. These callbacks are covered: - ProvisionalNavigationStarted - DidFinishNavigation - DidStartLoading - DidStopLoading - LoadProgressChanged - TitleWasSet - DidChangeVisibleSecurityState - DidSuppressDialog - FormActivityRegistered - FaviconUrlUpdated - RenderProcessGone These callback need tests: - NavigationItemsPruned - NavigationItemCommitted - PageLoaded - InterstitialDismissed - DocumentSubmitted This callback is deprecated: - NavigationItemChanged New tests should be part of ios_web_inttest, not part of EG test suite. This is something that we'll probably do in Q3.
,
Jan 30 2018
These callbacks are covered: - DidStartNavigation - DidFinishNavigation - DidStartLoading - DidStopLoading - LoadProgressChanged - TitleWasSet - DidChangeVisibleSecurityState - DidSuppressDialog - FormActivityRegistered - FaviconUrlUpdated - RenderProcessGone - DocumentSubmitted These callback need tests: - NavigationItemsPruned - PageLoaded This callback is deprecated: - NavigationItemChanged - NavigationItemCommitted
,
Jan 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cef484a75d19ff1e6971295cb7f9e9db99976e2a commit cef484a75d19ff1e6971295cb7f9e9db99976e2a Author: Eugene But <eugenebut@google.com> Date: Tue Jan 30 23:20:28 2018 Make ExabyteResponse a default handler for EmbeddedTestServer. ExabyteResponse is almost never ending response (with an Extabyte content-length). This response will be used in iOS tests, so it is useful to make it default. Bug: 614168 ,789585 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie0edb7bbfc427bb83dc8bfbc9e143d1cd0e890e7 Reviewed-on: https://chromium-review.googlesource.com/890300 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#533071} [modify] https://crrev.com/cef484a75d19ff1e6971295cb7f9e9db99976e2a/components/cronet/android/test/native_test_server.cc [modify] https://crrev.com/cef484a75d19ff1e6971295cb7f9e9db99976e2a/net/test/embedded_test_server/default_handlers.cc
,
Feb 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5a178c9843bace7f3da1d73152b596531e956442 commit 5a178c9843bace7f3da1d73152b596531e956442 Author: Eugene But <eugenebut@google.com> Date: Thu Feb 01 15:30:04 2018 Add integration test for failed load after sucessfull navigation. This test uses ExabyteResponse which never stops respondind and then shuts down the server after the navigation is comitted to fail the load. Bug: 614168 ,789585 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4571fbfa58c35072438a8cc74e4c2eeca5c2dd08 Reviewed-on: https://chromium-review.googlesource.com/895913 Reviewed-by: Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#533670} [modify] https://crrev.com/5a178c9843bace7f3da1d73152b596531e956442/ios/web/web_state/navigation_and_load_callbacks_inttest.mm
,
Feb 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/df42e1a12bec272f7406d41fa1cb0e3768bc6c3e commit df42e1a12bec272f7406d41fa1cb0e3768bc6c3e Author: Eugene But <eugenebut@google.com> Date: Mon Feb 05 22:12:34 2018 Change WebState::IsLoading to false if ShouldAllowRequest returned false. This CL adds NavigationAndLoadCallbacksTest.DisallowRequest test and fixes a bug when WebState::IsLoading does not flop to false. Bug: 614168 ,789585 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I30e7fcd49fdbbc33a2a67f274a37e5243d4ea07b Reviewed-on: https://chromium-review.googlesource.com/900092 Reviewed-by: Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#534502} [modify] https://crrev.com/df42e1a12bec272f7406d41fa1cb0e3768bc6c3e/ios/web/web_state/navigation_and_load_callbacks_inttest.mm [modify] https://crrev.com/df42e1a12bec272f7406d41fa1cb0e3768bc6c3e/ios/web/web_state/ui/crw_web_controller.mm
,
Feb 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d495ed7d975f1599930d7953c576b8b8b6f03fb9 commit d495ed7d975f1599930d7953c576b8b8b6f03fb9 Author: Eugene But <eugenebut@chromium.org> Date: Wed Feb 07 00:35:11 2018 Add NavigationAndLoadCallbacksTest.DisallowResponse test. This tests load rejection when ShouldAllowResponse returns false. Bug: 614168 ,789585 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I91c1da903fdda7910aadc7ffdf74c23a72f79bde Reviewed-on: https://chromium-review.googlesource.com/900094 Reviewed-by: Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#534852} [modify] https://crrev.com/d495ed7d975f1599930d7953c576b8b8b6f03fb9/ios/web/web_state/navigation_and_load_callbacks_inttest.mm
,
Feb 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b8a3c81336fb7d26c0b7580666c649f0e4e121b3 commit b8a3c81336fb7d26c0b7580666c649f0e4e121b3 Author: Eugene But <eugenebut@chromium.org> Date: Wed Feb 07 07:11:33 2018 Added NavigationAndLoadCallbacksTest for stopping the navigation and load. Bug: 614168 ,789585 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id7852dce96ce70159a46cfadb080207b54c8bf69 Reviewed-on: https://chromium-review.googlesource.com/899952 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#534940} [modify] https://crrev.com/b8a3c81336fb7d26c0b7580666c649f0e4e121b3/ios/web/web_state/navigation_and_load_callbacks_inttest.mm
,
Feb 7 2018
These callbacks are covered: - DidStartNavigation - DidFinishNavigation - DidStartLoading - DidStopLoading - LoadProgressChanged - TitleWasSet - DidChangeVisibleSecurityState - DidSuppressDialog - FormActivityRegistered - FaviconUrlUpdated - RenderProcessGone - DocumentSubmitted - PageLoaded These callbacks need tests: - NavigationItemsPruned This callbacks are deprecated: - NavigationItemChanged - NavigationItemCommitted
,
Mar 1 2018
,
Mar 1 2018
,
Oct 26
,
Oct 26
,
Oct 26
,
Dec 4
These callbacks are covered: - WasShown - WasHidden - DidStartNavigation - NavigationItemsPruned - DidFinishNavigation - DidStartLoading - DidStopLoading - PageLoaded - LoadProgressChanged - TitleWasSet - DidChangeVisibleSecurityState - FaviconUrlUpdated - RenderProcessGone This callbacks are deprecated: - NavigationItemChanged - NavigationItemCommitted There is no need to write tests for deprecated callbacks, so marking this as Fixed. |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by eugene...@chromium.org
, May 30 2017Owner: ----
Status: Untriaged (was: Assigned)