Investigate if matcher addressFieldText should take std::string as parameter |
||
Issue descriptionThe common use case is for the user to have a std::string when creating mock URLs, so it would take less code in tests if addressFieldText() took a std::string, rather than NSString.
,
May 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/380c6cda0109db823121542b2c93783803f5aa33 commit 380c6cda0109db823121542b2c93783803f5aa33 Author: baxley <baxley@chromium.org> Date: Wed May 25 22:42:39 2016 Remove Earl Grey matcher APIs taking NSString. std::string APIs provide cleaner code in tests, which have been adopted by all tests. BUG= 614167 Review-Url: https://codereview.chromium.org/2008183004 Cr-Commit-Position: refs/heads/master@{#396014} [modify] https://crrev.com/380c6cda0109db823121542b2c93783803f5aa33/ios/web/public/test/earl_grey/web_view_matchers.h [modify] https://crrev.com/380c6cda0109db823121542b2c93783803f5aa33/ios/web/public/test/earl_grey/web_view_matchers.mm [modify] https://crrev.com/380c6cda0109db823121542b2c93783803f5aa33/ios/web/shell/test/earl_grey/shell_matchers.h [modify] https://crrev.com/380c6cda0109db823121542b2c93783803f5aa33/ios/web/shell/test/earl_grey/shell_matchers.mm
,
Oct 31 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, May 24 2016