New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 614148 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

Code cleanup: Metrics::Notify80211Disconnect code improvements

Project Member Reported by kirtika@google.com, May 23 2016

Issue description

Task/Improvement: Metrics::Notify80211Disconnect code improvements
Task/Improvement: Metrics::Notify80211Disconnect code improvements

(a) Remove incorrect comment: 
Metrics::Notify80211Disconnect has an incorrect comment about removing the IEEE_80211::WiFiReasonCode dependency, which cannot and should not be removed. Remove the comment. 
Metrics::WiFiStatusCode merely provides data about whether the message/action originated at the client, AP or user. It does not provide fine-grained reason codes, for which we must resort to IEEE_80211::WiFiReasonCode.

(b) Provide correct classification for wifi reason codes not listed in the current switch() statement. 
Many reason codes listed in enum WiFiReasonCode in net/ieee80211.h in shill are not covered in Metrics::Notify80211Disconnect and are hence bucketized in the default of 'kStatusCodeTypeByClient'. Check if this is correct. If not, add them to the switch statement. 
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jun 2 2016

Labels: Hotlist-Google
Status: Assigned (was: Untriaged)

Sign in to add a comment