New issue
Advanced search Search tips

Issue 614144 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature



Sign in to add a comment

[Media Router] Can't cast new content without first stopping existing route

Project Member Reported by btolsch@chromium.org, May 23 2016

Issue description

When wanting to cast a new tab or other source to a sink that currently has an active route, that route must be stopped before casting the new source.  This isn't necessary with the legacy cast extension.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4680358215ff217eb6b0073c4be2243738369957

commit 4680358215ff217eb6b0073c4be2243738369957
Author: btolsch <btolsch@chromium.org>
Date: Thu Jun 02 17:33:14 2016

[Media Router] Allow casting new media to sink with existing route.

This change allows for one button push to stop casting to a sink and
then immediately create a new route to the same sink with the selected
source. The makes the user experience smoother by not making them stop
the current cast and then start a new one manually in two stops.

Some shortcomings of this change that will be addressed in the future:

 - At least for mirroring, it's possible to avoid stopping the route and
   just switch the stream sources. This probably requires adding a new
   API to the extension.

 - The button will currently allow users to re-cast the current source,
   stopping the current route and starting a new one, even though this
   isn't necessary. When both the old and new sources are tabs, the tab
   IDs could be checked, but other cases would have to be handled in MR
   or the extension.

BUG= 614144 
R=apacible@chromium.org, amp@chromium.org, mfoltz@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2002293003
Cr-Commit-Position: refs/heads/master@{#397457}

[modify] https://crrev.com/4680358215ff217eb6b0073c4be2243738369957/chrome/browser/media/router/media_router_metrics.h
[modify] https://crrev.com/4680358215ff217eb6b0073c4be2243738369957/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html
[modify] https://crrev.com/4680358215ff217eb6b0073c4be2243738369957/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
[modify] https://crrev.com/4680358215ff217eb6b0073c4be2243738369957/chrome/browser/resources/media_router/elements/route_details/route_details.html
[modify] https://crrev.com/4680358215ff217eb6b0073c4be2243738369957/chrome/browser/resources/media_router/elements/route_details/route_details.js
[modify] https://crrev.com/4680358215ff217eb6b0073c4be2243738369957/chrome/browser/resources/media_router/media_router.js
[modify] https://crrev.com/4680358215ff217eb6b0073c4be2243738369957/chrome/browser/resources/media_router/media_router_data.js
[modify] https://crrev.com/4680358215ff217eb6b0073c4be2243738369957/chrome/test/data/webui/media_router/media_router_container_cast_mode_list_tests.js
[modify] https://crrev.com/4680358215ff217eb6b0073c4be2243738369957/chrome/test/data/webui/media_router/route_details_tests.js
[modify] https://crrev.com/4680358215ff217eb6b0073c4be2243738369957/tools/metrics/histograms/histograms.xml

Project Member

Comment 2 by bugdroid1@chromium.org, Jun 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3c5d24288f9029a7ef82d6892f9d9afbb4fc607

commit e3c5d24288f9029a7ef82d6892f9d9afbb4fc607
Author: btolsch <btolsch@chromium.org>
Date: Fri Jun 03 20:25:20 2016

[Media Router WebUI] Rename close route event in html

The event name used in media_router_container.html for closing routes
was not renamed by the previous change.

BUG= 614144 
R=apacible@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2036383002
Cr-Commit-Position: refs/heads/master@{#397792}

[modify] https://crrev.com/e3c5d24288f9029a7ef82d6892f9d9afbb4fc607/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a47d5b0506c1183d501767d17ffec02ca419ea76

commit a47d5b0506c1183d501767d17ffec02ca419ea76
Author: btolsch <btolsch@chromium.org>
Date: Wed Jun 08 21:38:35 2016

[Media Router] Assign each route a current cast mode if possible

This change gives each media route in the WebUI a current cast mode
value if its media source corresponds to one of the currently available
cast modes. This is to prevent showing the 'cast' button that allows
replacing the route when the new route would effectively be a copy of
the original route.

BUG= 614144 
R=apacible@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2040883002
Cr-Commit-Position: refs/heads/master@{#398687}

[modify] https://crrev.com/a47d5b0506c1183d501767d17ffec02ca419ea76/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html
[modify] https://crrev.com/a47d5b0506c1183d501767d17ffec02ca419ea76/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
[modify] https://crrev.com/a47d5b0506c1183d501767d17ffec02ca419ea76/chrome/browser/resources/media_router/elements/route_details/route_details.html
[modify] https://crrev.com/a47d5b0506c1183d501767d17ffec02ca419ea76/chrome/browser/resources/media_router/elements/route_details/route_details.js
[modify] https://crrev.com/a47d5b0506c1183d501767d17ffec02ca419ea76/chrome/browser/resources/media_router/media_router_data.js
[modify] https://crrev.com/a47d5b0506c1183d501767d17ffec02ca419ea76/chrome/browser/ui/webui/media_router/media_router_ui.cc
[modify] https://crrev.com/a47d5b0506c1183d501767d17ffec02ca419ea76/chrome/browser/ui/webui/media_router/media_router_ui.h
[modify] https://crrev.com/a47d5b0506c1183d501767d17ffec02ca419ea76/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc
[modify] https://crrev.com/a47d5b0506c1183d501767d17ffec02ca419ea76/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
[modify] https://crrev.com/a47d5b0506c1183d501767d17ffec02ca419ea76/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.h
[modify] https://crrev.com/a47d5b0506c1183d501767d17ffec02ca419ea76/chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc
[modify] https://crrev.com/a47d5b0506c1183d501767d17ffec02ca419ea76/chrome/test/data/webui/media_router/media_router_container_route_tests.js
[modify] https://crrev.com/a47d5b0506c1183d501767d17ffec02ca419ea76/chrome/test/data/webui/media_router/media_router_container_test_base.js
[modify] https://crrev.com/a47d5b0506c1183d501767d17ffec02ca419ea76/chrome/test/data/webui/media_router/route_details_tests.js

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16bc9a232bd6ef00891eb061687d23f77ee29efd

commit 16bc9a232bd6ef00891eb061687d23f77ee29efd
Author: btolsch <btolsch@chromium.org>
Date: Fri Jun 10 21:48:13 2016

[Media Router WebUI] Prevent error when route becomes null

Once the route-details element is stamped, getSinkForRoute_ is bound to
currentRoute_. This becomes null if the route is stopped which causes
getSinkForRoute_ to throw an innocuous but noisy error. This change adds
a check of the route before dereferencing it.

BUG= 614144 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2053743002
Cr-Commit-Position: refs/heads/master@{#399281}

[modify] https://crrev.com/16bc9a232bd6ef00891eb061687d23f77ee29efd/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js

Labels: Merge-Request-52
Wanting to merge all four patches back to M52.

Comment 7 by tin...@google.com, Jun 13 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 13 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c975548118d7e2ed6e479d7b46699af98c3c484

commit 9c975548118d7e2ed6e479d7b46699af98c3c484
Author: btolsch <btolsch@chromium.org>
Date: Mon Jun 13 22:41:59 2016

[Media Router] Allow casting new media to sink with existing route.

This change allows for one button push to stop casting to a sink and
then immediately create a new route to the same sink with the selected
source. The makes the user experience smoother by not making them stop
the current cast and then start a new one manually in two stops.

Some shortcomings of this change that will be addressed in the future:

 - At least for mirroring, it's possible to avoid stopping the route and
   just switch the stream sources. This probably requires adding a new
   API to the extension.

 - The button will currently allow users to re-cast the current source,
   stopping the current route and starting a new one, even though this
   isn't necessary. When both the old and new sources are tabs, the tab
   IDs could be checked, but other cases would have to be handled in MR
   or the extension.

BUG= 614144 
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2002293003
Cr-Commit-Position: refs/heads/master@{#397457}
(cherry picked from commit 4680358215ff217eb6b0073c4be2243738369957)

Review-Url: https://codereview.chromium.org/2062913002
Cr-Commit-Position: refs/branch-heads/2743@{#340}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/9c975548118d7e2ed6e479d7b46699af98c3c484/chrome/browser/media/router/media_router_metrics.h
[modify] https://crrev.com/9c975548118d7e2ed6e479d7b46699af98c3c484/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html
[modify] https://crrev.com/9c975548118d7e2ed6e479d7b46699af98c3c484/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
[modify] https://crrev.com/9c975548118d7e2ed6e479d7b46699af98c3c484/chrome/browser/resources/media_router/elements/route_details/route_details.html
[modify] https://crrev.com/9c975548118d7e2ed6e479d7b46699af98c3c484/chrome/browser/resources/media_router/elements/route_details/route_details.js
[modify] https://crrev.com/9c975548118d7e2ed6e479d7b46699af98c3c484/chrome/browser/resources/media_router/media_router.js
[modify] https://crrev.com/9c975548118d7e2ed6e479d7b46699af98c3c484/chrome/browser/resources/media_router/media_router_data.js
[modify] https://crrev.com/9c975548118d7e2ed6e479d7b46699af98c3c484/chrome/test/data/webui/media_router/media_router_container_cast_mode_list_tests.js
[modify] https://crrev.com/9c975548118d7e2ed6e479d7b46699af98c3c484/chrome/test/data/webui/media_router/route_details_tests.js
[modify] https://crrev.com/9c975548118d7e2ed6e479d7b46699af98c3c484/tools/metrics/histograms/histograms.xml

Project Member

Comment 9 by bugdroid1@chromium.org, Jun 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9ff5fa98067da08a924ab74845ab7ebae7068d2

commit d9ff5fa98067da08a924ab74845ab7ebae7068d2
Author: btolsch <btolsch@chromium.org>
Date: Mon Jun 13 23:49:27 2016

[Media Router WebUI] Rename close route event in html

The event name used in media_router_container.html for closing routes
was not renamed by the previous change.

BUG= 614144 
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2036383002
Cr-Commit-Position: refs/heads/master@{#397792}
(cherry picked from commit e3c5d24288f9029a7ef82d6892f9d9afbb4fc607)

Review-Url: https://codereview.chromium.org/2061043002
Cr-Commit-Position: refs/branch-heads/2743@{#343}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/d9ff5fa98067da08a924ab74845ab7ebae7068d2/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html

Project Member

Comment 10 by bugdroid1@chromium.org, Jun 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07fc807ec68c553d2ca85efacda2e9c1081f0fc3

commit 07fc807ec68c553d2ca85efacda2e9c1081f0fc3
Author: btolsch <btolsch@chromium.org>
Date: Tue Jun 14 07:26:22 2016

[Media Router] Assign each route a current cast mode if possible

This change gives each media route in the WebUI a current cast mode
value if its media source corresponds to one of the currently available
cast modes. This is to prevent showing the 'cast' button that allows
replacing the route when the new route would effectively be a copy of
the original route.

BUG= 614144 
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2040883002
Cr-Commit-Position: refs/heads/master@{#398687}
(cherry picked from commit a47d5b0506c1183d501767d17ffec02ca419ea76)

Review-Url: https://codereview.chromium.org/2068593002
Cr-Commit-Position: refs/branch-heads/2743@{#347}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/07fc807ec68c553d2ca85efacda2e9c1081f0fc3/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html
[modify] https://crrev.com/07fc807ec68c553d2ca85efacda2e9c1081f0fc3/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
[modify] https://crrev.com/07fc807ec68c553d2ca85efacda2e9c1081f0fc3/chrome/browser/resources/media_router/elements/route_details/route_details.html
[modify] https://crrev.com/07fc807ec68c553d2ca85efacda2e9c1081f0fc3/chrome/browser/resources/media_router/elements/route_details/route_details.js
[modify] https://crrev.com/07fc807ec68c553d2ca85efacda2e9c1081f0fc3/chrome/browser/resources/media_router/media_router_data.js
[modify] https://crrev.com/07fc807ec68c553d2ca85efacda2e9c1081f0fc3/chrome/browser/ui/webui/media_router/media_router_ui.cc
[modify] https://crrev.com/07fc807ec68c553d2ca85efacda2e9c1081f0fc3/chrome/browser/ui/webui/media_router/media_router_ui.h
[modify] https://crrev.com/07fc807ec68c553d2ca85efacda2e9c1081f0fc3/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc
[modify] https://crrev.com/07fc807ec68c553d2ca85efacda2e9c1081f0fc3/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
[modify] https://crrev.com/07fc807ec68c553d2ca85efacda2e9c1081f0fc3/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.h
[modify] https://crrev.com/07fc807ec68c553d2ca85efacda2e9c1081f0fc3/chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc
[modify] https://crrev.com/07fc807ec68c553d2ca85efacda2e9c1081f0fc3/chrome/test/data/webui/media_router/media_router_container_route_tests.js
[modify] https://crrev.com/07fc807ec68c553d2ca85efacda2e9c1081f0fc3/chrome/test/data/webui/media_router/media_router_container_test_base.js
[modify] https://crrev.com/07fc807ec68c553d2ca85efacda2e9c1081f0fc3/chrome/test/data/webui/media_router/route_details_tests.js

Project Member

Comment 11 by bugdroid1@chromium.org, Jun 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/964f4bedd936ba690fcc196a653f9d3e9be13917

commit 964f4bedd936ba690fcc196a653f9d3e9be13917
Author: btolsch <btolsch@chromium.org>
Date: Tue Jun 14 17:33:14 2016

[Media Router WebUI] Prevent error when route becomes null

Once the route-details element is stamped, getSinkForRoute_ is bound to
currentRoute_. This becomes null if the route is stopped which causes
getSinkForRoute_ to throw an innocuous but noisy error. This change adds
a check of the route before dereferencing it.

BUG= 614144 
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2053743002
Cr-Commit-Position: refs/heads/master@{#399281}
(cherry picked from commit 16bc9a232bd6ef00891eb061687d23f77ee29efd)

Review-Url: https://codereview.chromium.org/2065023002
Cr-Commit-Position: refs/branch-heads/2743@{#351}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/964f4bedd936ba690fcc196a653f9d3e9be13917/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js

Project Member

Comment 12 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16bc9a232bd6ef00891eb061687d23f77ee29efd

commit 16bc9a232bd6ef00891eb061687d23f77ee29efd
Author: btolsch <btolsch@chromium.org>
Date: Fri Jun 10 21:48:13 2016

[Media Router WebUI] Prevent error when route becomes null

Once the route-details element is stamped, getSinkForRoute_ is bound to
currentRoute_. This becomes null if the route is stopped which causes
getSinkForRoute_ to throw an innocuous but noisy error. This change adds
a check of the route before dereferencing it.

BUG= 614144 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2053743002
Cr-Commit-Position: refs/heads/master@{#399281}

[modify] https://crrev.com/16bc9a232bd6ef00891eb061687d23f77ee29efd/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js

Project Member

Comment 13 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c975548118d7e2ed6e479d7b46699af98c3c484

commit 9c975548118d7e2ed6e479d7b46699af98c3c484
Author: btolsch <btolsch@chromium.org>
Date: Mon Jun 13 22:41:59 2016

[Media Router] Allow casting new media to sink with existing route.

This change allows for one button push to stop casting to a sink and
then immediately create a new route to the same sink with the selected
source. The makes the user experience smoother by not making them stop
the current cast and then start a new one manually in two stops.

Some shortcomings of this change that will be addressed in the future:

 - At least for mirroring, it's possible to avoid stopping the route and
   just switch the stream sources. This probably requires adding a new
   API to the extension.

 - The button will currently allow users to re-cast the current source,
   stopping the current route and starting a new one, even though this
   isn't necessary. When both the old and new sources are tabs, the tab
   IDs could be checked, but other cases would have to be handled in MR
   or the extension.

BUG= 614144 
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2002293003
Cr-Commit-Position: refs/heads/master@{#397457}
(cherry picked from commit 4680358215ff217eb6b0073c4be2243738369957)

Review-Url: https://codereview.chromium.org/2062913002
Cr-Commit-Position: refs/branch-heads/2743@{#340}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/9c975548118d7e2ed6e479d7b46699af98c3c484/chrome/browser/media/router/media_router_metrics.h
[modify] https://crrev.com/9c975548118d7e2ed6e479d7b46699af98c3c484/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html
[modify] https://crrev.com/9c975548118d7e2ed6e479d7b46699af98c3c484/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
[modify] https://crrev.com/9c975548118d7e2ed6e479d7b46699af98c3c484/chrome/browser/resources/media_router/elements/route_details/route_details.html
[modify] https://crrev.com/9c975548118d7e2ed6e479d7b46699af98c3c484/chrome/browser/resources/media_router/elements/route_details/route_details.js
[modify] https://crrev.com/9c975548118d7e2ed6e479d7b46699af98c3c484/chrome/browser/resources/media_router/media_router.js
[modify] https://crrev.com/9c975548118d7e2ed6e479d7b46699af98c3c484/chrome/browser/resources/media_router/media_router_data.js
[modify] https://crrev.com/9c975548118d7e2ed6e479d7b46699af98c3c484/chrome/test/data/webui/media_router/media_router_container_cast_mode_list_tests.js
[modify] https://crrev.com/9c975548118d7e2ed6e479d7b46699af98c3c484/chrome/test/data/webui/media_router/route_details_tests.js
[modify] https://crrev.com/9c975548118d7e2ed6e479d7b46699af98c3c484/tools/metrics/histograms/histograms.xml

Project Member

Comment 14 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9ff5fa98067da08a924ab74845ab7ebae7068d2

commit d9ff5fa98067da08a924ab74845ab7ebae7068d2
Author: btolsch <btolsch@chromium.org>
Date: Mon Jun 13 23:49:27 2016

[Media Router WebUI] Rename close route event in html

The event name used in media_router_container.html for closing routes
was not renamed by the previous change.

BUG= 614144 
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2036383002
Cr-Commit-Position: refs/heads/master@{#397792}
(cherry picked from commit e3c5d24288f9029a7ef82d6892f9d9afbb4fc607)

Review-Url: https://codereview.chromium.org/2061043002
Cr-Commit-Position: refs/branch-heads/2743@{#343}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/d9ff5fa98067da08a924ab74845ab7ebae7068d2/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html

Project Member

Comment 15 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07fc807ec68c553d2ca85efacda2e9c1081f0fc3

commit 07fc807ec68c553d2ca85efacda2e9c1081f0fc3
Author: btolsch <btolsch@chromium.org>
Date: Tue Jun 14 07:26:22 2016

[Media Router] Assign each route a current cast mode if possible

This change gives each media route in the WebUI a current cast mode
value if its media source corresponds to one of the currently available
cast modes. This is to prevent showing the 'cast' button that allows
replacing the route when the new route would effectively be a copy of
the original route.

BUG= 614144 
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2040883002
Cr-Commit-Position: refs/heads/master@{#398687}
(cherry picked from commit a47d5b0506c1183d501767d17ffec02ca419ea76)

Review-Url: https://codereview.chromium.org/2068593002
Cr-Commit-Position: refs/branch-heads/2743@{#347}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/07fc807ec68c553d2ca85efacda2e9c1081f0fc3/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html
[modify] https://crrev.com/07fc807ec68c553d2ca85efacda2e9c1081f0fc3/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
[modify] https://crrev.com/07fc807ec68c553d2ca85efacda2e9c1081f0fc3/chrome/browser/resources/media_router/elements/route_details/route_details.html
[modify] https://crrev.com/07fc807ec68c553d2ca85efacda2e9c1081f0fc3/chrome/browser/resources/media_router/elements/route_details/route_details.js
[modify] https://crrev.com/07fc807ec68c553d2ca85efacda2e9c1081f0fc3/chrome/browser/resources/media_router/media_router_data.js
[modify] https://crrev.com/07fc807ec68c553d2ca85efacda2e9c1081f0fc3/chrome/browser/ui/webui/media_router/media_router_ui.cc
[modify] https://crrev.com/07fc807ec68c553d2ca85efacda2e9c1081f0fc3/chrome/browser/ui/webui/media_router/media_router_ui.h
[modify] https://crrev.com/07fc807ec68c553d2ca85efacda2e9c1081f0fc3/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc
[modify] https://crrev.com/07fc807ec68c553d2ca85efacda2e9c1081f0fc3/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
[modify] https://crrev.com/07fc807ec68c553d2ca85efacda2e9c1081f0fc3/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.h
[modify] https://crrev.com/07fc807ec68c553d2ca85efacda2e9c1081f0fc3/chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc
[modify] https://crrev.com/07fc807ec68c553d2ca85efacda2e9c1081f0fc3/chrome/test/data/webui/media_router/media_router_container_route_tests.js
[modify] https://crrev.com/07fc807ec68c553d2ca85efacda2e9c1081f0fc3/chrome/test/data/webui/media_router/media_router_container_test_base.js
[modify] https://crrev.com/07fc807ec68c553d2ca85efacda2e9c1081f0fc3/chrome/test/data/webui/media_router/route_details_tests.js

Project Member

Comment 16 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/964f4bedd936ba690fcc196a653f9d3e9be13917

commit 964f4bedd936ba690fcc196a653f9d3e9be13917
Author: btolsch <btolsch@chromium.org>
Date: Tue Jun 14 17:33:14 2016

[Media Router WebUI] Prevent error when route becomes null

Once the route-details element is stamped, getSinkForRoute_ is bound to
currentRoute_. This becomes null if the route is stopped which causes
getSinkForRoute_ to throw an innocuous but noisy error. This change adds
a check of the route before dereferencing it.

BUG= 614144 
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2053743002
Cr-Commit-Position: refs/heads/master@{#399281}
(cherry picked from commit 16bc9a232bd6ef00891eb061687d23f77ee29efd)

Review-Url: https://codereview.chromium.org/2065023002
Cr-Commit-Position: refs/branch-heads/2743@{#351}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/964f4bedd936ba690fcc196a653f9d3e9be13917/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js

Labels: Needs-Feedback
btolsch@, can you please let us know if this can be tested manually ?
Labels: -Needs-Feedback
The general feature can be tested with these steps:

1. Enable Media Router with the media-router flag, either via command line or in chrome://flags.
2. Cast something to a device; let's consider casting a tab. Click "Cast..." from the browser overflow menu or the context menu and select a cast device.
3. Observe that once the casting starts, there is only a "stop" button shown in the dialog (i.e. no "cast" button is shown).
4. Go to another tab.
5. Open the Media Router dialog again (right click > "Cast...").
6. You should see a description of the previous cast action and there should now be a "cast" button and a "stop" button.
7. Click "cast".
8. Observe that the new tab is now being cast and there is no longer a cast button shown next to the "stop" button.
Labels: Hotlist-Fixit-PE2016
Project Member

Comment 20 by bugdroid1@chromium.org, Aug 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbc838f3a5ed945462a29818591753e2cdb04f5c

commit bbc838f3a5ed945462a29818591753e2cdb04f5c
Author: btolsch <btolsch@chromium.org>
Date: Tue Aug 09 07:35:35 2016

[Media Router WebUI] Move replace route responsibility to extension

Currently the MR dialog controls the replace route functionality by
stopping the current route and starting a new one when that completes.
This doesn't allow the extension to optimize the change of source. This
change replaces the current UI behavior by simply calling CreateRoute
with the same sink and new source. This requires an extension change to
support accepting CreateRoute calls to a sink with an existing route.

BUG= 614144 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2142613002
Cr-Commit-Position: refs/heads/master@{#410607}

[modify] https://crrev.com/bbc838f3a5ed945462a29818591753e2cdb04f5c/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html
[modify] https://crrev.com/bbc838f3a5ed945462a29818591753e2cdb04f5c/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
[modify] https://crrev.com/bbc838f3a5ed945462a29818591753e2cdb04f5c/chrome/browser/resources/media_router/elements/route_details/route_details.html
[modify] https://crrev.com/bbc838f3a5ed945462a29818591753e2cdb04f5c/chrome/browser/resources/media_router/elements/route_details/route_details.js
[modify] https://crrev.com/bbc838f3a5ed945462a29818591753e2cdb04f5c/chrome/browser/resources/media_router/media_router.js
[modify] https://crrev.com/bbc838f3a5ed945462a29818591753e2cdb04f5c/chrome/browser/resources/media_router/media_router_ui_interface.js
[modify] https://crrev.com/bbc838f3a5ed945462a29818591753e2cdb04f5c/chrome/test/data/webui/media_router/route_details_tests.js

Labels: Merge-Request-53
Requesting merge of last patch to M53.

Comment 22 by dimu@chromium.org, Aug 11 2016

Labels: -Merge-Request-53 Merge-Approved-53
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Please merge your change to M53 branch 2785 ASAP (latest before 5:00 PM PT, Friday 08/12) so we can take it in for next week beta. Thank you.
Project Member

Comment 24 by bugdroid1@chromium.org, Aug 11 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3bcc04e168881e79da6ae8091df2805f64d8fdcc

commit 3bcc04e168881e79da6ae8091df2805f64d8fdcc
Author: btolsch <btolsch@chromium.org>
Date: Thu Aug 11 04:16:43 2016

[Media Router WebUI] Move replace route responsibility to extension

Currently the MR dialog controls the replace route functionality by
stopping the current route and starting a new one when that completes.
This doesn't allow the extension to optimize the change of source. This
change replaces the current UI behavior by simply calling CreateRoute
with the same sink and new source. This requires an extension change to
support accepting CreateRoute calls to a sink with an existing route.

BUG= 614144 
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2142613002
Cr-Commit-Position: refs/heads/master@{#410607}
(cherry picked from commit bbc838f3a5ed945462a29818591753e2cdb04f5c)

Review-Url: https://codereview.chromium.org/2238773002
Cr-Commit-Position: refs/branch-heads/2785@{#560}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/3bcc04e168881e79da6ae8091df2805f64d8fdcc/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html
[modify] https://crrev.com/3bcc04e168881e79da6ae8091df2805f64d8fdcc/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
[modify] https://crrev.com/3bcc04e168881e79da6ae8091df2805f64d8fdcc/chrome/browser/resources/media_router/elements/route_details/route_details.html
[modify] https://crrev.com/3bcc04e168881e79da6ae8091df2805f64d8fdcc/chrome/browser/resources/media_router/elements/route_details/route_details.js
[modify] https://crrev.com/3bcc04e168881e79da6ae8091df2805f64d8fdcc/chrome/browser/resources/media_router/media_router.js
[modify] https://crrev.com/3bcc04e168881e79da6ae8091df2805f64d8fdcc/chrome/browser/resources/media_router/media_router_ui_interface.js
[modify] https://crrev.com/3bcc04e168881e79da6ae8091df2805f64d8fdcc/chrome/test/data/webui/media_router/route_details_tests.js

Status: Fixed (was: Assigned)
Brandon please re-open if there's anything else that still needs to be done here.

Sign in to add a comment