New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 614134 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Dragging a link doesn't use the right frame for OOPIF downloads

Project Member Reported by brettw@chromium.org, May 23 2016

Issue description

content\browser\download\drag_download_file.cc (InitiateDownload) creates a DownloadUrlParameters structure for downloading the link being dragged.

This uses the main frame of the WebContents. Instead, this should use the frame that actually contained the link.
 

Comment 1 by nasko@chromium.org, Dec 7 2016

Cc: creis@chromium.org nasko@chromium.org
Owner: paulmeyer@chromium.org
paulmeyer@, does this get resolved with the drag-n-drop work for OOPIFs?
No, that logic has not been changed with my update.
Labels: Needs-Feedback
Does anyone have any specific repro steps for this?
Owner: wjmaclean@chromium.org
Cc: brettw@chromium.org
Mac triage: what is the concrete bug here? Should this be assigned to a specific person?
It would help greatly to have a set of repro steps to see how this gets triggered. A quick glance at code search makes it appear that DragDownloadFile::Start is only called from tests at present.

In any case, we would need some sort of event coordinates to determine which frame we should be using ... presumably at some point the drag events go through RenderWidgetHostInputEventRouter?
Status: Assigned (was: Untriaged)
Mac triage: marking assigned to wjmaclean@

Sign in to add a comment