Remove python-path switching from gen_file_type_proto.py |
||||||
Issue descriptionThis is a clean up bug. Rather than doing the python path munching in gen_file_type_proto.py, we should do it in a wrapper by calling //build/gn_run_binary.py with the appropriate args: -Ss and also set $PTYHONPATH env var. This may be easier once we've gotten off of GYP.
,
Jun 3 2016
,
Sep 16 2016
,
Oct 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a0c75183f6dab0b8ab2953b34595d6fd5651b9bc commit a0c75183f6dab0b8ab2953b34595d6fd5651b9bc Author: sanfin <sanfin@google.com> Date: Mon Oct 31 20:03:30 2016 Allow gen_file_type_proto.py to work in virtualenv. There were complaints in crbug.com/605592 that virtualenv builds are broken with the strategy of passing -w to gen_file_type_proto.py. Systems can use virtualenv to isolate the Python environment from dist-packages, making the nested call to this script redundant (and broken, since -S breaks some assumptions from virtualenv). BUG= 605592 BUG=614082 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2341173004 Cr-Commit-Position: refs/heads/master@{#428777} [modify] https://crrev.com/a0c75183f6dab0b8ab2953b34595d6fd5651b9bc/chrome/browser/resources/safe_browsing/gen_file_type_proto.py
,
Jun 30 2017
,
Nov 10 2017
,
Feb 18 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by nparker@chromium.org
, May 23 2016